From 733990f88142cf195ccd1cdda92032e5723ab142 Mon Sep 17 00:00:00 2001 From: bwang Date: Fri, 1 Apr 2022 13:14:02 -0500 Subject: [PATCH] Small clean up and TOC update Change-Id: Ic093888cb2b06d8eef95a1317d791e7e1627d0f6 --- includes/SkinVector.php | 7 ---- .../templates/TableOfContents__line.mustache | 2 +- .../tableOfContents.test.js.snap | 20 +++++----- tests/jest/tableOfContents.test.js | 38 +++++++++---------- 4 files changed, 30 insertions(+), 37 deletions(-) diff --git a/includes/SkinVector.php b/includes/SkinVector.php index 01c837bc6..6399f7264 100644 --- a/includes/SkinVector.php +++ b/includes/SkinVector.php @@ -60,12 +60,6 @@ abstract class SkinVector extends SkinMustache { /** @var int */ private const MENU_TYPE_DROPDOWN = 2; private const MENU_TYPE_PORTAL = 3; - private const NO_ICON = [ - 'icon' => 'none', - 'is-quiet' => true, - 'tabindex' => '-1', - 'class' => 'sticky-header-icon' - ]; private const TALK_ICON = [ 'href' => '#', 'id' => 'ca-talk-sticky-header', @@ -495,7 +489,6 @@ abstract class SkinVector extends SkinMustache { */ public function getTemplateData(): array { $skin = $this; - $out = $skin->getOutput(); $parentData = $this->decoratePortletsData( parent::getTemplateData() ); $featureManager = VectorServices::getFeatureManager(); diff --git a/includes/templates/TableOfContents__line.mustache b/includes/templates/TableOfContents__line.mustache index 09fd407dc..88d6e39cc 100644 --- a/includes/templates/TableOfContents__line.mustache +++ b/includes/templates/TableOfContents__line.mustache @@ -1,4 +1,4 @@ - -
  • +
  • 1foo
    @@ -19,20 +19,20 @@ exports[`Table of contents when \`vector-is-collapse-sections-enabled\` is false
    • -
  • +
  • 2bar