wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 07:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update name of body class to avoid confusion

Browse source 
The class vector-feature-table-of-contents-disabled is confusing as
it shows on pages with table of contents. What it actually means
is the A/B test is disabled. This change gives it a more meaningful name.

Use the class name vector-feature-table-of-contents-legacy-toc-enabled
to describe it better.

Bug: T310527
Change-Id: I17e7e6f7f553b8c06b118b5419c98c78ef26ad60
This commit is contained in:
Jon Robson 2022-09-28 12:16:20 -07:00
parent 0fb0a187bf
commit 6b7bc78bae
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Constants.php
View file

@ -198,12 +198,12 @@ final class Constants {
/**
* @var string
*/
public const FEATURE_TABLE_OF_CONTENTS = 'TableOfContents';
public const FEATURE_TABLE_OF_CONTENTS_AB_TEST = 'TableOfContentsLegacyTOC';
/**
* @var string
*/
public const REQUIREMENT_TABLE_OF_CONTENTS = 'TableOfContents';
public const REQUIREMENT_TABLE_OF_CONTENTS_AB_TEST = 'TableOfContentsLegacy';
/**
* @var string

2
includes/FeatureManagement/Requirements/TableOfContentsTreatmentRequirement.php
View file

@ -52,7 +52,7 @@ final class TableOfContentsTreatmentRequirement implements Requirement {
* @inheritDoc
*/
public function getName(): string {
return Constants::REQUIREMENT_TABLE_OF_CONTENTS;
return Constants::REQUIREMENT_TABLE_OF_CONTENTS_AB_TEST;
}
/**

4
includes/ServiceWiring.php
View file

@ -193,10 +193,10 @@ return [
);
$featureManager->registerFeature(
Constants::FEATURE_TABLE_OF_CONTENTS,
Constants::FEATURE_TABLE_OF_CONTENTS_AB_TEST,
[
Constants::REQUIREMENT_FULLY_INITIALISED,
Constants::REQUIREMENT_TABLE_OF_CONTENTS,
Constants::REQUIREMENT_TABLE_OF_CONTENTS_AB_TEST,
]
);

2
includes/SkinVector22.php
View file

@ -45,7 +45,7 @@ class SkinVector22 extends SkinVector {
*/
public function isUserInTocTreatmentBucket(): bool {
$featureManager = VectorServices::getFeatureManager();
return $featureManager->isFeatureEnabled( Constants::FEATURE_TABLE_OF_CONTENTS );
return !$featureManager->isFeatureEnabled( Constants::FEATURE_TABLE_OF_CONTENTS_AB_TEST );
}
/**