Remove unnecessary imports in component stylesheets, make variable and mixin imports consistent

Bug: T345766
Change-Id: I2ae1d1668849a04520b73ac04fe16e1ff7f22fa6

resources/common/common.less

@@ -4,7 +4,7 @@
  */
 
 @import './variables.less';
-@import 'mediawiki.mixins.less';
+@import './mixins.less';
 
 @media screen {
 	// Common styles

resources/common/components/Footer.less

@@ -1,5 +1,3 @@
-@import '../variables.less';
-
 /* Footer */
 .mw-footer {
 	direction: ltr;

resources/common/components/Indicators.less

@@ -1,5 +1,3 @@
-@import '../variables.less';
-
 .mw-indicators {
 	font-size: @font-size-base;
 	line-height: @line-height-base;

resources/common/components/SidebarLogo.less

@@ -1,5 +1,3 @@
-@import '../variables.less';
-
 /* Logo */
 #p-logo {
 	width: 10em;

resources/common/components/SiteNotice.less

@@ -1,5 +1,3 @@
-@import '../variables.less';
-
 /** element that wraps a notice that comes from wiki page */
 #localNotice {
 	margin-bottom: 0.9em;

resources/common/mixins.less

@@ -2,7 +2,7 @@
  * Less mixins shared between both legacy and Vector 2022.
  */
 
-@import '../common/variables.less';
+@import 'mediawiki.mixins.less';
 
 .mixin-vector-menu-heading() {
 	align-self: center;

resources/skins.vector.styles.legacy/components/LegacySidebar.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-
 // Navigation: Main
 @font-size-nav-main: inherit;
 @font-size-nav-main-heading: unit( 12 / @font-size-browser, em ); // Equals `0.75em`.

resources/skins.vector.styles.legacy/components/MenuDropdown.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-@import '../../common/mixins.less';
-
 // Flips the chevron so it points up when the dropdown is open.
 .vector-menu-checkbox:checked + .vector-menu-heading::after {
 	transform: scaleY( -1 );

resources/skins.vector.styles.legacy/components/MenuTabs.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-
 /**
  * Styling for namespace tabs (page, discussion) and views (read, edit, view history, watch and other actions)
  */

resources/skins.vector.styles.legacy/components/SearchBox.less

@@ -1,5 +1,3 @@
-@import 'mediawiki.mixins.less';
-
 // Defined as `div`.
 // Provide extra element for gadgets due to `form` already carrying an `id`.
 .vector-search-box-inner {

resources/skins.vector.styles.legacy/components/TabWatchstarLink.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
 @import 'mediawiki.mixins.rotation.less';
 
 /* Watch/Unwatch Icon Styling */

resources/skins.vector.styles.legacy/components/UserLinks.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 /* Personal Menu */
 .vector-user-menu-legacy {
 	li {

resources/skins.vector.styles.legacy/skin-legacy.less

@@ -2,6 +2,8 @@
  * Vector legacy stylesheets
  * See '../common/common.less' for common screen and print Vector stylesheets.
  */
+@import '../common/variables.less';
+@import '../common/mixins.less';
 
 @media screen {
 	// Layouts

resources/skins.vector.styles/components/BottomDock.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 .client-nojs .vector-settings {
 	display: none;
 }

resources/skins.vector.styles/components/Button.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-@import 'mediawiki.skin.variables.less';
-
 .cdx-button:not( .cdx-button--icon-only ) .vector-icon {
 	// Add spacing between icon and text
 	margin-right: @spacing-35;

resources/skins.vector.styles/components/Dropdown.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 /**
  * Dropdown container
  */

resources/skins.vector.styles/components/Header.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 .mw-header {
 	// Vertical centering of header elements (IE>=11), requires Flexbox.
 	.flex-display();

resources/skins.vector.styles/components/Icon.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-
 .vector-icon {
 	.cdx-mixin-css-icon-background( );
 	.cdx-mixin-css-icon-size( );

resources/skins.vector.styles/components/LanguageDropdown.less

@@ -1,8 +1,3 @@
-// The use of mixins.buttons requires @font-size-base to be defined for this to work in Storybook
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 // Note vector-feature-language-in-header-enabled class is not used here as that class
 // only applies to main page.
 // This must be limited to vector-page-titlebar as the mw-portlet-lang class is shared with

resources/skins.vector.styles/components/Logo.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-
 .mw-logo {
 	.flex-display();
 	// If icon is not configured, ensure that the logo still takes up available

resources/skins.vector.styles/components/MainMenu.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 // Ensure there is only 1 main menu landmark at anytime
 &.vector-feature-main-menu-pinned-enabled .vector-header-start .vector-main-menu-landmark,
 &.vector-feature-main-menu-pinned-disabled .vector-main-menu-container .vector-main-menu-landmark {

resources/skins.vector.styles/components/MenuTabs.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
-
 /**
  * Styling for namespace tabs (page, discussion) and views (read, edit, view history, watch and other actions)
  */

resources/skins.vector.styles/components/PageTitlebar.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 .vector-page-titlebar {
 	position: relative;
 	display: flex;

resources/skins.vector.styles/components/PageToolbar.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-
 @border-base-ems: unit( @border-width-base / @font-size-browser / @font-size-base, em );
 
 .vector-page-toolbar-container {

resources/skins.vector.styles/components/PageTools.less

@@ -1,6 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-
 // Ensure there is only 1 page tools landmark at anytime
 &.vector-feature-page-tools-pinned-enabled .vector-page-toolbar-container .vector-page-tools-landmark,
 &.vector-feature-page-tools-pinned-disabled .vector-column-end .vector-page-tools-landmark {

resources/skins.vector.styles/components/PinnableElement.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 .vector-pinned-container .vector-pinnable-element {
 	// Make the heading border line up with the edge of the text
 	// (Whereas in a dropdown, the border lines up with the edge of the dropdown container).

resources/skins.vector.styles/components/SearchBox.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 // Search container
 // We have to put those styles outside `.skin-vector-search-vue`,
 // as we can't address no-JS modern and Vue enhanced otherwise.

resources/skins.vector.styles/components/StickyHeader.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 @spacing-search-title-divider: 30px;
 @font-size-sticky-header-links: unit( 14 / @font-size-browser, em ); // Equals `0.875em`.
 

resources/skins.vector.styles/components/TableOfContents.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-
 /**
  * Checkbox hack used by collapsed TOC on narrow viewports for no JS users.
  * Although it's display:none, the :checked state is still affected when clicking

resources/skins.vector.styles/components/UserLinks.less

@@ -1,7 +1,3 @@
-@import '../../common/variables.less';
-@import '../../common/mixins.less';
-@import 'mediawiki.mixins.less';
-
 @font-size-user-links: unit( 14 / @font-size-browser, em ); // Equals `0.875em`.
 // Applies to links in the overflow menu that do not have the .cdx-button class.
 @overflow-link-margin: 0 8px;

resources/skins.vector.styles/components/Watchstar.less

@@ -1,5 +1,3 @@
-@import '../../common/variables.less';
-@import 'mediawiki.mixins.less';
 @import 'mediawiki.mixins.rotation.less';
 
 /* Watch/Unwatch Icon Styling */

resources/skins.vector.styles/layouts/preZebra.less

@@ -1,5 +1,3 @@
-@import '../../common/mixins.less';
-
 .vector-header-container {
 	.mixin-page-container();
 }

resources/skins.vector.styles/skin.less

@@ -2,8 +2,6 @@
  * Vector modern stylesheets
  * See '../common/common.less' for common screen and print Vector stylesheets.
  */
-
-@import 'mediawiki.mixins.less';
 @import '../common/variables.less';
 @import '../common/mixins.less';
 

resources/skins.vector.zebra.styles/mixins.less

@@ -1,6 +1,7 @@
 /**
  * Less mixins.
  */
+@import 'mediawiki.mixins.less';
 
 .mixin-vector-page-container-sizing() {
 	// Set a min-width to make explicit we do not support anything below this threshold.

resources/skins.vector.zebra.styles/skin.less

@@ -6,7 +6,6 @@
  * the feature flag as been removed.
  */
 
-@import 'mediawiki.mixins.less';
 @import './variables.less';
 @import './mixins.less';