wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 07:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Hooks: Use private instead of public for internal functions"

Browse source
This commit is contained in:
jenkins-bot 2024-03-05 02:03:46 +00:00 committed by Gerrit Code Review
parent ac5ff328ed bfa48e6a10
commit 49a1f27bfe
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Hooks.php
View file

@ -365,7 +365,7 @@ class Hooks implements
* @param string $name
* @return string of HTML
*/
public static function makeIcon( $name ) {
private static function makeIcon( $name ) {
// Html::makeLink will pass this through rawElement
return '<span class="vector-icon mw-ui-icon-' . $name . ' mw-ui-icon-wikimedia-' . $name . '"></span>';
}
@ -424,7 +424,7 @@ class Hooks implements
* @param bool $unsetIcon should the icon field be unset?
* @return array $item Updated menu item data
*/
public static function updateMenuItemData( $item, $unsetIcon = true ) {
private static function updateMenuItemData( $item, $unsetIcon = true ) {
$buttonClassProp = 'link-class';
$iconHtmlProp = 'link-html';
return self::updateItemData( $item, $buttonClassProp, $iconHtmlProp, $unsetIcon );