From 337d608a5604f5c927ab13c461bd36327ef04a39 Mon Sep 17 00:00:00 2001 From: bwang Date: Mon, 6 May 2024 13:55:33 -0500 Subject: [PATCH] Fix red link color in dark mode Bug: T363778 Change-Id: Iae4fe2d793b8efbb10b54144ce4093c3e2112da2 --- .../vector-2022/mediawiki.skin.variables.less | 4 ---- resources/skins.vector.styles/CSSCustomProperties.less | 8 ++++++++ resources/skins.vector.styles/components/MenuTabs.less | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less b/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less index 4d94bb3fb..0e6c5c816 100644 --- a/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less +++ b/resources/mediawiki.less/vector-2022/mediawiki.skin.variables.less @@ -38,10 +38,6 @@ @color-link: @color-progressive; @color-link--visited: #795cb2; @color-link--active: #faa700; -// Link colors for new or missing articles, also known as “Red links”. -// https://www.wikidata.org/wiki/Q13417974#sitelinks-wikipedia -@color-link-new: @color-link-red; -@color-link-new--visited: @color-link-red--visited; // Link colors for a power user feature to highlight links to other projects. // In Vector 2022 we unify these colors by default for simpler orientation by average users. // It's still possible to overwrite the styles per user. diff --git a/resources/skins.vector.styles/CSSCustomProperties.less b/resources/skins.vector.styles/CSSCustomProperties.less index cd0f867c3..cf2a2374b 100644 --- a/resources/skins.vector.styles/CSSCustomProperties.less +++ b/resources/skins.vector.styles/CSSCustomProperties.less @@ -23,6 +23,10 @@ html.skin-theme-clientpref-night { color-scheme: dark; .cdx-mode-dark(); + + // T363911 Temporarily override Codex variable for Vector night mode release + // Remove after task has been resolved and new color is available in Codex. + --color-link-red: #b97876; } html.skin-theme-clientpref-night .skin-invert { @@ -44,6 +48,10 @@ html.skin-theme-clientpref-night .notheme { html.skin-theme-clientpref-os { color-scheme: light dark; .cdx-mode-dark(); + + // T363911 Temporarily override Codex variable for Vector night mode release + // Remove after task has been resolved and new color is available in Codex. + --color-link-red: #b97876; } html.skin-theme-clientpref-os .notheme { diff --git a/resources/skins.vector.styles/components/MenuTabs.less b/resources/skins.vector.styles/components/MenuTabs.less index 8175bd972..52c55f01e 100644 --- a/resources/skins.vector.styles/components/MenuTabs.less +++ b/resources/skins.vector.styles/components/MenuTabs.less @@ -33,7 +33,7 @@ .mw-list-item.new a, .mw-list-item.new a:visited { - color: @color-link-new; + color: @color-link-red; } .mw-list-item.selected a,