From 087808ece696df487eca654dd7656d76a3962341 Mon Sep 17 00:00:00 2001
From: VolkerE <volker.e@wikimedia.org>
Date: Wed, 8 Apr 2020 02:01:32 +0000
Subject: [PATCH] Revert "Move indicators underneath `#firstHeading` in DOM"

This reverts commit f400fc57c3afc15aa11057eb7d8b1b0228c5a754.

Bug: T248761
Change-Id: I3a4f1202d5e1cca9f82d1735cc498049fa25613c
---
 includes/VectorTemplate.php               |  2 +-
 includes/templates/index.mustache         |  2 +-
 includes/templates/legacy.mustache        |  2 +-
 resources/skins.vector.styles/common.less | 27 ++++++++++-------------
 variables.less                            |  2 --
 5 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/includes/VectorTemplate.php b/includes/VectorTemplate.php
index 5a9561433..75eeabc73 100644
--- a/includes/VectorTemplate.php
+++ b/includes/VectorTemplate.php
@@ -138,6 +138,7 @@ class VectorTemplate extends BaseTemplate {
 		$commonSkinData = [
 			'html-headelement' => $this->get( 'headelement', '' ),
 			'html-sitenotice' => $this->get( 'sitenotice', null ),
+			'html-indicators' => $this->getIndicators(),
 			'page-langcode' => $this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode(),
 			'page-isarticle' => (bool)$this->get( 'isarticle' ),
 
@@ -151,7 +152,6 @@ class VectorTemplate extends BaseTemplate {
 			'html-userlangattributes' => $this->get( 'userlangattributes', '' ),
 			// From OutputPage::getSubtitle()
 			'html-subtitle' => $this->get( 'subtitle', '' ),
-			'html-indicators' => $this->getIndicators(),
 
 			// TODO: Use directly Skin::getUndeleteLink() directly.
 			// Always returns string, cast to null if empty.
diff --git a/includes/templates/index.mustache b/includes/templates/index.mustache
index 53c361dc1..ac3d2188e 100644
--- a/includes/templates/index.mustache
+++ b/includes/templates/index.mustache
@@ -40,8 +40,8 @@
 <div id="content" class="mw-body" role="main">
 	<a id="top"></a>
 	{{#html-sitenotice}}<div id="siteNotice" class="mw-body-content">{{{html-sitenotice}}}</div>{{/html-sitenotice}}
-	<h1 id="firstHeading" class="firstHeading" lang="{{page-langcode}}">{{{html-title}}}</h1>
 	{{{html-indicators}}}
+	<h1 id="firstHeading" class="firstHeading" lang="{{page-langcode}}">{{{html-title}}}</h1>
 	{{{html-prebodyhtml}}}
 	<div id="bodyContent" class="mw-body-content">
 		{{#page-isarticle}}<div id="siteSub" class="noprint">{{msg-tagline}}</div>{{/page-isarticle}}
diff --git a/includes/templates/legacy.mustache b/includes/templates/legacy.mustache
index 53c361dc1..ac3d2188e 100644
--- a/includes/templates/legacy.mustache
+++ b/includes/templates/legacy.mustache
@@ -40,8 +40,8 @@
 <div id="content" class="mw-body" role="main">
 	<a id="top"></a>
 	{{#html-sitenotice}}<div id="siteNotice" class="mw-body-content">{{{html-sitenotice}}}</div>{{/html-sitenotice}}
-	<h1 id="firstHeading" class="firstHeading" lang="{{page-langcode}}">{{{html-title}}}</h1>
 	{{{html-indicators}}}
+	<h1 id="firstHeading" class="firstHeading" lang="{{page-langcode}}">{{{html-title}}}</h1>
 	{{{html-prebodyhtml}}}
 	<div id="bodyContent" class="mw-body-content">
 		{{#page-isarticle}}<div id="siteSub" class="noprint">{{msg-tagline}}</div>{{/page-isarticle}}
diff --git a/resources/skins.vector.styles/common.less b/resources/skins.vector.styles/common.less
index 979a73be5..fddb9b92b 100644
--- a/resources/skins.vector.styles/common.less
+++ b/resources/skins.vector.styles/common.less
@@ -79,6 +79,18 @@ body {
 		/* Change the default from mediawiki.skinning CSS to let indicators float into heading area */
 		overflow: visible;
 	}
+
+	.mw-indicators {
+		float: right;
+		font-size: @font-size-base;
+		line-height: @line-height-base;
+		position: relative;
+		z-index: @z-index-indicators;
+	}
+
+	.mw-indicator {
+		display: inline-block;
+	}
 }
 
 .mw-body-content {
@@ -160,21 +172,6 @@ pre,
 	font-size: @font-size-site-notice;
 }
 
-.mw-indicators {
-	float: right;
-	z-index: @z-index-indicators;
-
-	// FIXME: Delete in 2 weeks time from when this comment was added
-	// and merge #firstHeading .mw-indicator rule into above, see T248761
-	#firstHeading + & {
-		margin-top: @margin-top-indicators;
-	}
-}
-
-.mw-indicator {
-	display: inline-block;
-}
-
 .mw-jump-link:not( :focus ) {
 	.mixin-screen-reader-text;
 }
diff --git a/variables.less b/variables.less
index 05aa508d6..c44c3f73a 100644
--- a/variables.less
+++ b/variables.less
@@ -98,8 +98,6 @@
 // Using `unit()` without second parameter to achieve a unitless output for `line-height`.
 @line-height-nav-personal: unit( 14 / @font-size-browser / @font-size-nav-personal ); // Equals `1.667`.
 
-@margin-top-indicators: -( 38 / @font-size-browser / @font-size-base );
-
 // Tabs
 @font-size-tabs: unit( 13 / @font-size-browser, em ); // Equals `0.8125em`.