From 4f609e6ba1e1078e266990a4552f98ff324b9774 Mon Sep 17 00:00:00 2001 From: Novem Linguae Date: Tue, 28 May 2024 15:16:33 +0000 Subject: [PATCH] fix double id="p-variants" Should only have one HTML ID per page. I've decided to remove the first of the two duplicate IDs and to replace it with #vector-variants-dropdown, to match the code style of the similar #vector-user-links-dropdown Bug: T343730 Change-Id: I6abdc293c1dbb18faf9751b4633a572a019593ab --- includes/Components/VectorComponentVariants.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Components/VectorComponentVariants.php b/includes/Components/VectorComponentVariants.php index c60ef1a77..307faceab 100644 --- a/includes/Components/VectorComponentVariants.php +++ b/includes/Components/VectorComponentVariants.php @@ -45,7 +45,7 @@ class VectorComponentVariants implements VectorComponent { */ private function getDropdownData() { $dropdown = new VectorComponentDropdown( - $this->menuData[ 'id' ], + 'vector-variants-dropdown', $this->getDropdownLabel(), // Hide dropdown if menu is empty $this->menuData[ 'is-empty' ] ? 'emptyPortlet' : ''