wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-26 16:40:33 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/includes/templates/Header.mustache

18 lines
572 B
Plaintext
Raw Normal View History

Fix ToC dropdown menu spacing when visual next flag is enabled, address icon related feedback Causes 20 visual progressions regardless of visual next flag, the ToC moves 1px when in the sidebar Follow up to If3aed0ac401b0abc80c3ad52806eb85b33d43f06 Bug: T321504 Change-Id: I4b3ec90d8e79791a1bf17ba02c9f9d722499bec8
2022-11-04 16:18:20 +00:00
<header class="mw-header mw-ui-icon-flush-left mw-ui-icon-flush-right">
Remove CSS classes and selectors from cached HTML Bug: T316570 Depends-on: Ib4050768f20b1734d356104f18aa539f657099d8 Change-Id: I97f87b32402d7f4fd790f9a8b9abab42efd9d890
2022-10-17 21:27:57 +00:00
<div class="vector-header-start">
Page tools: Main menu is a dropdown This is an incomplete styling of the menu. This should be enough to start an initial design review and unblock other work on the dropdown. Out of scope for this patch: - Pinning (being done in T317900) - Design (will be done in follow up) This should cause no visual regressions in Pixel. Bug: T317899 Change-Id: Id7b47cc16fc8cf93d406687198ba37acf7a9cf24
2022-11-30 22:22:33 +00:00
{{^is-page-tools-enabled}}
{{>deprecated/MainMenuBtn}}
{{/is-page-tools-enabled}}
{{#is-page-tools-enabled}}
{{#data-portlets-main-menu}}
{{>MainMenuDropdown}}
{{/data-portlets-main-menu}}
{{/is-page-tools-enabled}}
Replace incorrectly mw- prefixed classes Rename template and CSS files to match updated naming conventions, replaces instances of "sidebar" with "main menu" Bug: T316570 Bug: T317437 Change-Id: Ib4050768f20b1734d356104f18aa539f657099d8
2022-10-17 20:09:53 +00:00
{{#data-logos}}{{>Logo}}{{/data-logos}}
[Grid preparation] Structure the header Restructure the header to have two child elements Change-Id: Ib5b7f31419ae6b62f62878947651b8ab843a3955
2022-05-04 22:20:23 +00:00
</div>
Remove CSS classes and selectors from cached HTML Bug: T316570 Depends-on: Ib4050768f20b1734d356104f18aa539f657099d8 Change-Id: I97f87b32402d7f4fd790f9a8b9abab42efd9d890
2022-10-17 21:27:57 +00:00
<div class="vector-header-end">
Replace incorrectly mw- prefixed classes Rename template and CSS files to match updated naming conventions, replaces instances of "sidebar" with "main menu" Bug: T316570 Bug: T317437 Change-Id: Ib4050768f20b1734d356104f18aa539f657099d8
2022-10-17 20:09:53 +00:00
{{#data-search-box}}{{>SearchBox}}{{/data-search-box}}
{{#data-vector-user-links}}{{>UserLinks}}{{/data-vector-user-links}}
[Grid preparation] Structure the header Restructure the header to have two child elements Change-Id: Ib5b7f31419ae6b62f62878947651b8ab843a3955
2022-05-04 22:20:23 +00:00
</div>
Switch to navigation-first DOM order under `$wgVectorIsSearchInHeader` feature flag This moves the header, navigation, sidebar, and article toolbar to be before the content in the DOM. As a result, a lot of absolute positioning logic can be removed and styles can be simplified. Note that although the sidebar was moved from the header into the workspace container allowing it to de-absolutely positioned, its absolute positioning was kept intact as it has a fair amount of complexity that should be handled in a separate task. To activate, set `$wgVectorIsSearchInHeader = true;` Changes that could cause concern: * The "jump to search" link was removed as the search is now much earlier in the DOM and I questioned the value of keeping this. However, it can be added back in if this change is contentious. * A "jump to content" link was added to account for the new DOM order. * Because the sidebar was taken out of the header, users will not be able to tab from the sidebar button into the sidebar without additional tweaking (e.g. should we add JS to enable this?). It was deemed that this work can be saved as a follow-up task. * I applied `overflow-y: auto` to the `mw-page-container` because the header's top margin was collapsing and caused whitespace to appear between the viewport and the header. Alternatively, we could apply a top padding to the page container and remove the header's top margin. I went for the simplest solution but am open to alternatives. * I left the footer as-is in this patch to minimize risk. It might be cleaner later on to move the footer inside the workspace container which would leave only one workspace container. Bug: T261802 Change-Id: Ic553fab3bde25769b103d899b92b3b694c00c384
2020-09-08 23:20:58 +00:00
</header>
Reference in a new issue Copy permalink