wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 23:55:53 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/resources/common/components/Footer.less

45 lines
552 B
Plaintext
Raw Normal View History

Reorganize LESS files to match ResourceLoader conventions Separating most LESS files into 2 ResourceLoader modules and a common folder: - skins.vector.styles - skins.vector.styles.legacy - common This changes aims to clearly separate the old (“legacy”), the new (“modern”) and the common styles which were previously all placed under `skins.vector.styles/`. Inside each directory are separate folders for `layouts` and `components`. The entry files, `skin.less` and `skin-legacy.less` are moved into the specific folders and a third, `common.less` entry file is created that contains the common imports for both old and new Vector. Aliases have been added to the Storybook Webpack config to avoid adding the story file changes to this patch. Images coming from CSS `url()`'s have also been temporarily disabled in Storybook until Storybook can be upgraded to use Webpack 5, and use array values for aliases, in a follow-up patch. This patch also slightly changes a footer layout specific rule so that existing `padding` remains unchanged in rendering due to new common and component structure. Bug: T264309 Change-Id: I1cd2681a2b61edb7be56c38f9bb3994827d7e322
2021-02-02 10:04:37 +00:00
@import '../variables.less';
Add storybook to Vector - Update package.json with the new dependencies. - A script storybook.sh pulls down CSS and LESS imports from external dependencies. This copies the approach taken in Popups and MobileFrontend. - Icons from external repos are maintained within the repo in SVG-only form. Using load.php modules is also possible, but will pull down other unnecessary icons and break if any of these modules are changed. Decided that we should manually maintain these for the time being given there are only 3 icons. - Several LESS files now import the variables file. I think it's useful for stories to only import the CSS they use as this encourages us to modularise our CSS. Before these imports were not necessary as they inherit imports from index.less. This will have no impact on the bundle size as the LESS compiler silently discards duplicate imports - stories/utils.js provides a useful placeholder function for generalising our hook entry points. Bug: T242674 Change-Id: I722e84d2fb57653a2f96142dc3e5248043261746
2020-01-09 22:11:00 +00:00
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
/* Footer */
Add `.mw-footer` CSS class & replace `#footer` selector with it Does not add `.mw-footer-*` CSS classes to `ul#footer-*` and `li#footer-*-*` to save bandwidth. NOTE: - The former id selectors can be removed form the styles after the varnish cache is updated with the new DOM. - The modern version still uses the legacy layout at this stage. Bug: T248137 Change-Id: Ica9f8c43617c624648fa12dc86ebb3daa10f0409
2020-04-23 22:16:28 +00:00
.mw-footer {
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
direction: ltr;
ul {
styles: Replace IE hack `list-style: none none` Hack has first been introduced in I7d4b075ac90 more than 4 years ago. It has been introduced to tackle IE <=8. Bug: T306486 Bug: T308344 Change-Id: Ie84a177f79d226be98298a42ebfdd447e33a1372
2022-07-20 15:31:56 +00:00
list-style: none;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
margin: 0;
padding: 0;
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
}
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
li {
Align LESS color variables to naming scheme, combine and cleanup Merging similar value applications in generalized variables, and aligning to property-identifier-modifier scheme. Change-Id: I274ef24140a36e285c67b33a41ab6afe7c98676b
2019-09-26 21:12:01 +00:00
color: @color-base;
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
margin: 0;
padding: 0.5em 0;
Unify LESS variable naming scheme for `@font-size-*` variables Unifying variable naming to property-identifier-modifier scheme, while also collecting all non-print values variables in corresponding file. We will amend the `em` based values to calculations that will enable rendered full pixel values and also fix some connected usability issues in the future. Change-Id: I378e8a2af91fe0790708e6fb2d2e7a5718ce93c5
2019-09-26 23:43:42 +00:00
font-size: @font-size-footer;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
}
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
}
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
#footer-icons {
float: right;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
li {
float: left;
margin-left: 0.5em;
Unify LESS variable naming scheme for `@line-height-*` variables Unifying variable naming to property-identifier-modifier scheme. Settling on non-em-based `line-height` values with one exception of Vector tabs, where removing `em` would lead to different calculation. Also removing unneeded `inherit` assignment on content paragraphs that has been part since Ic5ba836364. Bug: T4013 Change-Id: I514467e4065d27de8d0ea82cdd3d23ccef6cffe3
2019-09-27 04:25:59 +00:00
line-height: @line-height-footer-buttons;
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
text-align: right;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
}
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
}
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
#footer-info {
li {
Unify LESS variable naming scheme for `@line-height-*` variables Unifying variable naming to property-identifier-modifier scheme. Settling on non-em-based `line-height` values with one exception of Vector tabs, where removing `em` would lead to different calculation. Also removing unneeded `inherit` assignment on content paragraphs that has been part since Ic5ba836364. Bug: T4013 Change-Id: I514467e4065d27de8d0ea82cdd3d23ccef6cffe3
2019-09-27 04:25:59 +00:00
line-height: @line-height-footer-info;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
}
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
}
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
Reduce footer selector specificity and clean up CSS Reducing specificity, simplifying output and merging `padding` in one place into one shorthand attribute. Change-Id: Ida96f18e9d90d55492ea114a7b5e3e1b8020c71f
2019-09-19 05:37:22 +00:00
#footer-places {
li {
float: left;
margin-right: 1em;
Unify LESS variable naming scheme for `@line-height-*` variables Unifying variable naming to property-identifier-modifier scheme. Settling on non-em-based `line-height` values with one exception of Vector tabs, where removing `em` would lead to different calculation. Also removing unneeded `inherit` assignment on content paragraphs that has been part since Ic5ba836364. Bug: T4013 Change-Id: I514467e4065d27de8d0ea82cdd3d23ccef6cffe3
2019-09-27 04:25:59 +00:00
line-height: @line-height-footer-buttons;
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d
2014-08-07 11:38:34 +00:00
}
}
Reference in a new issue Copy permalink