wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 15:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/stories/Menu.stories.data.js

77 lines
5.5 KiB
JavaScript
Raw Normal View History

build: Update devDependencies Applies new ESLint documentation rules Change-Id: I7fe458cf52e98baf92f3baec2d9ff54484326673
2020-06-08 22:14:37 +00:00
/**
* @external MenuDefinition
*/
/* eslint-disable quotes */
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
import menuTemplate from '!!raw-loader!../includes/templates/Menu.mustache';
Refactor: html-userlangattributes -> html-user-language-attributes This matches the name in core and is needed in preparation for switching to SkinMustache Additional change: The JS variable htmluserlangattributes is renamed "htmlUserLanguageAttributes" Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
2020-07-14 21:40:28 +00:00
import { htmlUserLanguageAttributes } from './utils';
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
/**
* @type {MenuDefinition}
*/
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
const loggedOut = {
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
id: 'p-personal',
Class names with hyphens preferred over camel case The classes were recently changed so provided this is merged before next branch cut no need to worry about cached HTML. Bug: T249073 Change-Id: Ib20c7a359bda858df89ebb245e682d321dd5acd0
2020-05-07 16:51:46 +00:00
class: 'vector-menu',
Reduce distribution of legacy classes The .menu class historically only needs to apply to dropdowns. the .vectorMenuCheckbox is inconsistent with the other classes on the menu so we should begin its deprecation. Bug: T253329 Change-Id: I00b4d2fd795195cd9c8add650a3b3cafdced5465
2020-05-21 18:49:24 +00:00
'list-classes': 'vector-menu-content-list',
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
'label-id': 'p-personal-label',
label: 'Personal tools',
Refactor: html-userlangattributes -> html-user-language-attributes This matches the name in core and is needed in preparation for switching to SkinMustache Additional change: The JS variable htmluserlangattributes is renamed "htmlUserLanguageAttributes" Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
2020-07-14 21:40:28 +00:00
'html-user-language-attributes': htmlUserLanguageAttributes,
Remove stray quote from logged out menu story This stray quote has been bugging me for hours if not years. I thought my monitor had a speck of dust on it, but it turns out it is simply a misplaced quote. Change-Id: I93b408eb22830590d1f06ff5326cee9be0f5330a
2020-05-08 19:17:53 +00:00
'html-items': `<li id="pt-anonuserpage">Not logged in</li><li id="pt-anontalk"><a href="/wiki/Special:MyTalk" title="Discussion about edits from this IP address [⌃⌥n]" accesskey="n">Talk</a></li><li id="pt-anoncontribs"><a href="/wiki/Special:MyContributions" title="A list of edits made from this IP address [⌃⌥y]" accesskey="y">Contributions</a></li><li id="pt-createaccount"><a href="/w/index.php?title=Special:CreateAccount&amp;returnto=Main+Page" title="You are encouraged to create an account and log in; however, it is not mandatory">Create account</a></li><li id="pt-login"><a href="/w/index.php?title=Special:UserLogin&amp;returnto=Main+Page" title="You're encouraged to log in; however, it's not mandatory. [⌃⌥o]" accesskey="o">Log in</a></li>`
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
};
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
/**
* @type {MenuDefinition}
*/
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
const loggedInWithEcho = {
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
id: 'p-personal',
Class names with hyphens preferred over camel case The classes were recently changed so provided this is merged before next branch cut no need to worry about cached HTML. Bug: T249073 Change-Id: Ib20c7a359bda858df89ebb245e682d321dd5acd0
2020-05-07 16:51:46 +00:00
class: 'vector-menu',
Reduce distribution of legacy classes The .menu class historically only needs to apply to dropdowns. the .vectorMenuCheckbox is inconsistent with the other classes on the menu so we should begin its deprecation. Bug: T253329 Change-Id: I00b4d2fd795195cd9c8add650a3b3cafdced5465
2020-05-21 18:49:24 +00:00
'list-classes': 'vector-menu-content-list',
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
'label-id': 'p-personal-label',
label: 'Personal tools',
Refactor: html-userlangattributes -> html-user-language-attributes This matches the name in core and is needed in preparation for switching to SkinMustache Additional change: The JS variable htmluserlangattributes is renamed "htmlUserLanguageAttributes" Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
2020-07-14 21:40:28 +00:00
'html-user-language-attributes': htmlUserLanguageAttributes,
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
'html-items': `<li id="pt-userpage"><a href="/wiki/User:Jdlrobson" dir="auto" title="Your user page [⌃⌥.]" accesskey=".">Jdlrobson</a></li><li id="pt-notifications-alert"><a href="/wiki/Special:Notifications" class="mw-echo-notifications-badge mw-echo-notification-badge-nojs oo-ui-icon-bell mw-echo-notifications-badge-all-read" data-counter-num="0" data-counter-text="0" title="Your alerts">Alerts (0)</a></li><li id="pt-notifications-notice"><a href="/wiki/Special:Notifications" class="mw-echo-notifications-badge mw-echo-notification-badge-nojs oo-ui-icon-tray" data-counter-num="3" data-counter-text="3" title="Your notices">Notices (3)</a></li><li id="pt-mytalk"><a href="/wiki/User_talk:Jdlrobson" title="Your talk page [⌃⌥n]" accesskey="n">Talk</a></li><li id="pt-sandbox"><a href="/wiki/User:Jdlrobson/sandbox" title="Your sandbox">Sandbox</a></li><li id="pt-preferences"><a href="/wiki/Special:Preferences" title="Your preferences">Preferences</a></li><li id="pt-betafeatures"><a href="/wiki/Special:Preferences#mw-prefsection-betafeatures" title="Beta features">Beta</a></li><li id="pt-watchlist"><a href="/wiki/Special:Watchlist" title="A list of pages you are monitoring for changes [⌃⌥l]" accesskey="l">Watchlist</a></li><li id="pt-mycontris"><a href="/wiki/Special:Contributions/Jdlrobson" title="A list of your contributions [⌃⌥y]" accesskey="y">Contributions</a></li><li id="pt-logout"><a href="/w/index.php?title=Special:UserLogout&amp;returnto=Main+Page&amp;returntoquery=useskin%3Dvector" title="Log out">Log out</a></li>`
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
};
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
const ULS_LANGUAGE_SELECTOR = '<li class="uls-trigger active"><a href="#">English</a></li>';
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
/**
* @type {MenuDefinition}
*/
const defaultMenu = {
id: 'p-generic',
Class names with hyphens preferred over camel case The classes were recently changed so provided this is merged before next branch cut no need to worry about cached HTML. Bug: T249073 Change-Id: Ib20c7a359bda858df89ebb245e682d321dd5acd0
2020-05-07 16:51:46 +00:00
class: 'vector-menu',
Reduce distribution of legacy classes The .menu class historically only needs to apply to dropdowns. the .vectorMenuCheckbox is inconsistent with the other classes on the menu so we should begin its deprecation. Bug: T253329 Change-Id: I00b4d2fd795195cd9c8add650a3b3cafdced5465
2020-05-21 18:49:24 +00:00
'list-classes': 'vector-menu-content-list',
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
'label-id': 'p-generic-label',
label: 'Menu label',
Refactor: html-userlangattributes -> html-user-language-attributes This matches the name in core and is needed in preparation for switching to SkinMustache Additional change: The JS variable htmluserlangattributes is renamed "htmlUserLanguageAttributes" Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
2020-07-14 21:40:28 +00:00
'html-user-language-attributes': htmlUserLanguageAttributes,
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
'html-items': `<li><a href='#'>Item 1</a></li>
<li><a href='#'>Item 2</a></li>
<li><a href='#'>Item 3</a></li>`
};
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
/**
* @type {MenuDefinition}
*/
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
const loggedInWithULS = {
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
id: 'p-personal',
Class names with hyphens preferred over camel case The classes were recently changed so provided this is merged before next branch cut no need to worry about cached HTML. Bug: T249073 Change-Id: Ib20c7a359bda858df89ebb245e682d321dd5acd0
2020-05-07 16:51:46 +00:00
class: 'vector-menu',
Reduce distribution of legacy classes The .menu class historically only needs to apply to dropdowns. the .vectorMenuCheckbox is inconsistent with the other classes on the menu so we should begin its deprecation. Bug: T253329 Change-Id: I00b4d2fd795195cd9c8add650a3b3cafdced5465
2020-05-21 18:49:24 +00:00
'list-classes': 'vector-menu-content-list',
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
'label-id': 'p-personal-label',
label: 'Personal tools',
Refactor: html-userlangattributes -> html-user-language-attributes This matches the name in core and is needed in preparation for switching to SkinMustache Additional change: The JS variable htmluserlangattributes is renamed "htmlUserLanguageAttributes" Change-Id: I306ebb615f720852fb35c25ac240d6b802d05ecc
2020-07-14 21:40:28 +00:00
'html-user-language-attributes': htmlUserLanguageAttributes,
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
'html-items': `${ULS_LANGUAGE_SELECTOR}<li id="pt-userpage"><a href="/wiki/User:Jdlrobson" dir="auto" title="Your user page [⌃⌥.]" accesskey=".">Jdlrobson</a></li><li id="pt-notifications-alert"><a href="/wiki/Special:Notifications" class="mw-echo-notifications-badge mw-echo-notification-badge-nojs oo-ui-icon-bell mw-echo-notifications-badge-all-read" data-counter-num="0" data-counter-text="0" title="Your alerts">Alerts (0)</a></li><li id="pt-notifications-notice"><a href="/wiki/Special:Notifications" class="mw-echo-notifications-badge mw-echo-notification-badge-nojs oo-ui-icon-tray" data-counter-num="3" data-counter-text="3" title="Your notices">Notices (3)</a></li><li id="pt-mytalk"><a href="/wiki/User_talk:Jdlrobson" title="Your talk page [⌃⌥n]" accesskey="n">Talk</a></li><li id="pt-sandbox"><a href="/wiki/User:Jdlrobson/sandbox" title="Your sandbox">Sandbox</a></li><li id="pt-preferences"><a href="/wiki/Special:Preferences" title="Your preferences">Preferences</a></li><li id="pt-betafeatures"><a href="/wiki/Special:Preferences#mw-prefsection-betafeatures" title="Beta features">Beta</a></li><li id="pt-watchlist"><a href="/wiki/Special:Watchlist" title="A list of pages you are monitoring for changes [⌃⌥l]" accesskey="l">Watchlist</a></li><li id="pt-mycontris"><a href="/wiki/Special:Contributions/Jdlrobson" title="A list of your contributions [⌃⌥y]" accesskey="y">Contributions</a></li><li id="pt-logout"><a href="/w/index.php?title=Special:UserLogout&amp;returnto=Main+Page&amp;returntoquery=useskin%3Dvector" title="Log out">Log out</a></li>`
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
};
Refactor: Standardize menu data (DRY!) VectorTemplate has various functions that repeat themselves, only differing in their choice of names. This refactor begins by focusing on the personal menu and introducing a generic getMenuData function. Hardcoded `p-personal` is replaced with an `id` template key and `msg-label` is renamed `label`. Future patches will simplify VectorTemplate by using this new function. You'll note the resulting PersonalMenu.mustache file is identical to VectorTabs. These will be merged in I098e6921e8f7ef65dacacf09b9c25f70c945e58e Bug: T249372 Change-Id: I5ae44a1008b065381eeff93f9fa625be5c5a9de9
2020-04-03 20:05:22 +00:00
/**
* @type {Object.<string, MenuDefinition>}
*/
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
const PERSONAL_MENU_TEMPLATE_DATA = {
loggedOut,
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
defaultMenu,
Use template partials rather than HTML strings CHANGES to index.mustache: Changes can be understood by looking at the diff of the file stories/skin.stories.js The additional changes in stories folder export the data passed to those templates. A new file is used as exporting any variable in a file suffixed stories.js will be assumed to be a story entry. The changes to index.mustache are as follows: * html-footer is replaced with data-footer and Footer component is rendered via template partial * html-navigation is replaced with data-navigation and Navigation component is rendered via template partial CHANGES to Navigation.mustache: Changes are best explained by looking at the diff to stories/navigation.stories.js and navigation.stories.data.js * html-personal-menu is replaced with data-personal-menu Bug: T245456 Change-Id: Ie96e92447a932b8a7f3844df277a1d31a2af423c
2020-02-17 19:49:43 +00:00
loggedInWithEcho,
loggedInWithULS
};
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
export { PERSONAL_MENU_TEMPLATE_DATA, menuTemplate };
Reference in a new issue Copy permalink