wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-12 09:21:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/resources/skins.vector.styles/skin-legacy.less

28 lines
586 B
Plaintext
Raw Normal View History

Organize CSS by common, layout, typography and components Moving styles from the existing styles to common/layout or components stylesheets they should be associated with. Components are identified using PascalCase. Lowercase names are used for things that are not components. This distinction should help us reason with the code better and make it clearer where CSS belongs, saving us lots of wasted effort discussing conventions. Patch isn't making actual CSS changes themselves - for testing purposes this should be a NOOP. In preparation for the gradient removal, 'background-gradient.less' is marked as legacy. Merged 'externalLinks.less' into content.less, they belong to content. Bug: T249073 Change-Id: I8dbc29b7a19f7613b57b0984a8befaeae9c08798
2020-04-09 19:16:36 +00:00
// Legacy Vector stylesheets
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
@import '../../variables.less';
Organize CSS by common, layout, typography and components Moving styles from the existing styles to common/layout or components stylesheets they should be associated with. Components are identified using PascalCase. Lowercase names are used for things that are not components. This distinction should help us reason with the code better and make it clearer where CSS belongs, saving us lots of wasted effort discussing conventions. Patch isn't making actual CSS changes themselves - for testing purposes this should be a NOOP. In preparation for the gradient removal, 'background-gradient.less' is marked as legacy. Merged 'externalLinks.less' into content.less, they belong to content. Bug: T249073 Change-Id: I8dbc29b7a19f7613b57b0984a8befaeae9c08798
2020-04-09 19:16:36 +00:00
@import 'mediawiki.mixins.less';
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
@media screen {
[less] Extract cross-browser normalization rules into new 'normalize.less' Change-Id: I23da024b47020212173380315acd37210b924327
2020-06-12 00:24:17 +00:00
@import 'common/normalize.less';
Refactor: Revert to previous ordering In I23f18fc5f078da3331cad540bbaf533d348f2108 layout was pulled out into a separate file and we changed the ordering of our CSS. This was done with the thinking that media print queries would be mixed with media screen. After discussions with Volker, I have been convinced this was a mistake. media queries of the same type can be nested so the @media screen is removed from layout.less and the media query in index.less will be used instead. Change-Id: I3aab00c9bcc734ea1ba5a9cf242c6e36ac1cc076
2020-04-27 18:38:14 +00:00
@import 'legacy/layout.less';
Organize CSS by common, layout, typography and components Moving styles from the existing styles to common/layout or components stylesheets they should be associated with. Components are identified using PascalCase. Lowercase names are used for things that are not components. This distinction should help us reason with the code better and make it clearer where CSS belongs, saving us lots of wasted effort discussing conventions. Patch isn't making actual CSS changes themselves - for testing purposes this should be a NOOP. In preparation for the gradient removal, 'background-gradient.less' is marked as legacy. Merged 'externalLinks.less' into content.less, they belong to content. Bug: T249073 Change-Id: I8dbc29b7a19f7613b57b0984a8befaeae9c08798
2020-04-09 19:16:36 +00:00
@import 'common/typography.less';
// Components
@import 'Indicators.less';
@import 'SiteNotice.less';
Refactor: Generalise personal menu the PersonalMenu should be generalised. In future we will use it as the template for all menus Bug: T249372 Change-Id: Id1c43d2e9eefef1d7aec45f0137e27f10ad935df
2020-05-05 23:26:35 +00:00
@import 'Menu.less';
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
@import 'SearchBox.less';
Refactor: Merge VectorTabs into Menu Bug: T249372 Change-Id: Ib6ae191b31564dc23a3b1d6aedf48cbaaad006af
2020-05-06 17:15:50 +00:00
@import 'MenuTabs.less';
Organize CSS by common, layout, typography and components Moving styles from the existing styles to common/layout or components stylesheets they should be associated with. Components are identified using PascalCase. Lowercase names are used for things that are not components. This distinction should help us reason with the code better and make it clearer where CSS belongs, saving us lots of wasted effort discussing conventions. Patch isn't making actual CSS changes themselves - for testing purposes this should be a NOOP. In preparation for the gradient removal, 'background-gradient.less' is marked as legacy. Merged 'externalLinks.less' into content.less, they belong to content. Bug: T249073 Change-Id: I8dbc29b7a19f7613b57b0984a8befaeae9c08798
2020-04-09 19:16:36 +00:00
@import 'TabWatchstarLink.less';
Refactor: VectorMenu merged in to Menu Bug: T249372 Change-Id: Ifaf78b507c12aa251228213c89751cbb4d111d9a
2020-05-06 00:00:56 +00:00
@import 'MenuDropdown.less';
Refactor: Portal is also a Menu To complete the refactor, the Portal is also refactored as a Menu using the getMenu function. An old code path supporting portals outputted by hooks with strings is marked as deprecated to simplify this code in future. array-portals-first -> data-portals-first (the value is not an array) Changes: * $this->getLanguages and $this->getToolbox() always returns an array (see BaseTemplate) but we previously supported portals made using raw HTML. Let's move away from that behaviour and deprecate it. * Hooks are moved into buildSidebarProps and marked as deprecated where possible (SkinTemplateToolboxEnd). SidebarBeforeOutput can be used instead. Bug: T249372 Change-Id: I2549af3e24e5d51c09e9a88ca50a0d9b2e154c3f
2020-04-07 23:21:20 +00:00
@import 'MenuPortal.less';
[dev][Legacy] split sidebar Mustache and Less Split out the sidebar in advance of significant Latest mode only changes. The Less split was made by adding a new Sidebar.less file that imports the Legacy implementation. The Mustache split was made by file copying the existing implementation into a legacy/ subfolder. Both the Legacy and Latest implementations were then stripped of templates not applicable to their modes. These changes are aligned with the splits for JavaScript. Bug: T246419 Change-Id: Ib82769ea16bfc09efe8a088220aab55bdde0d381
2020-05-15 00:58:21 +00:00
@import 'legacy/Sidebar.less';
[legacy] Split sidebar code and mark layout as legacy in preparation for new layout Going into the new version of Vector, we'll want to rewrite the layout rules entirely and decouple the sidebar from the logo. To prepare for this we will move the layout file into a legacy folder. We also separate Sidebar styles needed for the legacy mode from the old mode. This will allow us to make changes to the header in new Vector without having to touch or test the legacy codebase via a new file layout.less and using the existing sidebar code. Bug: T246170 Change-Id: Ieb4f8f2b2f0e4f48d76a210ab30acd08e3e83bcb
2020-04-14 22:44:33 +00:00
@import 'SidebarLogo.less';
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
@import 'Footer.less';
}
Collapse media print query Per discussions, its proposed that the target of all media queries is defined in the entry points skin and skin-legacy Please verify with `git diff HEAD^ -w` that no changes to print styles have occurred Bug: T253842 Change-Id: Id7d1c806d77ee50335a1c9985acc7e4406e64ccf
2020-07-23 17:43:10 +00:00
@media print {
@import 'common/print.less';
}
Reference in a new issue Copy permalink