mediawiki-skins-Vector/resources/skins.vector.styles.legacy/components/Menu.less

.mw-portlet {
	// Hidden by default, but displayed by certain menus
	// e.g. MenuPortal
	.vector-menu-heading {
		display: none;
	}

	ul {
		list-style: none;
		margin: 0;
	}
}
Drop unsupported skin CSS classes Drop support for vectorMenu, vectorTabs and vectorMenuCheckbox, body, menu selectors in preference for standard selectors. This change will impact a large amount of user scripts/styles but should not impact any gadgets. These classes were kept around for user scripts and styles however are not needed internally. As we transition to a more maintainable skin menu system, it is time to lose these selectors even though this will cause disruption. Vector now will use the mw-portlet class rather than the vector-menu class in its own CSS styling, however it keeps the other classes to allow differentiation of the different types of menu. Changes to test: Previously the tests assumed all portlets were empty when checking the classes. This is very rare, so its better to check the classes of non-empty portlets, so several tests are updated accordingly to drop the emptyPortlet class. Bug: T262092 Change-Id: I1824335eb47d613c2a4804ec1f1106c0f4c16101 2020-09-04 19:34:05 +00:00			`.mw-portlet {`
Refactor: Simplify and standardize menu definitions * Standardise the menu markup. This means all menus in Vector will now be wrapped in a div and will have a heading. * All menus now have the vector-menu class. Styles specific to personal tools are moved to layout since these are concerned with placement. * The ul class will always have menu class. * emptyPortal class is generalised into vector-menu-empty for consistency with other classes and moved from common.less into Menu.less * Standardise hooks - BaseTemplateAfterPortlet can now be run on any menu. Changes to HTML: * lang and dir attributes are moved from the h3 up to the div element .vectorTabs, .portal(s) and #p-personal now has hidden span element inside h3 * for non portals ul.menu" is now wrapped in a div.vector-menu-content This change does impact the following CSS selectors which will need to be updated: I see no matches for these selectors in code search. ``` #p-variants > ul #p-namespaces > ul #p-personal > ul #p-views > ul #p-cactions > ul ``` Using global-search.toolforge.org I see one match for p-variants, 26 for p-namespaces, 30 for p-personal, 36 for p-views and 7 for p-cactions. I see this as acceptable breakage provided a user notice is sent out which it has been (T252447) Bug: T249372 Change-Id: Id59234aa6b822a24848386bdc04d8d7ed37ca145 2020-04-16 18:40:39 +00:00			`// Hidden by default, but displayed by certain menus`
			`// e.g. MenuPortal`
Update Vector menu CSS to use `vector-menu-heading` instead of `h3` Replaced h3 tag in includes/templates/Menu.mustache with label tag. Replaced h3 elements in .storybook/icons.less, resources/common/components/Menu.less, resources/common/components/MenuDropdown.less, resources/common/components/MenuPortal.less, resources/common/components/MenuTabs.less,resources/skins.vector.styles.legacy/components/MenuDropdown.less, resources/skins.vector.styles/components/UserLinks.less, resources/skins.vector.styles.legacy/components/Sidebar.less and resources/skins.vector.styles.legacy/layouts/screen.less by vector-menu-heading. Bug: T290280 Change-Id: I6eee7d6bc47c74a62166d4579fd4d3da3dc88e88 2022-02-21 15:42:10 +00:00			`.vector-menu-heading {`
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d 2014-08-07 11:38:34 +00:00			`display: none;`
			`}`

			`ul {`
styles: Replace IE hack `list-style: none none` Hack has first been introduced in I7d4b075ac90 more than 4 years ago. It has been introduced to tackle IE <=8. Bug: T306486 Bug: T308344 Change-Id: Ie84a177f79d226be98298a42ebfdd447e33a1372 2022-07-20 15:31:56 +00:00			`list-style: none;`
Move Vector skin from core This is the final step of the process described at <https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki>. Corresponding core change: Idfc38503. Change-Id: I84fcf7ce6385b8323544cafe6912a00f1886d20d 2014-08-07 11:38:34 +00:00			`margin: 0;`
			`}`
Fix padding/positioning of the user menu orange talk message notification The padding-top of the orange notification set in ext.echo.styles.alert.less was being overriden by the `padding-top: 0` set in UserLinks.less which was intended to only override the padding set in Menu.less. This commit: * Scopes the li styles in Menu.less to apply only to the legacy user menu (found in both legacy and modern vector with the consolidated user links feature off) which appears to be the only menus that needs these rules. * The padding-top previously in UserLinks is no longer needed as a result of the above point. * Adjusts/cleans up the positioning of the orange notification by removing an unneeded margin/padding-top and setting the top to 100% (the previous `calc` statement was unintentionally resulting in 112%). Bug: T287633 Change-Id: Ia7069d291f53d8e0e0e576d7b96b7a8b1a6cb29d 2021-07-28 19:42:30 +00:00			`}`