wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-14 19:26:42 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/includes/templates/Header.mustache

23 lines
605 B
Plaintext
Raw Normal View History

Switch to navigation-first DOM order under `$wgVectorIsSearchInHeader` feature flag This moves the header, navigation, sidebar, and article toolbar to be before the content in the DOM. As a result, a lot of absolute positioning logic can be removed and styles can be simplified. Note that although the sidebar was moved from the header into the workspace container allowing it to de-absolutely positioned, its absolute positioning was kept intact as it has a fair amount of complexity that should be handled in a separate task. To activate, set `$wgVectorIsSearchInHeader = true;` Changes that could cause concern: * The "jump to search" link was removed as the search is now much earlier in the DOM and I questioned the value of keeping this. However, it can be added back in if this change is contentious. * A "jump to content" link was added to account for the new DOM order. * Because the sidebar was taken out of the header, users will not be able to tab from the sidebar button into the sidebar without additional tweaking (e.g. should we add JS to enable this?). It was deemed that this work can be saved as a follow-up task. * I applied `overflow-y: auto` to the `mw-page-container` because the header's top margin was collapsing and caused whitespace to appear between the viewport and the header. Alternatively, we could apply a top padding to the page container and remove the header's top margin. I went for the simplest solution but am open to alternatives. * I left the footer as-is in this patch to minimize risk. It might be cleaner later on to move the footer inside the workspace container which would leave only one workspace container. Bug: T261802 Change-Id: Ic553fab3bde25769b103d899b92b3b694c00c384
2020-09-08 23:20:58 +00:00
<header class="mw-header">
<label
id="mw-sidebar-button"
class="mw-checkbox-hack-button mw-ui-icon mw-ui-icon-element"
for="mw-sidebar-checkbox"
role="button"
aria-controls="mw-panel"
data-event-name="ui.sidebar"
tabindex="0">
{{msg-vector-action-toggle-sidebar}}
</label>
{{>Logo}}
{{#data-search-box}}{{>SearchBox}}{{/data-search-box}}
Refactor: Create UserLinks component Have a single template for the UserLinks component, with a single element wrapping all its subcomponents as discussed. Change-Id: I35936a6fa1ba335639ca3f47fd439a3662268fca
2021-05-24 22:02:26 +00:00
{{#data-portlets}}
Refactor: Clarify functions that return booleans and template booleans We prefix templates that are booleans with "is-" and tend to prefix functions that return booleans with "if" or "should" This renames the new "shouldConsolidateLinks" method. Follow up to I1c305d89bece147a6f1b478441119c3169abfbdd Change-Id: I6a5908b8b35ca6bceec8b864e3ac651fc7e8ced8
2021-05-06 22:54:55 +00:00
{{^is-consolidated-user-links}}
Refactor: Create UserLinks component Have a single template for the UserLinks component, with a single element wrapping all its subcomponents as discussed. Change-Id: I35936a6fa1ba335639ca3f47fd439a3662268fca
2021-05-24 22:02:26 +00:00
{{#data-personal}}{{>Menu}}{{/data-personal}}
Refactor: Clarify functions that return booleans and template booleans We prefix templates that are booleans with "is-" and tend to prefix functions that return booleans with "if" or "should" This renames the new "shouldConsolidateLinks" method. Follow up to I1c305d89bece147a6f1b478441119c3169abfbdd Change-Id: I6a5908b8b35ca6bceec8b864e3ac651fc7e8ced8
2021-05-06 22:54:55 +00:00
{{/is-consolidated-user-links}}
{{#is-consolidated-user-links}}
Refactor: Create UserLinks component Have a single template for the UserLinks component, with a single element wrapping all its subcomponents as discussed. Change-Id: I35936a6fa1ba335639ca3f47fd439a3662268fca
2021-05-24 22:02:26 +00:00
{{>UserLinks}}
Refactor: Clarify functions that return booleans and template booleans We prefix templates that are booleans with "is-" and tend to prefix functions that return booleans with "if" or "should" This renames the new "shouldConsolidateLinks" method. Follow up to I1c305d89bece147a6f1b478441119c3169abfbdd Change-Id: I6a5908b8b35ca6bceec8b864e3ac651fc7e8ced8
2021-05-06 22:54:55 +00:00
{{/is-consolidated-user-links}}
Refactor: Create UserLinks component Have a single template for the UserLinks component, with a single element wrapping all its subcomponents as discussed. Change-Id: I35936a6fa1ba335639ca3f47fd439a3662268fca
2021-05-24 22:02:26 +00:00
{{/data-portlets}}
Switch to navigation-first DOM order under `$wgVectorIsSearchInHeader` feature flag This moves the header, navigation, sidebar, and article toolbar to be before the content in the DOM. As a result, a lot of absolute positioning logic can be removed and styles can be simplified. Note that although the sidebar was moved from the header into the workspace container allowing it to de-absolutely positioned, its absolute positioning was kept intact as it has a fair amount of complexity that should be handled in a separate task. To activate, set `$wgVectorIsSearchInHeader = true;` Changes that could cause concern: * The "jump to search" link was removed as the search is now much earlier in the DOM and I questioned the value of keeping this. However, it can be added back in if this change is contentious. * A "jump to content" link was added to account for the new DOM order. * Because the sidebar was taken out of the header, users will not be able to tab from the sidebar button into the sidebar without additional tweaking (e.g. should we add JS to enable this?). It was deemed that this work can be saved as a follow-up task. * I applied `overflow-y: auto` to the `mw-page-container` because the header's top margin was collapsing and caused whitespace to appear between the viewport and the header. Alternatively, we could apply a top padding to the page container and remove the header's top margin. I went for the simplest solution but am open to alternatives. * I left the footer as-is in this patch to minimize risk. It might be cleaner later on to move the footer inside the workspace container which would leave only one workspace container. Bug: T261802 Change-Id: Ic553fab3bde25769b103d899b92b3b694c00c384
2020-09-08 23:20:58 +00:00
</header>
Reference in a new issue Copy permalink