wikimedia/mediawiki-skins-Vector
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/Vector.git synced 2024-11-24 15:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-Vector/skin.json

174 lines
6.2 KiB
JSON
Raw Normal View History

Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
{
"name": "Vector",
"author": [
"Trevor Parscal",
"Roan Kattouw",
"..."
],
"url": "https://www.mediawiki.org/wiki/Skin:Vector",
"descriptionmsg": "vector-skin-desc",
Revert "Update namemsg to convention" My bad... skinname-<skinname> is used in core to get the skin name. This reverts commit ac0d123ba8a2d38be4ca48a52ca993e65f4fab27. Change-Id: I3c7780f9f08081238744fde094804ea8f5dd191a
2015-09-28 09:42:39 +00:00
"namemsg": "skinname-vector",
Use SPDX 3.0 license identifier SPDX released version 3 of their license list (<https://spdx.org/licenses/>), which changed the FSF licenses to explicitly end in -only or -or-later instead of relying on an easy to miss + symbol. Bug: T183858 Change-Id: Ie8a20191fd9505eb5f0a6a3a010a602d2a44a58e
2018-02-16 18:41:02 +00:00
"license-name": "GPL-2.0-or-later",
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
"type": "skin",
Add MediaWiki version requirement to skin.json Change-Id: I081e837641119bff4a16e442302f0e4503c5d04a
2015-09-23 15:31:56 +00:00
"requires": {
Bump Vector to depend on MediaWiki 1.35.0 To minimise reports from users with mismatched skins an MediaWiki and given the pending changes anticipated by the updates to Vector, we will bump Vector's version. This repo is not meant to have supported 1.31 in master for years (since the REL1_31 branch point, which for this repo is f0327dc55 from 2018-04-17 yet very few backports have been made to this repos REL1_31 branch. This will massively reduce work for Wikimedia development teams; we don't need to try to maintain backwards compatibility. Change-Id: Ie4635fa0a7cbc2d115b2093bc5bc1a72a160afaf
2020-04-15 17:26:19 +00:00
"MediaWiki": ">= 1.35.0"
Add MediaWiki version requirement to skin.json Change-Id: I081e837641119bff4a16e442302f0e4503c5d04a
2015-09-23 15:31:56 +00:00
},
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
"ValidSkinNames": {
"vector": "Vector"
},
"MessagesDirs": {
"Vector": [
"i18n"
]
},
"AutoloadClasses": {
Move class files to includes/ Cleans up the top-level directory a bit. Change-Id: I29d3b8b7098def77e643232a386d8ba834d35704
2018-03-12 23:52:48 +00:00
"SkinVector": "includes/SkinVector.php",
Drop usage of mediawiki.skinning.interface module in favor of SkinModule Thanks to the dependent change, the print logo is now provided in core so we can remove the custom Vector ResourceLoader module ResourceLoaderLessModule is replaced with a ResourceLoaderSkinModule and gains the features capability replacing the need for 'mediawiki.skinning.interface' making use of the changes added in 6845912bcf1. Note that for cached HTML both 'mediawiki.skinning.interface' and skins.vector.styles will be loaded. We can avoid this by renaming skins.vector.styles if necessary (but I'm not sure if we'd want to do that) Bug: T232140 Depends-On: I00899c16c0325f36b671baf17e88c2b5187b3526 Change-Id: I569e0d800e147eabc7852567acd140108613f074
2019-11-12 19:09:26 +00:00
"VectorTemplate": "includes/VectorTemplate.php"
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
},
features: Add minimalist feature manager With complex additions to Vector's codebase like the Desktop Improvement Program upcoming, it's important that we have a shared, intuitive language to talk about features and their requirements. Centralising the registration of features and creating an API satisfies does exactly this. This change introduces a greatly-reduced version of Piotr Miazga's (polishdeveloper, pmiazga) original proposed API and associated scaffolding classes for feature management in Vector, which itself was based upon his work in MobileFrontend/MinervaNeue. This is done to establish a foundation upon which we can build the more sophisticated parts of Piotr's proposal in a piecemeal basis, thereby minimising risk. Distinct from Piotr's proposed API is the ability to register sets and features that are always enabled or disabled. Additionally: - A Vector.FeatureManager service is registered but not used - A list of proposed immediate next steps is included Bug: T244481 Change-Id: Ie53c41d479eaf15559d5bb00f269774760360bde
2020-02-20 16:37:33 +00:00
"AutoloadNamespaces": {
Move some more classes to AutoloadNamespaces Bug: T187154 Change-Id: I7e9407c1b0e03ccb699e4a11b6b44529d70fee3d
2020-04-18 02:59:38 +00:00
"Vector\\": "includes/"
features: Add minimalist feature manager With complex additions to Vector's codebase like the Desktop Improvement Program upcoming, it's important that we have a shared, intuitive language to talk about features and their requirements. Centralising the registration of features and creating an API satisfies does exactly this. This change introduces a greatly-reduced version of Piotr Miazga's (polishdeveloper, pmiazga) original proposed API and associated scaffolding classes for feature management in Vector, which itself was based upon his work in MobileFrontend/MinervaNeue. This is done to establish a foundation upon which we can build the more sophisticated parts of Piotr's proposal in a piecemeal basis, thereby minimising risk. Distinct from Piotr's proposed API is the ability to register sets and features that are always enabled or disabled. Additionally: - A Vector.FeatureManager service is registered but not used - A list of proposed immediate next steps is included Bug: T244481 Change-Id: Ie53c41d479eaf15559d5bb00f269774760360bde
2020-02-20 16:37:33 +00:00
},
[Special:Preferences] [PHP] Add skin version user preference and configs Add a Vector-specific user preference to Special:Preferences for toggling skin version, either Legacy Vector or the latest Vector. The presentation of the new preference section and the default values for anonymous, new, and existing accounts are configurable via $wgVectorShowSkinPreferences, $wgVectorDefaultSkinVersion (to be used by the feature manager in T244481), $wgVectorDefaultSkinVersionForExistingAccounts, and $wgVectorDefaultSkinVersionForNewAccounts. These configurations default to the fullest experience so that third-party configuration is minimal. See skin.json for details. The configurations are each tested in VectorHooksTest.php. When presentation is enabled, the new preference appears as a checkbox; enabled is Legacy mode and disable is latest. There are a number of unfortunate details: - Showing and hiding a checkbox is supported by OOUI. Showing and hiding a whole section (Vector skin preferences, in this case) is not so this additional client JavaScript functionality is added in Core (see Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377). - Stylization as a checkbox is wanted. However, the implied storage type for OOUI checkboxes is a boolean. This is not wanted in the event that another skin version is added (e.g., '3' or 'alpha'). As a workaround, the preference is converted from a boolean to a version string ('1' or '2') on save in Hooks::onPreferencesFormPreSave() and from a version string to a checkbox enable / disable string ('1' or '0') in onGetPreferences(). There a number of test cases to help cover these concerning details. Documentation for overriding the skin version as a URL query parameter is provided in anticipation of T244481. Bug: T242381 Bug: T245793 Depends-On: Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 Depends-On: Ifc2863fca9cd9efd11ac30c780420e8d89e8cb22 Change-Id: I177dad88fc982170641059b6a4f53fbb38eefad6
2020-01-23 21:53:09 +00:00
"ConfigRegistry": {
"vector": "GlobalVarConfig::newInstance"
},
Vector should operate in responsive mode when the mobile skin With MobileFrontend installed applying ?useskin=vector&useformat=mobile will ensure that responsive vector mode is invoked. I'm keen to do this, as it would help to have more examples of skins that are MobileFrontend aware as part of the work I am doing in T166748 Change-Id: I81edd855a5e96400d1179fb10907fcc30ea43ef7
2017-06-30 19:21:16 +00:00
"Hooks": {
Drop wgVectorResponsive support from modern Vector Move the body of enableResponsiveMode method into the onBeforePageDisplayMobile hook. Replace BeforePageDisplayMobile hook with BeforePageDisplay hook. Bug: T254378 Change-Id: I63da1b67bf2b85c644e4af196bf894efc4797433
2020-06-12 12:31:08 +00:00
"BeforePageDisplay": "Vector\\Hooks::onBeforePageDisplay",
[Special:Preferences] [PHP] Add skin version user preference and configs Add a Vector-specific user preference to Special:Preferences for toggling skin version, either Legacy Vector or the latest Vector. The presentation of the new preference section and the default values for anonymous, new, and existing accounts are configurable via $wgVectorShowSkinPreferences, $wgVectorDefaultSkinVersion (to be used by the feature manager in T244481), $wgVectorDefaultSkinVersionForExistingAccounts, and $wgVectorDefaultSkinVersionForNewAccounts. These configurations default to the fullest experience so that third-party configuration is minimal. See skin.json for details. The configurations are each tested in VectorHooksTest.php. When presentation is enabled, the new preference appears as a checkbox; enabled is Legacy mode and disable is latest. There are a number of unfortunate details: - Showing and hiding a checkbox is supported by OOUI. Showing and hiding a whole section (Vector skin preferences, in this case) is not so this additional client JavaScript functionality is added in Core (see Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377). - Stylization as a checkbox is wanted. However, the implied storage type for OOUI checkboxes is a boolean. This is not wanted in the event that another skin version is added (e.g., '3' or 'alpha'). As a workaround, the preference is converted from a boolean to a version string ('1' or '2') on save in Hooks::onPreferencesFormPreSave() and from a version string to a checkbox enable / disable string ('1' or '0') in onGetPreferences(). There a number of test cases to help cover these concerning details. Documentation for overriding the skin version as a URL query parameter is provided in anticipation of T244481. Bug: T242381 Bug: T245793 Depends-On: Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 Depends-On: Ifc2863fca9cd9efd11ac30c780420e8d89e8cb22 Change-Id: I177dad88fc982170641059b6a4f53fbb38eefad6
2020-01-23 21:53:09 +00:00
"GetPreferences": "Vector\\Hooks::onGetPreferences",
"PreferencesFormPreSave": "Vector\\Hooks::onPreferencesFormPreSave",
BaseTemplate:makeListItem is deprecated Use SkinTemplateNavigation hook instead and copy the collapsible behavior to the menu function The code inside getSkinData that checks VectorUseIconWatch is redundant as it duplicates checks already inside SkinTemplate::buildContentNavigationUrls It is enough to simplify check whether watch or unwatch is present in the array. Bug: T251212 Change-Id: If6b10b0ddcbd4b21dd13a2813e60b604c3a23415
2020-05-11 22:09:21 +00:00
"SkinTemplateNavigation": "Vector\\Hooks::onSkinTemplateNavigation",
Vector: Use OutputPageBodyAttributes hook to add body attributes This means dropping usage of Skin::addToBodyAttributes method from Skin to pave way for its deprecation/removal. The parent method is no-op, so this will not create duplicate with the hook Bug: T255698 Change-Id: Ieeccdd9ec3fdb3e3fc1a3016cfa87e0b8364aa3a
2020-06-18 12:52:00 +00:00
"LocalUserCreated": "Vector\\Hooks::onLocalUserCreated",
"OutputPageBodyAttributes": "Vector\\Hooks::onOutputPageBodyAttributes"
Vector should operate in responsive mode when the mobile skin With MobileFrontend installed applying ?useskin=vector&useformat=mobile will ensure that responsive vector mode is invoked. I'm keen to do this, as it would help to have more examples of skins that are MobileFrontend aware as part of the work I am doing in T166748 Change-Id: I81edd855a5e96400d1179fb10907fcc30ea43ef7
2017-06-30 19:21:16 +00:00
},
Unbreak styles for installer The installer hardcodes and expects to find a "skin.vector.styles" module in skin.json, so moving it into a hook broke the styles. Moved it back into skin.json, and left a comment so future developers don't make the same mistake. The responsive code is now a separate module, "skins.vector.styles.responsive", which is only added to the page output if VectorResponsive is enabled. Bug: T106747 Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-24 00:05:26 +00:00
"@note": "When modifying skins.vector.styles definition, make sure the installer still works",
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
"ResourceModules": {
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
"skins.vector.styles.legacy": {
"class": "ResourceLoaderSkinModule",
[modern] Fix rendering of `main` element in IE10 & 11 Adding ResourceLoader 'normalize' feature module to the modern styles. Legacy Vector was not upgraded to use HTML5 semantic elements, therefore does not need the module. Similar to Demian's approach with reverted 'html5' I8f1c79037d14b89982e449708f4f1cefacab4439 Bug: T256092 Change-Id: I420e5315aee74f59995c358083f969b059bfe3c0 Depends-On: I4601cc938f7a10dce4f643e22356f8c5a39e4ac9
2020-06-30 00:21:10 +00:00
"features": [ "normalize", "elements", "content", "interface", "logo", "legacy" ],
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
"targets": [
"desktop",
"mobile"
],
Naming convention using 'skin' as entrance point Using 'skin' as entrance point files, similar to already existing convention in MediaWiki land with 'skin.json' or 'SkinVector.php' as example in Vector skin. Replacing Apache inspired 'index' convention. Also renaming legacy to 'skin-legacy' to be clear on file base that it's a modification of 'skin'. Bug: T249073 Change-Id: Ief1c469724d4ffe238d307407c3ddb46f2e1abfa
2020-05-14 20:54:15 +00:00
"styles": [ "resources/skins.vector.styles/skin-legacy.less" ]
Ship different ResourceLoader module for different versions To have a clean break for upcoming changes we will duplicate index.less into legacy.less and create a new module to clearly separate new styles from old. The preferred name however does come with some caching challenges. Cached HTML served to anons will continue to load the style module `skins.vector.styles` for a period of 1-4 weeks Provided we are careful with our changes during this period this should be okay. Change-Id: If32b59036e5cd62cbb804944ca93fa1a101c5129
2020-03-11 22:35:38 +00:00
},
Unbreak styles for installer The installer hardcodes and expects to find a "skin.vector.styles" module in skin.json, so moving it into a hook broke the styles. Moved it back into skin.json, and left a comment so future developers don't make the same mistake. The responsive code is now a separate module, "skins.vector.styles.responsive", which is only added to the page output if VectorResponsive is enabled. Bug: T106747 Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-24 00:05:26 +00:00
"skins.vector.styles": {
Drop usage of mediawiki.skinning.interface module in favor of SkinModule Thanks to the dependent change, the print logo is now provided in core so we can remove the custom Vector ResourceLoader module ResourceLoaderLessModule is replaced with a ResourceLoaderSkinModule and gains the features capability replacing the need for 'mediawiki.skinning.interface' making use of the changes added in 6845912bcf1. Note that for cached HTML both 'mediawiki.skinning.interface' and skins.vector.styles will be loaded. We can avoid this by renaming skins.vector.styles if necessary (but I'm not sure if we'd want to do that) Bug: T232140 Depends-On: I00899c16c0325f36b671baf17e88c2b5187b3526 Change-Id: I569e0d800e147eabc7852567acd140108613f074
2019-11-12 19:09:26 +00:00
"class": "ResourceLoaderSkinModule",
[modern] Fix rendering of `main` element in IE10 & 11 (again) Add 'normalize' module to modern Vector. In I420e5315aee74f59995c358083f969b059bfe3c0 the commit message did not reflect the actual change and we added normalize to legacy accidentally instead of modern. This patch adds it to modern correctly. In that commit message we said "Legacy Vector was not upgraded to use HTML5 semantic elements, therefore does not need the module." however on further reflection there is benefit to keeping this in legacy as after further changes made in I4601cc938f7a1 this will bring the same consistency in all Wikimedia deployed skins. Following-up I420e5315aee74f59995c358083f969b059bfe3c0 Bug: T256092 Change-Id: I3ba46cb993524e8fa0ad262ab4b6cba829498e87
2020-07-07 03:07:33 +00:00
"features": [ "normalize", "elements", "content", "interface", "legacy" ],
Upgrade skin.json schema to manifest_version 2 Bug: T242469 Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-11 04:40:49 +00:00
"targets": [
"desktop",
"mobile"
],
Naming convention using 'skin' as entrance point Using 'skin' as entrance point files, similar to already existing convention in MediaWiki land with 'skin.json' or 'SkinVector.php' as example in Vector skin. Replacing Apache inspired 'index' convention. Also renaming legacy to 'skin-legacy' to be clear on file base that it's a modification of 'skin'. Bug: T249073 Change-Id: Ief1c469724d4ffe238d307407c3ddb46f2e1abfa
2020-05-14 20:54:15 +00:00
"styles": [ "resources/skins.vector.styles/skin.less" ]
Unbreak styles for installer The installer hardcodes and expects to find a "skin.vector.styles" module in skin.json, so moving it into a hook broke the styles. Moved it back into skin.json, and left a comment so future developers don't make the same mistake. The responsive code is now a separate module, "skins.vector.styles.responsive", which is only added to the page output if VectorResponsive is enabled. Bug: T106747 Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-24 00:05:26 +00:00
},
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
"skins.vector.icons": {
"class": "ResourceLoaderImageModule",
[fix][RTL] flip menu collapse button icon Fix the icon button directionality in right-to-left languages. Previously, the button was hardcoded to support left-to-right only. - Replace the skin.vector.icons' `.mw-ui-icon-wikimedia-{name}:before` `selector` in skin.json with a placeholder, `{name}`. I don't think this selector should be needed but it seems to be erroneous not have one. I believe this issue of wanting a null selector was encountered in Minerva or MobileFrontend but am unable to locate the past discourse. - Add check and unchecked menu button selectors to skin.json that set the appropriate background image. This shards some of the styles out of Less and into ResourceLoader-land but it's worthwhile. - Revise the name of horizontal collapse icon to describe its form not function, "collapseHorizontal" to "chevronHorizontal". This has been an established convention that was missed a couple patches back. - Add a flipped chevronHorizontal for RTL. I used Inkscape to do the flip and tried to match the style of the original by hand. Feel free to edit further. - Drop the now unnecessary icon flipping JavaScript and initial Mustache class. This enables a real CSS-only solution for the icons. Bug: T246419 Change-Id: I60f65b3c595bf18d309b667d9a0b066691b90c97
2020-06-02 03:09:42 +00:00
"selector": "{name}",
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
"images": {
[modern] Move sidebar checkbox above content, sidebar button into header - Sidebar's checkbox hack CSS selectors adjusted. Bug: T246420 Change-Id: I1cc1ad4eb1938c4931b1ae881b3878fbd6bb7a39
2020-06-23 02:43:28 +00:00
"#mw-sidebar-button:before": {
[fix][RTL] flip menu collapse button icon Fix the icon button directionality in right-to-left languages. Previously, the button was hardcoded to support left-to-right only. - Replace the skin.vector.icons' `.mw-ui-icon-wikimedia-{name}:before` `selector` in skin.json with a placeholder, `{name}`. I don't think this selector should be needed but it seems to be erroneous not have one. I believe this issue of wanting a null selector was encountered in Minerva or MobileFrontend but am unable to locate the past discourse. - Add check and unchecked menu button selectors to skin.json that set the appropriate background image. This shards some of the styles out of Less and into ResourceLoader-land but it's worthwhile. - Revise the name of horizontal collapse icon to describe its form not function, "collapseHorizontal" to "chevronHorizontal". This has been an established convention that was missed a couple patches back. - Add a flipped chevronHorizontal for RTL. I used Inkscape to do the flip and tried to match the style of the original by hand. Feel free to edit further. - Drop the now unnecessary icon flipping JavaScript and initial Mustache class. This enables a real CSS-only solution for the icons. Bug: T246419 Change-Id: I60f65b3c595bf18d309b667d9a0b066691b90c97
2020-06-02 03:09:42 +00:00
"file": {
"ltr": "resources/skins.vector.icons/chevronHorizontal-ltr.svg",
"rtl": "resources/skins.vector.icons/chevronHorizontal-rtl.svg"
}
},
[modern] Move sidebar checkbox above content, sidebar button into header - Sidebar's checkbox hack CSS selectors adjusted. Bug: T246420 Change-Id: I1cc1ad4eb1938c4931b1ae881b3878fbd6bb7a39
2020-06-23 02:43:28 +00:00
"#mw-sidebar-checkbox:not( :checked ) ~ .mw-header #mw-sidebar-button:before": "resources/skins.vector.icons/menu.svg"
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
}
},
Unbreak styles for installer The installer hardcodes and expects to find a "skin.vector.styles" module in skin.json, so moving it into a hook broke the styles. Moved it back into skin.json, and left a comment so future developers don't make the same mistake. The responsive code is now a separate module, "skins.vector.styles.responsive", which is only added to the page output if VectorResponsive is enabled. Bug: T106747 Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-24 00:05:26 +00:00
"skins.vector.styles.responsive": {
Upgrade skin.json schema to manifest_version 2 Bug: T242469 Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-11 04:40:49 +00:00
"targets": [
"desktop",
"mobile"
],
[dev] Consolidate ResourceLoader LESS style files Move styles.less to index.less and import print.less from it. This keeps the reasoning about styles constrained to LESS instead of spread out over LESS _and_ ResourceLoader. The former is preferable since LESS is more standardized than ResourceLoader. The approach of moving styles.less to index.less and then referencing print.less was chosen with the intent that it'd be easier to assume styles are screen styles unless a media query says otherwise. This patch also makes the variables import common among print and screen styles. Bug: T246419 Change-Id: I981d0937aaacb7cba082c337f98c90e90b46b340
2020-03-10 21:01:09 +00:00
"styles": [ "resources/skins.vector.styles.responsive.less" ]
Unbreak styles for installer The installer hardcodes and expects to find a "skin.vector.styles" module in skin.json, so moving it into a hook broke the styles. Moved it back into skin.json, and left a comment so future developers don't make the same mistake. The responsive code is now a separate module, "skins.vector.styles.responsive", which is only added to the page output if VectorResponsive is enabled. Bug: T106747 Change-Id: I7540b7871531ef650e799f012477cef6cdd32fb7
2015-07-24 00:05:26 +00:00
},
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
"skins.vector.js": {
[dev] [JS] Move JavaScript to package modules Move all Vector JavaScript to ResourceLoader `packageFiles`[0] which are much more compatible with modern development practices: - The entrypoint is the first `packageFiles` entry (unless specified otherwise). All other JavaScript must be explicitly executed. - Remove a level of indentation due to IIFEs from every JavaScript file. Regretfully, ESLint does not support modules except in ES6+ so the otherwise useful `no-implicit-globals` rule must be disable. The change comes with a comment so we always remember. - IDEs and other tooling understand Node.js-like `module.exports` / `require()`. This change seemed the most sensible way to start developing new JavaScript in Vector needed by the collapsible sidebar. [0]: https://www.mediawiki.org/wiki/ResourceLoader/Package_modules Change-Id: I287e604d5b1055aa97b5f987c24872755757ea1a
2020-04-10 15:24:13 +00:00
"packageFiles": [
Naming convention using 'skin' as entrance point Using 'skin' as entrance point files, similar to already existing convention in MediaWiki land with 'skin.json' or 'SkinVector.php' as example in Vector skin. Replacing Apache inspired 'index' convention. Also renaming legacy to 'skin-legacy' to be clear on file base that it's a modification of 'skin'. Bug: T249073 Change-Id: Ief1c469724d4ffe238d307407c3ddb46f2e1abfa
2020-05-14 20:54:15 +00:00
"resources/skins.vector.js/skin.js",
Sidebar persistence for logged-in users in modern Vector. - Creates a new user-preference called 'VectorSidebarVisible' which stores the sidebar hidden/collapsed state for logged-in users. - Updates that user-preference on the client whenever the sidebar is expanded or collapsed. - Refactors the sidebar related javascript into a separate file. Bug: T255727 Change-Id: Ib1ce934f3646cd8feebf0d3b15c38b5b969ec957
2020-06-30 22:39:09 +00:00
"resources/skins.vector.js/sidebar.js",
[dev][Legacy][JS] Split Legacy mode JavaScript into new ResourceLoader module The collapsible sidebar adds a new JavaScript dependency and behavior to Latest mode only. There are a number of ways of to make the deviation but we think now is the time to start splitting by module. This patch adds a new ResourceLoader module, skins.vector.legacy.js, and moves the existing JavaScript into it. The old module, skins.vector.js, has been given a currently matching index.js entry point that references the collapsible tabs' files by reaching across directories. It's not quite ideal as usually ResourceLoader modules and directory structures strive for 1:1 correspondence but this patch makes the bold assertions that it's better than a file copy, better than a new "skins.vector.common.js" ResourceLoader module, more compatible than a symlink, and the existing jQuery tabs implementation will eventually be replaced in Latest mode. A "Legacy" module was added instead of a "Latest" with the assumption that active development should generally be considered "latest" and Legacy an intentional distinction. Bug: T246419 Change-Id: I9980403f1ee5897c27ac0331f0b51a5bcbdff778
2020-05-11 21:29:56 +00:00
"resources/skins.vector.legacy.js/collapsibleTabs.js",
"resources/skins.vector.legacy.js/vector.js"
],
"dependencies": [
[feature] add menu button to toggle panel visibility Add a menu button that toggles the panel's (also referred to as a sidebar) collapse state. When the screen is wide enough, animate the transition. The menu icon from OOUI is copied into Vector to avoid two ResourceLoaders modules (collapseHorizontal icon isn't ready for inclusion in the OOUI icon pack and ResourceLoaderOOUIIconPackModule doesn't support images). Additional polish and collaboration is needed but this patch fulfills the scope of its referenced task. Bug: T246419 Depends-On: I8e153c0ab927f9d880a68fb9efb0bf37b91d26b2 Change-Id: Ic9d54de7e19ef8d5dfd703d95a45b78c0aaf791a
2020-03-30 20:07:35 +00:00
"mediawiki.util",
"mediawiki.page.ready"
[dev][Legacy][JS] Split Legacy mode JavaScript into new ResourceLoader module The collapsible sidebar adds a new JavaScript dependency and behavior to Latest mode only. There are a number of ways of to make the deviation but we think now is the time to start splitting by module. This patch adds a new ResourceLoader module, skins.vector.legacy.js, and moves the existing JavaScript into it. The old module, skins.vector.js, has been given a currently matching index.js entry point that references the collapsible tabs' files by reaching across directories. It's not quite ideal as usually ResourceLoader modules and directory structures strive for 1:1 correspondence but this patch makes the bold assertions that it's better than a file copy, better than a new "skins.vector.common.js" ResourceLoader module, more compatible than a symlink, and the existing jQuery tabs implementation will eventually be replaced in Latest mode. A "Legacy" module was added instead of a "Latest" with the assumption that active development should generally be considered "latest" and Legacy an intentional distinction. Bug: T246419 Change-Id: I9980403f1ee5897c27ac0331f0b51a5bcbdff778
2020-05-11 21:29:56 +00:00
]
},
"skins.vector.legacy.js": {
"packageFiles": [
Naming convention using 'skin' as entrance point Using 'skin' as entrance point files, similar to already existing convention in MediaWiki land with 'skin.json' or 'SkinVector.php' as example in Vector skin. Replacing Apache inspired 'index' convention. Also renaming legacy to 'skin-legacy' to be clear on file base that it's a modification of 'skin'. Bug: T249073 Change-Id: Ief1c469724d4ffe238d307407c3ddb46f2e1abfa
2020-05-14 20:54:15 +00:00
"resources/skins.vector.legacy.js/skin-legacy.js",
[dev][Legacy][JS] Split Legacy mode JavaScript into new ResourceLoader module The collapsible sidebar adds a new JavaScript dependency and behavior to Latest mode only. There are a number of ways of to make the deviation but we think now is the time to start splitting by module. This patch adds a new ResourceLoader module, skins.vector.legacy.js, and moves the existing JavaScript into it. The old module, skins.vector.js, has been given a currently matching index.js entry point that references the collapsible tabs' files by reaching across directories. It's not quite ideal as usually ResourceLoader modules and directory structures strive for 1:1 correspondence but this patch makes the bold assertions that it's better than a file copy, better than a new "skins.vector.common.js" ResourceLoader module, more compatible than a symlink, and the existing jQuery tabs implementation will eventually be replaced in Latest mode. A "Legacy" module was added instead of a "Latest" with the assumption that active development should generally be considered "latest" and Legacy an intentional distinction. Bug: T246419 Change-Id: I9980403f1ee5897c27ac0331f0b51a5bcbdff778
2020-05-11 21:29:56 +00:00
"resources/skins.vector.legacy.js/collapsibleTabs.js",
"resources/skins.vector.legacy.js/vector.js"
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
],
"dependencies": [
Remove unused 'jquery.tabIndex' dependency Follows-up bfc5a57. Bug: T226148 Bug: T233676 Change-Id: Icb4a2458c40482a45172ce09f6ec14c4f7d1ccdf
2019-10-04 00:06:46 +00:00
"mediawiki.util"
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
]
}
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteSkinPath": "Vector"
},
"ResourceModuleSkinStyles": {
"vector": {
"jquery.tipsy": "skinStyles/jquery.tipsy.less",
Update ResourceModuleSkinStyles for jquery.ui change Follows-up I9070ad905 in MediaWiki core. Depends-On: I9070ad9052319f5ca2bc67e0ffaf502db0f13ceb Bug: T219604 Change-Id: Ib13bf24f4d8fa8da932b57439e2b52ec10545f3c
2019-10-16 22:44:40 +00:00
"jquery.ui": [
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
"skinStyles/jquery.ui/jquery.ui.core.css",
Update ResourceModuleSkinStyles for jquery.ui change Follows-up I9070ad905 in MediaWiki core. Depends-On: I9070ad9052319f5ca2bc67e0ffaf502db0f13ceb Bug: T219604 Change-Id: Ib13bf24f4d8fa8da932b57439e2b52ec10545f3c
2019-10-16 22:44:40 +00:00
"skinStyles/jquery.ui/jquery.ui.theme.css",
"skinStyles/jquery.ui/jquery.ui.accordion.css",
"skinStyles/jquery.ui/jquery.ui.autocomplete.css",
"skinStyles/jquery.ui/jquery.ui.button.css",
"skinStyles/jquery.ui/jquery.ui.datepicker.css",
"skinStyles/jquery.ui/jquery.ui.dialog.css",
"skinStyles/jquery.ui/jquery.ui.menu.css",
"skinStyles/jquery.ui/jquery.ui.progressbar.css",
"skinStyles/jquery.ui/jquery.ui.resizable.css",
"skinStyles/jquery.ui/jquery.ui.selectable.css",
"skinStyles/jquery.ui/jquery.ui.slider.css",
"skinStyles/jquery.ui/jquery.ui.tabs.css",
"skinStyles/jquery.ui/jquery.ui.tooltip.css"
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
],
Optimization: move styles specific to redirect pages out of common.less HT MatmaRex Change-Id: I6169692547378379dbc935976ad83cf4f366eeeb
2017-06-15 13:05:39 +00:00
"+mediawiki.action.view.redirectPage": "skinStyles/mediawiki.action.view.redirectPage.less",
Skin styles for mediawiki.notification should not be overriden Should be concatenated. See: Iba35692d38a8248096153146bc296b1079352f01 Change-Id: Ib4891ff0b3b123d49871b5887d05b885bcea6b4f
2015-05-04 16:29:18 +00:00
"+mediawiki.notification": "skinStyles/mediawiki.notification.less",
oojs-ui.styles is now oojs-ui-core.styles Bug: T127742 Change-Id: Ic32f721cd5fd5d7cf524c83fefd39c490a94f2d1
2016-02-29 16:59:59 +00:00
"+oojs-ui-core.styles": "skinStyles/ooui.less",
Style RelatedArticle cards If RelatedArtcles uses the SkinAfterContent hook (depends-on patch) and we move the hook out of the main content block (parent patch), it needs some styles to remain consistent. Bug: T181242 Change-Id: I2c5d4034890a5164896c1ef0570b31465a275890 Depeds-on: Iebd759c0d1a536768d18953f372664df762d9e04
2019-06-20 18:14:27 +00:00
"mediawiki.special": "skinStyles/mediawiki.special.less",
"+ext.relatedArticles.readMore": "skinStyles/ext.relatedArticles.readMore.less"
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
}
},
"config": {
Upgrade skin.json schema to manifest_version 2 Bug: T242469 Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-11 04:40:49 +00:00
"VectorUseIconWatch": {
"value": true
},
"VectorResponsive": {
"value": false
[Special:Preferences] [PHP] Add skin version user preference and configs Add a Vector-specific user preference to Special:Preferences for toggling skin version, either Legacy Vector or the latest Vector. The presentation of the new preference section and the default values for anonymous, new, and existing accounts are configurable via $wgVectorShowSkinPreferences, $wgVectorDefaultSkinVersion (to be used by the feature manager in T244481), $wgVectorDefaultSkinVersionForExistingAccounts, and $wgVectorDefaultSkinVersionForNewAccounts. These configurations default to the fullest experience so that third-party configuration is minimal. See skin.json for details. The configurations are each tested in VectorHooksTest.php. When presentation is enabled, the new preference appears as a checkbox; enabled is Legacy mode and disable is latest. There are a number of unfortunate details: - Showing and hiding a checkbox is supported by OOUI. Showing and hiding a whole section (Vector skin preferences, in this case) is not so this additional client JavaScript functionality is added in Core (see Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377). - Stylization as a checkbox is wanted. However, the implied storage type for OOUI checkboxes is a boolean. This is not wanted in the event that another skin version is added (e.g., '3' or 'alpha'). As a workaround, the preference is converted from a boolean to a version string ('1' or '2') on save in Hooks::onPreferencesFormPreSave() and from a version string to a checkbox enable / disable string ('1' or '0') in onGetPreferences(). There a number of test cases to help cover these concerning details. Documentation for overriding the skin version as a URL query parameter is provided in anticipation of T244481. Bug: T242381 Bug: T245793 Depends-On: Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 Depends-On: Ifc2863fca9cd9efd11ac30c780420e8d89e8cb22 Change-Id: I177dad88fc982170641059b6a4f53fbb38eefad6
2020-01-23 21:53:09 +00:00
},
"VectorShowSkinPreferences": {
"value": true,
"description": "@var boolean Show skin-specific user preferences on the Special:Preferences appearance tab when true and hide them otherwise."
},
"VectorDefaultSkinVersion": {
[config] Temporarily default to Legacy mode For all accounts, temporarily default to the Legacy skin version. This is to prevent regressions for third-parties until master has a complete logo and is in a shippable state. This change should be reverted as soon as interim changes in Latest mode are finished. Do these defaults need to be set elsewhere for development? Change-Id: I3c39352efe276b8574ab5d27fdab22901bc30b46
2020-05-04 13:25:38 +00:00
"value": "1",
[fix] "Existing account only" skin version config de76ab5 added the config, `$wgVectorDefaultSkinVersionForExistingAccounts`. Its usage in `Hooks::onUserGetDefaultOptions()` was invoked not only for existing accounts but anonymous users _as well._ This is a bug, due to my own misconceptions about the hook, that went against both the config's name and its documentation. Unfortunately, user sessions are unavailable in `Hooks::onUserGetDefaultOptions()` so it does not seem to be possible to determine whether the active user is an anonymous or existing account. This patch drops the hook and centralizes all version determination logic in SkinVersionLookup::getVersion(). SkinVersionLookup requires a the active User object and can make the anonymous / existing account determination by checking login state. The issued was identified while responding to review feedback given by @polishdeveloper / @pmiazga in I52d80942b4270c008d4e45050589ed9220255a50. Bug: T251415 Change-Id: I7982b4c34283ba81d0232ee6f501c44cf0a74b98
2020-04-28 21:02:15 +00:00
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to use for anonymous users and as a fallback. The value is _not_ persisted."
[Special:Preferences] [PHP] Add skin version user preference and configs Add a Vector-specific user preference to Special:Preferences for toggling skin version, either Legacy Vector or the latest Vector. The presentation of the new preference section and the default values for anonymous, new, and existing accounts are configurable via $wgVectorShowSkinPreferences, $wgVectorDefaultSkinVersion (to be used by the feature manager in T244481), $wgVectorDefaultSkinVersionForExistingAccounts, and $wgVectorDefaultSkinVersionForNewAccounts. These configurations default to the fullest experience so that third-party configuration is minimal. See skin.json for details. The configurations are each tested in VectorHooksTest.php. When presentation is enabled, the new preference appears as a checkbox; enabled is Legacy mode and disable is latest. There are a number of unfortunate details: - Showing and hiding a checkbox is supported by OOUI. Showing and hiding a whole section (Vector skin preferences, in this case) is not so this additional client JavaScript functionality is added in Core (see Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377). - Stylization as a checkbox is wanted. However, the implied storage type for OOUI checkboxes is a boolean. This is not wanted in the event that another skin version is added (e.g., '3' or 'alpha'). As a workaround, the preference is converted from a boolean to a version string ('1' or '2') on save in Hooks::onPreferencesFormPreSave() and from a version string to a checkbox enable / disable string ('1' or '0') in onGetPreferences(). There a number of test cases to help cover these concerning details. Documentation for overriding the skin version as a URL query parameter is provided in anticipation of T244481. Bug: T242381 Bug: T245793 Depends-On: Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 Depends-On: Ifc2863fca9cd9efd11ac30c780420e8d89e8cb22 Change-Id: I177dad88fc982170641059b6a4f53fbb38eefad6
2020-01-23 21:53:09 +00:00
},
"VectorDefaultSkinVersionForExistingAccounts": {
[config] Temporarily default to Legacy mode For all accounts, temporarily default to the Legacy skin version. This is to prevent regressions for third-parties until master has a complete logo and is in a shippable state. This change should be reverted as soon as interim changes in Latest mode are finished. Do these defaults need to be set elsewhere for development? Change-Id: I3c39352efe276b8574ab5d27fdab22901bc30b46
2020-05-04 13:25:38 +00:00
"value": "1",
[fix] "Existing account only" skin version config de76ab5 added the config, `$wgVectorDefaultSkinVersionForExistingAccounts`. Its usage in `Hooks::onUserGetDefaultOptions()` was invoked not only for existing accounts but anonymous users _as well._ This is a bug, due to my own misconceptions about the hook, that went against both the config's name and its documentation. Unfortunately, user sessions are unavailable in `Hooks::onUserGetDefaultOptions()` so it does not seem to be possible to determine whether the active user is an anonymous or existing account. This patch drops the hook and centralizes all version determination logic in SkinVersionLookup::getVersion(). SkinVersionLookup requires a the active User object and can make the anonymous / existing account determination by checking login state. The issued was identified while responding to review feedback given by @polishdeveloper / @pmiazga in I52d80942b4270c008d4e45050589ed9220255a50. Bug: T251415 Change-Id: I7982b4c34283ba81d0232ee6f501c44cf0a74b98
2020-04-28 21:02:15 +00:00
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to use when an existing user has not specified a preference. This configuration is not used for new accounts (see VectorDefaultSkinVersionForNewAccounts) and is impermanent. In the future, this field may contains versions such as \"beta\" which when specified and the BetaFeatures extension is installed, and the user is enrolled, the latest version is used otherwise legacy. The value is _not_ persisted."
[Special:Preferences] [PHP] Add skin version user preference and configs Add a Vector-specific user preference to Special:Preferences for toggling skin version, either Legacy Vector or the latest Vector. The presentation of the new preference section and the default values for anonymous, new, and existing accounts are configurable via $wgVectorShowSkinPreferences, $wgVectorDefaultSkinVersion (to be used by the feature manager in T244481), $wgVectorDefaultSkinVersionForExistingAccounts, and $wgVectorDefaultSkinVersionForNewAccounts. These configurations default to the fullest experience so that third-party configuration is minimal. See skin.json for details. The configurations are each tested in VectorHooksTest.php. When presentation is enabled, the new preference appears as a checkbox; enabled is Legacy mode and disable is latest. There are a number of unfortunate details: - Showing and hiding a checkbox is supported by OOUI. Showing and hiding a whole section (Vector skin preferences, in this case) is not so this additional client JavaScript functionality is added in Core (see Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377). - Stylization as a checkbox is wanted. However, the implied storage type for OOUI checkboxes is a boolean. This is not wanted in the event that another skin version is added (e.g., '3' or 'alpha'). As a workaround, the preference is converted from a boolean to a version string ('1' or '2') on save in Hooks::onPreferencesFormPreSave() and from a version string to a checkbox enable / disable string ('1' or '0') in onGetPreferences(). There a number of test cases to help cover these concerning details. Documentation for overriding the skin version as a URL query parameter is provided in anticipation of T244481. Bug: T242381 Bug: T245793 Depends-On: Iaf68b238a8ac7a4fb22b9ef5d6c5a3394ee2e377 Depends-On: Ifc2863fca9cd9efd11ac30c780420e8d89e8cb22 Change-Id: I177dad88fc982170641059b6a4f53fbb38eefad6
2020-01-23 21:53:09 +00:00
},
"VectorDefaultSkinVersionForNewAccounts": {
[config] Temporarily default to Legacy mode For all accounts, temporarily default to the Legacy skin version. This is to prevent regressions for third-parties until master has a complete logo and is in a shippable state. This change should be reverted as soon as interim changes in Latest mode are finished. Do these defaults need to be set elsewhere for development? Change-Id: I3c39352efe276b8574ab5d27fdab22901bc30b46
2020-05-04 13:25:38 +00:00
"value": "1",
[doc] fix reference in VectorDefaultSkinVersionForNewAccounts config Nick Ray identified in I7982b4c34283ba81d0232ee6f501c44cf0a74b98 that the config documentation for `VectorDefaultSkinVersionForNewAccounts` incorrectly referenced `VectorDefaultSkinVersion` for existing accounts. This should be `VectorDefaultSkinVersionForExistingAccounts`. This patch fixes the reference. Bug: T251415 Change-Id: I840831773f4b5996c4b7ffb9f29576830d55916f
2020-05-01 13:58:16 +00:00
"description": "@var string:['2'|'1'] The version ('2' for latest, '1' for legacy) of the Vector skin to **set** for newly created user accounts. **The value is persisted as a user preference.** This configuration is not used for preexisting accounts (see VectorDefaultSkinVersionForExistingAccounts) and only ever executed once at new account creation time."
Select initial side bar visibility depends on user login state and defaults Bug: T254230 Change-Id: If121b6c8187ef6b8562d135bd1c40403be3e9564
2020-07-07 08:59:14 +00:00
},
"VectorDefaultSidebarVisibleForAuthorisedUser": {
"value": true
},
"VectorDefaultSidebarVisibleForAnonymousUser": {
"value": false
Implement Page, Workspace, Content, and Article Toolbar Containers This patch closely follows the desired guidelines/desired styles Alex Hollender has put forth in his prototype, but uses multiple containers to achieve this look since our DOM order/structure is different than the DOM structure in the prototype. The following containers are used, but unlike his prototype, they are sometimes used more than once: * Page Container: Contains every other container and limits the overall max-width of the white part of the page. * Workspace Container: Contains the sidebar and content container. The sidebar is displaced ~30 pixels to the start (left) of the workspace container at all times. * Content Container: Contains the content. The max-width of this changes depending on whether you are on a special page/history page vs. other pages. * Article Toolbar Container: Contains the article toolbar. The max-width of this is always the same as the max-width of the article content as we don't want the toolbar to move when going from the article page to the history/special page. Changes to be aware: * To test locally, `$wgVectorLayoutMaxWidth = true;`. This design is temporarily feature flagged and defaults to being "off". * Note that layout-max-width.less is a temporary file made to meet the feature flag requirement of T246420 (intended to derisk the deployment). After the deploy, we should merge most if not all of the rules into layout.less where the max-width design will become the default. * Per Jon's code review comment, I have relaxed the indenting of skin.mustache to make the diff easier to reason about. If desired, the correct indenting can be achieved in a (much less risky) follow-up commit. Bug: T246420 Bug: T153043 Change-Id: Ie49f629bc705850c6996164a516957476c034048
2020-06-23 18:02:32 +00:00
},
"VectorLayoutMaxWidth": {
"value": false,
"description": "@var boolean Enables the max-width layout for the latest version of Vector. This is intended to be a very short-lived feature flag whose sole purpose is to derisk the deployment of T246420. It should be removed (and made the default) as quickly as possible."
Upgrade skin.json schema to manifest_version 2 Bug: T242469 Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-11 04:40:49 +00:00
}
Set manifest_version in skin.json Bug: T100745 Change-Id: I0ed0f42d5cb40b26043b829c9b85a15a19ce53c0
2015-06-08 20:20:52 +00:00
},
features: Add minimalist feature manager With complex additions to Vector's codebase like the Desktop Improvement Program upcoming, it's important that we have a shared, intuitive language to talk about features and their requirements. Centralising the registration of features and creating an API satisfies does exactly this. This change introduces a greatly-reduced version of Piotr Miazga's (polishdeveloper, pmiazga) original proposed API and associated scaffolding classes for feature management in Vector, which itself was based upon his work in MobileFrontend/MinervaNeue. This is done to establish a foundation upon which we can build the more sophisticated parts of Piotr's proposal in a piecemeal basis, thereby minimising risk. Distinct from Piotr's proposed API is the ability to register sets and features that are always enabled or disabled. Additionally: - A Vector.FeatureManager service is registered but not used - A list of proposed immediate next steps is included Bug: T244481 Change-Id: Ie53c41d479eaf15559d5bb00f269774760360bde
2020-02-20 16:37:33 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Upgrade skin.json schema to manifest_version 2 Bug: T242469 Change-Id: Idb96560efc8517ee8d353e856eb3a272af51ed4c
2020-01-11 04:40:49 +00:00
"manifest_version": 2
Add skin.json, deprecate and empty PHP entry point Bug: T87875 Change-Id: I0e298137e27e2a4c7ced5213ea90aef4cd991376
2015-04-07 19:52:32 +00:00
}
Reference in a new issue Copy permalink