mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 11:13:34 +00:00
8b04c45fb2
Why: Minerva uses watchstar both as a client to action=watch and as a CTA prompting users to create a new account. To prevent error messages about permissions from being displayed when logged in as a temp account (or not logged in at all), the API requests should be only sent when users actually has watchlist permissions. This patch fixes that by only passing data-mw=interface when the watchstar is actually used as part of MW watchlist interface, ie. when user is logged in. That means the `mediawiki.page.watch.ajax` module in core can avoid the watchstar element when it is not meant as a watchstar, but as a "sign up" CTA button. What: * Make it possible to change (or omit) data-mw in SingleMenuEntry by a new constructor parameter. * Make ToolbarBuilder::createWatchPageAction omit data-mw when user does not have watchlist permissions. Notes: Based on coversation with Krinkle in Ia0acdaf4dea5aa6788f89fdd73c5dba9af9f1ed7. Bug: T344925 Change-Id: Id9d6d9e7394b52d11ac6ce0b7d33319b3a761789 |
||
---|---|---|
.. | ||
DefaultOverflowBuilder.php | ||
EmptyOverflowBuilder.php | ||
IOverflowBuilder.php | ||
PageActionsDirector.php | ||
ToolbarBuilder.php | ||
UserNamespaceOverflowBuilder.php |