mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 11:13:34 +00:00
071aa7a0c9
This patch should knock out two bugs we were seeing with the simplified talk page: 1) Removes the "Add discussion" button and "There are no discussions" message from appearing on Flow enabled talk pages. 2) Removes the "Read as wiki page" and "Active Discussions"/"There are no discussions" message we were seeing on Minerva desktop talk pages. To address when the "There are no dicussions"/"Active Discussions" message and "Read as wikipage" button are displayed, Minerva now listens to MobileFrontend's `MobileFrontendBeforeDOM` hook and turns on the simplified talk page (via a skin option) when this hook runs. To address when the "Add discussion" button is added, a check was added to SkinMinerva which only adds it to a talk page if the content model is wikipage. Unfortunately, we can't just check the skin option because we also want to display the button on desktop minerva. Other changes: * Moves around the logic in `getTalkPagePostHeadingHTML` for improved readability Bug: T237589 Bug: T237597 Change-Id: I83fd5cab174d90b24a5335f2b30c912c3b68040a
118 lines
3.6 KiB
PHP
118 lines
3.6 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
namespace MediaWiki\Minerva;
|
|
|
|
/**
|
|
* A wrapper for all available Skin options.
|
|
*/
|
|
final class SkinOptions {
|
|
|
|
const MOBILE_OPTIONS = 'mobileOptionsLink';
|
|
const CATEGORIES = 'categories';
|
|
const BACK_TO_TOP = 'backToTop';
|
|
const PAGE_ISSUES = 'pageIssues';
|
|
const BETA_MODE = 'beta';
|
|
const TALK_AT_TOP = 'talkAtTop';
|
|
const HISTORY_IN_PAGE_ACTIONS = 'historyInPageActions';
|
|
const TOOLBAR_SUBMENU = 'overflowSubmenu';
|
|
const TABS_ON_SPECIALS = 'tabsOnSpecials';
|
|
const MAIN_MENU_EXPANDED = 'mainMenuExpanded';
|
|
const PERSONAL_MENU = 'personalMenu';
|
|
const SIMPLIFIED_TALK = 'simplifiedTalk';
|
|
|
|
/** @var array skin specific options, initialized with default values */
|
|
// Note stable skin options default to true for desktop-Minerva and are expected to be
|
|
// overridden on mobile.
|
|
private $skinOptions = [
|
|
self::BETA_MODE => false,
|
|
/**
|
|
* Whether the main menu should include a link to
|
|
* Special:Preferences of Special:MobileOptions
|
|
*/
|
|
self::MOBILE_OPTIONS => false,
|
|
/** Whether a categories button should appear at the bottom of the skin. */
|
|
self::CATEGORIES => false,
|
|
/** Whether a back to top button appears at the bottom of the view page */
|
|
self::BACK_TO_TOP => false,
|
|
/** requires a wiki using Template:Ambox */
|
|
self::PAGE_ISSUES => false,
|
|
/** no extension requirements */
|
|
self::TALK_AT_TOP => true,
|
|
/** no extension requirements */
|
|
self::HISTORY_IN_PAGE_ACTIONS => true,
|
|
/** no extension requirements */
|
|
self::TOOLBAR_SUBMENU => true,
|
|
/** Whether to show tabs on special pages */
|
|
self::TABS_ON_SPECIALS => false,
|
|
/** whether to show a personal menu */
|
|
self::PERSONAL_MENU => true,
|
|
/** whether to show a main menu with additional items */
|
|
self::MAIN_MENU_EXPANDED => true,
|
|
/** whether the simplified talk page is eligible to be shown */
|
|
self::SIMPLIFIED_TALK => false,
|
|
];
|
|
|
|
/**
|
|
* override an existing option or options with new values
|
|
* @param array $options
|
|
*/
|
|
public function setMultiple( array $options ) {
|
|
foreach ( $options as $option => $value ) {
|
|
if ( !array_key_exists( $option, $this->skinOptions ) ) {
|
|
throw new \OutOfBoundsException( "SkinOption $option is not defined" );
|
|
}
|
|
}
|
|
$this->skinOptions = array_merge( $this->skinOptions, $options );
|
|
}
|
|
|
|
/**
|
|
* Return whether a skin option is truthy. Should be one of self:* constants
|
|
* @param string $key
|
|
* @return bool
|
|
*/
|
|
public function get( $key ) {
|
|
if ( !array_key_exists( $key, $this->skinOptions ) ) {
|
|
throw new \OutOfBoundsException( "SkinOption $key doesn't exist" );
|
|
}
|
|
return $this->skinOptions[$key];
|
|
}
|
|
|
|
/**
|
|
* Get all skin options
|
|
* @return array
|
|
*/
|
|
public function getAll() {
|
|
return $this->skinOptions;
|
|
}
|
|
|
|
/**
|
|
* Return whether any of the skin options have been set
|
|
* @return bool
|
|
*/
|
|
public function hasSkinOptions() {
|
|
foreach ( $this->skinOptions as $key => $val ) {
|
|
if ( $val ) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
}
|