a9533fc463
Two tests are failing. These are false positives that obscure real failures. Both are removed for the following reason. 1) Editor test is covered by the redirect tests - failing due to concurrent edits (possibly because multiple browser tests act on the same page at the same time). However, editing is already covered by the other 2 cases. 2) Remove unwatch test - this is failing as there is a problem in the setup - the page starts unwatched when it should be watched. The test for checking that an article can be watched should suffice here. Bug: T224947 Change-Id: I3049e1b190c3cb2ddc198a45681f59782f770d6a |
||
---|---|---|
.. | ||
config | ||
features | ||
specs | ||
.eslintrc.json | ||
README.md | ||
wdio.conf.cucumber.js | ||
wdio.conf.js |
Selenium tests
Please see tests/selenium/README.md file in mediawiki/core repository, usually at mediawiki/vagrant/mediawiki folder.
Setup
Set up MediaWiki-Vagrant:
cd mediawiki/vagrant
vagrant up
vagrant roles enable minerva
vagrant provision
cd mediawiki
npm install
Start Chromedriver and run all tests
Run both mediawiki/core and extension tests from mediawiki/core repository (usually at mediawiki/vagrant/mediawiki folder):
npm run selenium
Start Chromedriver
To run only some tests, you first have to start Chromedriver in one terminal tab (or window):
chromedriver --url-base=wd/hub --port=4444
Run test(s) from one file
Then, in another terminal tab (or window) run this from mediawiki/core repository (usually at mediawiki/vagrant/mediawiki folder):
npm run selenium-test -- --spec tests/selenium/specs/FILE-NAME.js
wdio
is a dependency of mediawiki/core that you have installed with npm install
.
Run specific test(s)
To run only test(s) which name contains string TEST-NAME, run this from mediawiki/core repository (usually at mediawiki/vagrant/mediawiki folder):
./node_modules/.bin/wdio tests/selenium/wdio.conf.js --spec extensions/EXTENSION-NAME/tests/selenium/specs/FILE-NAME.js --mochaOpts.grep TEST-NAME
Make sure Chromedriver is running when executing the above command.
Migrating a test from Ruby to Node.js
Currently we are in the midst of porting our Ruby tests to Node.js. When the tests/browser/features folder is empty, we are done and the whole tests/browser folder can be removed.
This is a slow process (porting a single test can take an entire afternoon).
Step 1 - move feature file
Move the feature you want to port to Node.js
mv tests/browser/features/<name>.feature tests/selenium/features/
Step 2 - add boilerplate for missing steps
Run the feature in cucumber
npm run selenium-test-cucumber -- --spec tests/selenium/features/<name>.feature
You will get warnings such as:
Step "I go to a page that has languages" is not defined. You can ignore this error by setting cucumberOpts.ignoreUndefinedDefinitions as true.
For each missing step define them as one liners inside selenium/features/step_definitions/index.js
Create functions with empty bodies for each step.
Function anmes should be camel case without space, for example, I go to a page that has languages
becomes iGoToAPageThatHasLanguages
. Each function should be imported from a step file inside the features/step_definitions folder.
Re-reun the test. If done correctly this should now pass.
Example: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/501792/1..2
Step 3 - copy across Ruby function bodies
Copy across the body of the Ruby equivalent inside each function body in tests/browser/features/step_definitions as comments.
Example: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/501792/2..3
Step 4 - rewrite Ruby to Node.js
Sadly there is no shortcut here. Reuse as much as you can. Work with the knowledge that the parts you are adding will aid the next browser test migration.
The docs are your friend: http://v4.webdriver.io/api/utility/waitForVisible.html
Example: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/501792/2..4
Step 5 - Make it work without Cucumber
Now the tests should be passing when run the browser tests using wdio.conf.cucumber.js or npm run selenium-test-cucumber
The final step involves making these run with
npm run selenium-test
This is relatively straightforward and mechanical.
- Copy the feature file to the specs folder
cp tests/selenium/features/editor_wikitext_saving.feature tests/selenium/specs/editor_wikitext_saving.js
- Convert indents to tabs
- Add
//
before any tags - Replace
Scenario: <name>
withit( '<name>', () => {
- Add closing braces for all scenarios:
} );
- Replace
Feature: <feature>
withdescribe('<feature>)', () => {
and add closing brace. - Replace
Background:
withbeforeEach( () => {
and add closing brace. - Find and replace
Given
,When
,And
,Then
with empy strings. - At top of file copy and paste imports from
selenium/features/step_definitions/index.js
to top of your new file and rewrite their paths. - Relying on autocomplete (VisualStudio Code works great) replace all the lines with the imports
- Drop unused imports from the file.