mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-16 10:50:52 +00:00
7f68c3d3ad
There should be no caching implications for this change, as the main menu has been server side rendered on all wikis since 10th October. As Stephen pointed out somewhere, this is a bit of a micro-optimisation Let's simplify this code by always rendering it in the HTML. MainMenu.js as a result becomes a controller that just decides when to show it. The geolocation check for Nearby is removed given the fact that all grade A browsers for mediawiki have Geolocation support. ev.preventDefault in onSkinClick is dropped since the link to the '#' (the default behaviour) is wanted Additional changes * Browser support suggests "animations" class is redundant now * `open` event no longer filed - not being used anywhere * Transparent shield is now managed by the MainMenu controller not the skin (which was confusing) * Test geolocation using a simple feature tests rather than abstracting it away inside Browser * The main menu button is always hidden under either a translucent shield and/or the main menu itself when it has been opened so so it's not possible to ever click it while the menu is open - the click handler is thus simplified removing a check for the class of the button Bug: T234650 Change-Id: If101eebbdbda1519af922745917237648722820e |
||
|---|---|---|
| .. | ||
| menu | ||
| permissions | ||
| skins | ||
| LanguagesHelper.php | ||
| MinervaHooks.php | ||
| MinervaUI.php | ||
| ResourceLoaderLessVarFileModule.php | ||
| ServiceWiring.php | ||
| SkinOptions.php | ||