mediawiki-skins-MinervaNeue/includes/menu/PageActions
jdlrobson c0f08790ea Remove the mw-ui-icon hacks and overrides
Note: this agitates T230232 again - when merging this please
make sure a merge for I929090848f3e04647a97f4979ec78682623fa070
is pending.

In various places we try to override the default mw-ui-icon behaviours
The hacks need to be removed as part of addressing the core problem.

Changes:
* Wherever we use mw-ui-icon-before in PHP - wrap the label with a span
so that label font-size is altered where needed - not the icon
* Where a small icon is needed us isSmall parameter for the Icon component
* Apply font-size to labels of mw-ui-icon-before elements
* The browser tests need a slight update to access the span element inside
a menu item - in the case of the logout button the label is always hidden,
so we need to check the visibility of the parent element (secondary_action)

Bug: T229440
Depends-On:  I3f803ec4c9068b30aa93b803391aa4d65d8310ff
Change-Id: I07e4ae233979636b739f1117dd7703571e0a9366
2019-09-10 10:53:20 -07:00
..
DefaultOverflowBuilder.php Remove the mw-ui-icon hacks and overrides 2019-09-10 10:53:20 -07:00
EmptyOverflowBuilder.php Hygiene: Add return types for known services 2019-06-21 19:06:04 +02:00
IOverflowBuilder.php Hygiene: Add return types for known services 2019-06-21 19:06:04 +02:00
PageActionMenuEntry.php Track all menu interactions 2019-08-26 11:43:16 -07:00
PageActionsDirector.php Track all menu interactions 2019-08-26 11:43:16 -07:00
ToolbarBuilder.php Remove the mw-ui-icon hacks and overrides 2019-09-10 10:53:20 -07:00
UserNamespaceOverflowBuilder.php Remove the mw-ui-icon hacks and overrides 2019-09-10 10:53:20 -07:00