mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-14 18:05:01 +00:00
874d9c9e3b
From TypeScript's do's and don'ts:[0] Don’t ever use the types Number, String, Boolean, or Object. These types refer to non-primitive boxed objects that are almost never used appropriately in JavaScript code. Although Minerva only uses JSDocs at this time which seemingly doesn't care about casing[1], we should endeavor to use the proper return types. This patch lowercases typing to indicate primitive / boxed type as appropriate.[2] As a special case, function types are uppercased for compatibility with TypeScript type checking. Also, JQuery types are of type "JQuery". The global JQuery object's identifier is "jQuery". This patch uppercases J's where appropriate. Lastly, replace unsupported type "Integer" with "number" and a comment. [0] https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#general-types [1] https://github.com/jsdoc3/jsdoc/issues/1046#issuecomment-126477791 [2] find resources tests -iname \*.js| xargs -rd\\n sed -ri ' s%\{\s*(number|string|boolean|object|null|undefined)%{\L\1%gi; s%\{\s*function%{Function%g; s%\{\s*jquery%{JQuery%gi; s%\{\s*integer\s*\}%{number} An integer.%gi ' Change-Id: I6cbac15940e4501aee7ede8f421b77ffd027170d
45 lines
900 B
JavaScript
45 lines
900 B
JavaScript
( function ( M ) {
|
|
|
|
var Icon = M.require( 'mobile.startup/Icon' );
|
|
|
|
function getIconFromAmbox( $box ) {
|
|
var glyph,
|
|
names = [
|
|
'speedy',
|
|
'delete',
|
|
'protection',
|
|
'pov',
|
|
'move',
|
|
'style',
|
|
'content'
|
|
];
|
|
|
|
// since objects have no concept of ordering we repeat ourselves here
|
|
names.forEach( function ( name ) {
|
|
if ( !glyph && $box.hasClass( 'ambox-' + name ) ) {
|
|
// with a match, exit
|
|
glyph = name;
|
|
}
|
|
} );
|
|
|
|
glyph = glyph || 'default';
|
|
return new Icon( {
|
|
glyphPrefix: 'minerva',
|
|
name: 'issue-' + glyph
|
|
} );
|
|
}
|
|
|
|
/**
|
|
* @module skins.minerva.scripts/utils
|
|
*/
|
|
M.define( 'skins.minerva.scripts/utils', {
|
|
/**
|
|
* Extract an icon for use with the issue.
|
|
* @param {JQuery.Object} $box element to extract the icon from
|
|
* @return {Icon} representing the icon
|
|
*/
|
|
getIconFromAmbox: getIconFromAmbox
|
|
} );
|
|
|
|
}( mw.mobileFrontend ) );
|