mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 03:08:12 +00:00
c0f08790ea
Note: this agitates T230232 again - when merging this please make sure a merge for I929090848f3e04647a97f4979ec78682623fa070 is pending. In various places we try to override the default mw-ui-icon behaviours The hacks need to be removed as part of addressing the core problem. Changes: * Wherever we use mw-ui-icon-before in PHP - wrap the label with a span so that label font-size is altered where needed - not the icon * Where a small icon is needed us isSmall parameter for the Icon component * Apply font-size to labels of mw-ui-icon-before elements * The browser tests need a slight update to access the span element inside a menu item - in the case of the logout button the label is always hidden, so we need to check the visibility of the parent element (secondary_action) Bug: T229440 Depends-On: I3f803ec4c9068b30aa93b803391aa4d65d8310ff Change-Id: I07e4ae233979636b739f1117dd7703571e0a9366
36 lines
1.1 KiB
JavaScript
36 lines
1.1 KiB
JavaScript
const assert = require( 'assert' );
|
|
const { ArticlePage } = require( '../support/world.js' );
|
|
|
|
const iSeeALinkToAboutPage = () => {
|
|
assert.strictEqual( ArticlePage.menu_element.element( '*=About' ).isVisible(), true );
|
|
};
|
|
|
|
const iClickOnTheMainNavigationButton = () => {
|
|
ArticlePage.menu_button_element.click();
|
|
};
|
|
|
|
const iShouldSeeAUserPageLinkInMenu = () => {
|
|
ArticlePage.menu_element.element( '.primary-action' );
|
|
};
|
|
|
|
const iShouldSeeLogoutLinkInMenu = () => {
|
|
ArticlePage.menu_element.element( '.secondary-action' );
|
|
};
|
|
|
|
const iShouldSeeALinkInMenu = ( text ) => {
|
|
assert.strictEqual( ArticlePage.menu_element.element( `span=${text}` ).isVisible(),
|
|
true, `Link to ${text} is visible.` );
|
|
};
|
|
|
|
const iShouldSeeALinkToDisclaimer = () => {
|
|
ArticlePage.menu_element.element( '=Disclaimers' ).waitForVisible();
|
|
assert.strictEqual( ArticlePage.menu_element.element( '=Disclaimers' ).isVisible(), true );
|
|
};
|
|
|
|
module.exports = {
|
|
iClickOnTheMainNavigationButton,
|
|
iSeeALinkToAboutPage, iShouldSeeAUserPageLinkInMenu,
|
|
iShouldSeeLogoutLinkInMenu,
|
|
iShouldSeeALinkInMenu, iShouldSeeALinkToDisclaimer
|
|
};
|