mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-09-24 10:48:29 +00:00
9676395529
This icon's stroke was explicitly set to `#000` before this commit, but
we need its color to be `#54595d` to match the other icons in the
overflow menu [1]. Unfortunately, although we set a variant in skin.json
for the icon to be colored this way [2], there are 2 problems that
prevent it from displaying this color:
1) The icon sets an explicit black color for its stroke attribute
2) ResourceLoader currently only sets the fill color on the `g` element
when applying the variant style [3]. It does not set the stroke color. Even
if problem 1) was removed, we would need RL to set the stroke color, but
I'm not sure how that would affect other variant icons that RL deals
with.
The simplest possible solution is to to change the stroke attribute on
the icon itself, although it unfortunately introduces technical debt as
this icon now differs slightly from the OOUI one :(
[1] https://phabricator.wikimedia.org/T222630#5266575
[2] https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/skin.json#L262-L267
[3]
|
||
|---|---|---|
| .. | ||
| skins.minerva.amc.styles | ||
| skins.minerva.base.styles | ||
| skins.minerva.content.styles | ||
| skins.minerva.content.styles.images | ||
| skins.minerva.icons.images | ||
| skins.minerva.icons.images.scripts | ||
| skins.minerva.icons.images.scripts.misc | ||
| skins.minerva.icons.loggedin | ||
| skins.minerva.icons.page.issues.default.color | ||
| skins.minerva.icons.page.issues.medium.color | ||
| skins.minerva.icons.page.issues.uncolored | ||
| skins.minerva.loggedin.styles | ||
| skins.minerva.mainMenu.icons | ||
| skins.minerva.mainMenu.styles | ||
| skins.minerva.mainPage.styles | ||
| skins.minerva.notifications | ||
| skins.minerva.notifications.badge | ||
| skins.minerva.options | ||
| skins.minerva.scripts | ||
| skins.minerva.talk | ||
| skins.minerva.toggling | ||
| skins.minerva.userpage.icons | ||
| skins.minerva.userpage.styles | ||
| skins.minerva.watchstar | ||
| wikimedia.ui | ||