Martin Urbanec 0109b17483 watchlist: Don't assume only named users have watchlist access ... In I1ccda3878a658d4251429ae65ebee04c09d81243, core decided to technically allow temp. users to have watchlist access, but have it disabled on permission level (viewmywatchlist / editmywatchlist) instead of by isNamed() checks. Minerva expects the watchlist permissions to be assigned to everyone, but actual watchlist access to be available only to named user. This is an incorrect assumption. Make a clear difference between "page is watchable" concept (watch icon should show) and "user has permission to watch" (if not, CTA to log in should show). There is one additional step to fix, which is ensure temp users receive the T330518 drawer. That is not a bug in MinervaNeue, but in core -- mediawiki.page.watch.ajax.js uses e.stopPropagating(), which means Minerva's CtaDrawer doesn't get a say. Ideally, mediawiki.page.watch.ajax.js would know whether the user has permissions to edit their watchlist. Alternatively, it could have an interface to allow extensions to add their own error handling. See T344925 for details. Bug: T344870 Change-Id: Id1757fb4fb433fe39cf4d5c6e1e9c65ab5abae14		2023-08-24 14:12:43 +00:00
..
IMinervaPagePermissions.php	watchlist: Don't assume only named users have watchlist access	2023-08-24 14:12:43 +00:00
MinervaPagePermissions.php	watchlist: Don't assume only named users have watchlist access	2023-08-24 14:12:43 +00:00