mediawiki-skins-MinervaNeue/tests/qunit/skins.minerva.scripts
Stephen Niedzielski 3dc9cff2c2 Hygiene: separate page issue view logic
- Move page issue view components that do not modify the DOM during
  during construction to PageIssueLearnMoreLink.js and PageIssueLink.js.
  PascalCase is used optimistically for filenaming in the hopes that
  these functions can become something like a JSX component. A "new"
  function prefix is used in the meantime.

- Move page issue view logic that munges the existing DOM to
  pageIssueFormatter.js. Substitute "create" prefixes for insert so that
  clients won't forget that calling the function is a modify operation.
  Alternative naming welcome but it shouldn't be confused with more
  idealistic components that do not depend on DOM state for
  construction.

- Consolidate createPageIssueBanner() and
  createPageIssueBannerMultiple() into insertPageIssueBanner() as the
  code was quite similar and were it a true component, it would probably
  be a single component.

All new files appear under page/ to keep their distinction from the
overlay code clear.

Some view logic remains in pageIssues.js but it shall be difficult to
isolate.

Bug: T212376
Change-Id: Iccce709c34fa8de5a28a5a00098add5775e3dc9a
2019-02-13 00:42:56 +00:00
..
AB.test.js Hygiene: replace mobile.startup/paths with props 2019-02-07 14:55:04 -07:00
downloadPageAction.test.js Hygiene: revise lazyImageLoader.loadImages() API 2019-01-25 10:50:09 -07:00
pageIssues.test.js Hygiene: separate page issue view logic 2019-02-13 00:42:56 +00:00
pageIssuesParser.test.js eslint: Remove exception for computed-property-spacing 2019-01-24 17:58:36 +00:00
stubs.js pageIssuesOverlay is a factory function that returns an Overlay 2019-01-03 08:31:39 -08:00