mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-24 22:25:27 +00:00
82a2edf585
The SkinMinerva::createWatchPageAction() was depending upon $tpl['content_navigation']['actions'] object, which is created by SkinTemplate::buildContentNavigationUrls(). Although only 'watch' and 'unwatch' keys were used, moreover, code was using only 'href' property from both 'watch' and 'unwatch'. All other props are overrided, not used when rendering. Also the title of unwatch icon was set to "watch this page" which was incorrect. This system was bit complex to manage (we should provide dependencies not pass the whole 'content_navigation']['actions'] array). It would also make further refactoring more difficult, as watchstar icon shouldn't depened on quicktemplate stuff. We were using only href attribute which is super easy to calculate. Changes: - do not depend upon $actions, get href by using $title->getLocalUrl - set proper title for unwatch icon - simplified SkinMinerva::createWatchPageAction() logic Bug: T221792 Change-Id: I9609949b60a7e2f2f0a947c05c80c89be32d4cb1 |
||
|---|---|---|
| .. | ||
| menu | ||
| skins | ||
| MinervaHooks.php | ||
| MinervaUI.php | ||
| ResourceLoaderLessVarFileModule.php | ||
| ServiceWiring.php | ||
| SkinOptions.php | ||