mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 03:08:12 +00:00
ef5003f310
The MobileFrontend dependency in Minerva is problematic. Code that Minerva needs should live in core. MobileFrontend should load code on all skins when they operate on a mobile domain. This eslint check reminds developers of this in a hope it encourages more upstreaming to core when possible. Of course disabling is also an option, but this check will at least make us aware of when we are moving further away from the goal. Change-Id: I62183c9aefc81053e4ad81fb746decef2dd24b44
81 lines
2.8 KiB
JavaScript
81 lines
2.8 KiB
JavaScript
module.exports = function () {
|
|
var
|
|
// eslint-disable-next-line no-restricted-properties
|
|
M = mw.mobileFrontend,
|
|
mobile = M.require( 'mobile.startup' ),
|
|
SearchOverlay = mobile.search.SearchOverlay,
|
|
SearchGateway = mobile.search.SearchGateway,
|
|
overlayManager = mobile.OverlayManager.getSingleton(),
|
|
searchLogger = mobile.search.MobileWebSearchLogger,
|
|
// eslint-disable-next-line no-jquery/no-global-selector
|
|
$searchInput = $( '#searchInput' ),
|
|
placeholder = $searchInput.attr( 'placeholder' ),
|
|
// eslint-disable-next-line no-jquery/no-global-selector
|
|
$searchBar = $( '#searchInput, #searchIcon, .skin-minerva-search-trigger' ),
|
|
searchRoute = new RegExp( /\/search/ ),
|
|
searchOverlayInstance;
|
|
|
|
// Only continue on mobile devices as it breaks desktop search
|
|
// See https://phabricator.wikimedia.org/T108432
|
|
if ( mw.config.get( 'skin' ) !== 'minerva' ) {
|
|
return;
|
|
}
|
|
|
|
/**
|
|
* Hide the search overlay on pageload before the search route
|
|
* is registered with the overlayManager.
|
|
* Allows the usage of history.back() to close searchOverlay by
|
|
* preventing the situation described in https://phabricator.wikimedia.org/T102946
|
|
*/
|
|
function removeSearchOnPageLoad() {
|
|
if ( searchRoute.test( overlayManager.router.getPath() ) ) {
|
|
// TODO: replace when router supports replaceState https://phabricator.wikimedia.org/T189173
|
|
history.replaceState( '', document.title, window.location.pathname );
|
|
}
|
|
}
|
|
|
|
function getSearchOverlay() {
|
|
if ( !searchOverlayInstance ) {
|
|
searchOverlayInstance = new SearchOverlay( {
|
|
router: overlayManager.router,
|
|
gatewayClass: SearchGateway,
|
|
api: new mw.Api(),
|
|
searchTerm: $searchInput.val(),
|
|
placeholderMsg: placeholder
|
|
} );
|
|
searchLogger.register( searchOverlayInstance );
|
|
}
|
|
return searchOverlayInstance;
|
|
}
|
|
|
|
removeSearchOnPageLoad();
|
|
overlayManager.add( searchRoute, getSearchOverlay );
|
|
|
|
// Apparently needed for main menu to work correctly.
|
|
$searchBar.prop( 'readonly', true );
|
|
|
|
/**
|
|
* Trigger overlay on touchstart so that the on-screen keyboard on iOS
|
|
* can be triggered immidiately after on touchend. The keyboard can't be
|
|
* triggered unless the element is already visible.
|
|
* Touchstart makes the overlay visible, touchend brings up the keyboard afterwards.
|
|
*/
|
|
$searchBar.on( 'touchstart click', function ( ev ) {
|
|
ev.preventDefault();
|
|
overlayManager.router.navigate( '/search' );
|
|
} );
|
|
|
|
$searchBar.on( 'touchend', function ( ev ) {
|
|
ev.preventDefault();
|
|
/**
|
|
* Manually triggering focus event because on-screen keyboard only
|
|
* opens when `focus()` is called from a "user context event",
|
|
* Calling it from the route callback above (which calls SearchOverlay#show)
|
|
* doesn't work.
|
|
* http://stackoverflow.com/questions/6837543/show-virtual-keyboard-on-mobile-phones-in-javascript
|
|
*/
|
|
getSearchOverlay().showKeyboard();
|
|
} );
|
|
|
|
};
|