mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-12-01 01:06:31 +00:00
ded6430b47
Changes * Update FIXME in userMenu.less to merge selectors * We replace minerva-user-notifications class with minerva-notifications to short-circuit Echo's code so that it no longer replaces the Minerva notification badge with its own. * We update resources/skins.minerva.scripts/initMobile.js to introduce our own wire up code - this is responsible for opening Echo overlay and reseting the counter. The code in Echo will be removed in a follow up (see <I2f923e509d24524a2375ffbe6b3ef336487574bb>) * We update skinStyles/ext.echo.styles.badge.less with styles from Vector 2022 so that Minerva desktop remains consistent with desktop Vector 2022 experience. * We clearly mark technical debt relating to the special mobile version. Testing: * Pixel.js has a group echo that covers all the different variants. Make sure to update to latest main branch before running these. * Desktop should behave the same for Minerva as Echo. * On mobile only when a user has unseen notifications a red circle is shown. Otherwise a bell icon is shown, never with number. * On mobile a single button is visible that combines alert and count numbers. * With Echo disabled a bell shows that links to the user talk page Visual changes: * Previously the red circle became a transparent/gray circle on click. Now it will always be red. * Minor aligment changes to red circle and bell icon are expected as the change prevents MobileFrontend/Echo updating the icon to use Codex. Bug: T342907 Change-Id: I55c18cf723a32f80b93a01dd0687e005162c4e93
56 lines
1.4 KiB
JSON
56 lines
1.4 KiB
JSON
{
|
|
"root": true,
|
|
"extends": [
|
|
"wikimedia/client",
|
|
"wikimedia/jquery",
|
|
"wikimedia/mediawiki"
|
|
],
|
|
"env": {
|
|
"commonjs": true
|
|
},
|
|
"globals": {
|
|
"require": "readonly"
|
|
},
|
|
"rules": {
|
|
"no-restricted-properties": [
|
|
"error",
|
|
{
|
|
"property": "mobileFrontend",
|
|
"message": "Minerva should only make use of core code. Any code using mobileFrontend should be placed inside the MobileFrontend extension"
|
|
},
|
|
{
|
|
"property": "define",
|
|
"message": "The method `define` if used with mw.mobileFrontend is deprecated. Please use `module.exports`."
|
|
},
|
|
{
|
|
"property": "done",
|
|
"message": "The method `done` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
},
|
|
{
|
|
"property": "fail",
|
|
"message": "The method `fail` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
},
|
|
{
|
|
"property": "always",
|
|
"message": "The method `always` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
}
|
|
],
|
|
"unit-disallowed-list": "off",
|
|
"object-property-newline": "error",
|
|
"mediawiki/class-doc": "off",
|
|
"no-use-before-define": "off",
|
|
"no-underscore-dangle": "off",
|
|
"jsdoc/no-undefined-types": "off",
|
|
"no-var": "warn"
|
|
},
|
|
"overrides": [
|
|
{
|
|
"files": [ ".eslintrc.json" ],
|
|
"extends": "wikimedia/server",
|
|
"rules": {
|
|
"compat/compat": "off"
|
|
}
|
|
}
|
|
]
|
|
}
|