mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 19:21:39 +00:00
e888b487f4
Logic is moved from server to client. Config is added via getSkinConfigVariables (e.g. passed to mw.config ) and a JavaScript if statement. The IIFE in watchstar and talk files is replaced with a module.exports function to avoid refactoring at this point and added risk. The file contents remain the same. skins.minerva.options is left as is, given the code is more experimental and used in the beta mode - should not be sent to all clients. Additional change: * Remove skins.minerva.toggling (that module has been empty for a week now and functionality moved to mobile.init module) Depends-On: Ie71adbe18e8dbeb661ddb9d7d3d1d0897891d515 Bug: T233048 Change-Id: Ife777e76d9d77894fb5d09e7c8f0238b00596a7a
55 lines
1.8 KiB
Ruby
55 lines
1.8 KiB
Ruby
When(/^I click the talk button$/) do
|
|
on(ArticlePage) do |page|
|
|
page.wait_until_rl_module_ready('skins.minerva.scripts')
|
|
page.talk_element.when_present.click
|
|
end
|
|
end
|
|
|
|
When(/^no topic is present$/) do
|
|
expect(on(ArticlePage).talk_overlay_content_header_element.when_present.text).to match 'There are no conversations about this page.'
|
|
end
|
|
|
|
When(/^I add a topic called "(.+)"$/) do |topic|
|
|
step 'I click the add discussion button'
|
|
on(ArticlePage) do |page|
|
|
page.talk_overlay_summary = topic
|
|
page.talk_overlay_body = 'Topic body is a really long text.'
|
|
page.wait_until { page.talk_overlay_save_button_element.enabled? }
|
|
page.talk_overlay_save_button
|
|
end
|
|
end
|
|
|
|
When(/^I see the talk overlay$/) do
|
|
on(ArticlePage).overlay_element.when_visible
|
|
end
|
|
|
|
When(/^I click the add discussion button$/) do
|
|
on(ArticlePage).talkadd_element.when_present.click
|
|
end
|
|
|
|
Then(/^I should see the topic called "(.+)" in the list of topics$/) do |topic|
|
|
# Timeout is high as the previous action hits the API which may take some time
|
|
expect(on(ArticlePage).talk_overlay_first_topic_title_element.when_present(20).text).to match topic
|
|
end
|
|
|
|
Then(/^I should see the talk overlay$/) do
|
|
on(ArticlePage) do |page|
|
|
page.wait_until_rl_module_ready('mobile.talk.overlays')
|
|
expect(on(ArticlePage).overlay_heading_element.when_present.text).to match 'Talk'
|
|
end
|
|
end
|
|
|
|
Then(/^there should be no talk button$/) do
|
|
expect(on(ArticlePage).talk_element).not_to be_visible
|
|
end
|
|
|
|
Then(/^there should be an add discussion button$/) do
|
|
# give overlay time to fully load
|
|
expect(on(ArticlePage).talkadd_element.when_present(10)).to be_visible
|
|
end
|
|
|
|
Then(/^there should be a save discussion button$/) do
|
|
# give overlay time to fully load
|
|
expect(on(ArticlePage).talktopic_save_element.when_present(10)).to be_visible
|
|
end
|