mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 19:21:39 +00:00
72df451bd3
Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
192 lines
5.5 KiB
JavaScript
192 lines
5.5 KiB
JavaScript
( function () {
|
|
var icon = {},
|
|
pageIssuesParser = require( '../../../../resources/skins.minerva.scripts/page-issues/parser.js' ),
|
|
extractMessage = pageIssuesParser.extract;
|
|
|
|
QUnit.module( 'Minerva pageIssuesParser' );
|
|
|
|
/**
|
|
* @param {string} className
|
|
* @return {Element}
|
|
*/
|
|
function newBox( className ) {
|
|
var box = document.createElement( 'div' );
|
|
box.className = className;
|
|
return box;
|
|
}
|
|
|
|
QUnit.test( 'extractMessage', function () {
|
|
[
|
|
[
|
|
$( '<div />' ).html(
|
|
'<div class="mbox-text">Smelly</div>'
|
|
).appendTo( '<div class="mw-collapsible-content" />' ),
|
|
{
|
|
issue: {
|
|
severity: 'DEFAULT',
|
|
grouped: true,
|
|
icon: icon
|
|
},
|
|
iconString: this.sandbox.match.typeOf( 'string' ),
|
|
text: '<p>Smelly</p>'
|
|
},
|
|
'When the box is a child of mw-collapsible-content it grouped'
|
|
],
|
|
[
|
|
$( '<div />' ).html(
|
|
'<div class="mbox-text">Dirty</div>'
|
|
),
|
|
{
|
|
issue: {
|
|
severity: 'DEFAULT',
|
|
grouped: false,
|
|
icon: icon
|
|
},
|
|
iconString: this.sandbox.match.typeOf( 'string' ),
|
|
text: '<p>Dirty</p>'
|
|
},
|
|
'When the box is not child of mw-collapsible-content it !grouped'
|
|
]
|
|
].forEach( function ( test ) {
|
|
sinon.assert.match( // eslint-disable-line no-undef
|
|
extractMessage( test[ 0 ] ),
|
|
test[ 1 ],
|
|
test[ 2 ]
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'parseSeverity', function ( assert ) {
|
|
var tests = [
|
|
[ '', 'DEFAULT', 'empty' ],
|
|
[ 'foo', 'DEFAULT', 'unknown' ],
|
|
[ 'ambox-style', 'LOW', 'style' ],
|
|
[ 'ambox-content', 'MEDIUM', 'content' ],
|
|
[ 'ambox-speedy', 'HIGH', 'speedy' ],
|
|
[ 'ambox-delete', 'HIGH', 'delete' ],
|
|
// Move has an "unknown" severity and falls into DEFAULT.
|
|
[ 'ambox-move', 'DEFAULT', 'move' ],
|
|
// Point of view uses ambox-content to identify correct severity.
|
|
[ 'ambox-content ambox-POV', 'MEDIUM', 'point of view' ]
|
|
// Mixed severities such as 'ambox-style ambox-content' are not prioritized.
|
|
];
|
|
tests.forEach( function ( params, i ) {
|
|
var
|
|
className = params[ 0 ],
|
|
expect = params[ 1 ],
|
|
test = params[ 2 ],
|
|
box = newBox( className );
|
|
assert.strictEqual(
|
|
pageIssuesParser.test.parseSeverity( box ),
|
|
expect,
|
|
'Result should be the correct severity; case ' + i + ': ' + test + '.'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'parseType', function ( assert ) {
|
|
var tests = [
|
|
[ '', 'DEFAULT', 'issue-generic', 'empty' ],
|
|
[ 'foo', 'DEFAULT', 'issue-generic', 'unknown' ],
|
|
[ 'ambox-move', 'DEFAULT', 'issue-type-move', 'move' ],
|
|
[ 'ambox-POV', 'MEDIUM', 'issue-type-point-of-view', 'point of view' ],
|
|
[ '', 'DEFAULT', 'issue-generic', 'Default severity' ],
|
|
[ '', 'LOW', 'issue-severity-low', 'Low severity' ],
|
|
[ '', 'MEDIUM', 'issue-severity-medium', 'Medium severity' ],
|
|
[ '', 'HIGH', 'issue-generic', 'HIGH severity' ]
|
|
];
|
|
tests.forEach( function ( params, i ) {
|
|
var
|
|
className = params[ 0 ],
|
|
severity = params[ 1 ],
|
|
expect = {
|
|
name: params[ 2 ],
|
|
severity: severity
|
|
},
|
|
test = params[ 3 ],
|
|
box = newBox( className );
|
|
assert.propEqual(
|
|
pageIssuesParser.test.parseType( box, severity ),
|
|
expect,
|
|
'Result should be the correct icon type; case ' + i + ': ' + test + '.'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'parseGroup', function ( assert ) {
|
|
var tests = [
|
|
[ undefined, false, 'orphaned' ],
|
|
[ '', false, 'ungrouped' ],
|
|
[ 'mw-collapsible-content', true, 'grouped' ]
|
|
];
|
|
tests.forEach( function ( params, i ) {
|
|
var
|
|
parentClassName = params[ 0 ],
|
|
expect = params[ 1 ],
|
|
test = params[ 2 ],
|
|
parent,
|
|
box = newBox( '' );
|
|
if ( parentClassName !== undefined ) {
|
|
parent = document.createElement( 'div' );
|
|
parent.className = parentClassName;
|
|
parent.appendChild( box );
|
|
}
|
|
assert.strictEqual(
|
|
pageIssuesParser.test.parseGroup( box ),
|
|
expect,
|
|
'Result should be the correct grouping; case ' + i + ': ' + test + '.'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'iconName', function ( assert ) {
|
|
var tests = [
|
|
[ '', 'DEFAULT', 'issue-generic-defaultColor' ],
|
|
[ '', 'LOW', 'issue-severity-low-lowColor' ],
|
|
[ '', 'MEDIUM', 'issue-severity-medium-mediumColor' ],
|
|
[ '', 'HIGH', 'issue-generic-highColor' ],
|
|
[ 'ambox-move', 'DEFAULT', 'issue-type-move-defaultColor' ],
|
|
[ 'ambox-POV', 'MEDIUM', 'issue-type-point-of-view-mediumColor' ],
|
|
// ResourceLoader only supplies color variants for the generic type. Ensure impossible
|
|
// combinations are forbidden.
|
|
[ 'ambox-style ambox-POV', 'LOW', 'issue-type-point-of-view-mediumColor' ],
|
|
[ 'ambox-content ambox-move', 'MEDIUM', 'issue-type-move-defaultColor' ]
|
|
];
|
|
tests.forEach( function ( params, i ) {
|
|
var
|
|
className = params[ 0 ],
|
|
severity = params[ 1 ],
|
|
expect = params[ 2 ],
|
|
box = newBox( className );
|
|
assert.strictEqual(
|
|
pageIssuesParser.iconName( box, severity ),
|
|
expect,
|
|
'Result should be the correct ResourceLoader icon name; case ' + i + ': ' + severity + '.'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'maxSeverity', function ( assert ) {
|
|
var tests = [
|
|
[ [], 'DEFAULT' ],
|
|
[ [ 'DEFAULT' ], 'DEFAULT' ],
|
|
[ [ 'DEFAULT', 'LOW' ], 'LOW' ],
|
|
[ [ 'DEFAULT', 'LOW', 'MEDIUM' ], 'MEDIUM' ],
|
|
[ [ 'DEFAULT', 'LOW', 'MEDIUM', 'HIGH' ], 'HIGH' ],
|
|
[ [ 'HIGH', 'DEFAULT', 'LOW', 'MEDIUM' ], 'HIGH' ],
|
|
[ [ 'DEFAULT', 'HIGH', 'LOW', 'MEDIUM' ], 'HIGH' ]
|
|
];
|
|
tests.forEach( function ( params, i ) {
|
|
var severities = params[ 0 ],
|
|
expect = params[ 1 ];
|
|
|
|
assert.strictEqual(
|
|
pageIssuesParser.maxSeverity( severities ),
|
|
expect,
|
|
'Result should be the highest severity in the array; case ' + i + '.'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
}() );
|