mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-24 14:23:53 +00:00
331df226f5
In I02f8645aac1d7b081eaba8f2ac92a2ef51f78182, Page.js was made into a
model and its html parsing responsibilities were moved to
PageHTMLParser. Additionally, a singleton for the current page
(currentPage.js) and a singleton for the curent page html parser
(currentPageHTMLParser.js) were introduced to replace the usage of
M.getCurrentPage().
This commit refactors Minerva to make use of these changes.
Notable changes:
* 🐛 The event bus singleton was added to references.js since it
previously relied on an instance of Skin to listen for the
`references-loaded` event. However, this event is emitted on the event
bus singleton.
* Additionally, I didn't see a reason why the `references-loaded` event
needed to also pass the current page instance when the only file
listening to it is references.js (which already has the current page
instance) so I removed that and the convoluted passing of page.js within
the file. I assumed this logic was unecessary.
* The call to drawer.showReferences in references.js now was made to
pass the currentPage instance as well as the currentPageHTMLParser. This
is to prepare for I6e858bbe73f83166476b5b2c0fdac1cca7404246 where the
getReferences() interface for ReferencesMobileViewGateway.js and
ReferencesHtmlScraperGateway.js is refactored to accept both of these
instances. Additionally, references.js was refactored to support event
delegation which gets rid of some parsing/setup logic.
Bug: T193077
Depends-On: I02f8645aac1d7b081eaba8f2ac92a2ef51f78182
Change-Id: I2f32dbcc4ebaa4bebb297cda1ecce3457922b343
|
||
|---|---|---|
| .. | ||
| skins.minerva.amc.styles | ||
| skins.minerva.base.styles | ||
| skins.minerva.content.styles | ||
| skins.minerva.content.styles.images | ||
| skins.minerva.icons.images | ||
| skins.minerva.icons.images.scripts | ||
| skins.minerva.icons.images.scripts.misc | ||
| skins.minerva.icons.loggedin | ||
| skins.minerva.icons.page.issues.default.color | ||
| skins.minerva.icons.page.issues.medium.color | ||
| skins.minerva.icons.page.issues.uncolored | ||
| skins.minerva.loggedin.styles | ||
| skins.minerva.mainMenu.icons | ||
| skins.minerva.mainMenu.styles | ||
| skins.minerva.mainPage.styles | ||
| skins.minerva.notifications | ||
| skins.minerva.notifications.badge | ||
| skins.minerva.options | ||
| skins.minerva.scripts | ||
| skins.minerva.talk | ||
| skins.minerva.toggling | ||
| skins.minerva.userpage.icons | ||
| skins.minerva.userpage.styles | ||
| skins.minerva.watchstar | ||
| wikimedia.ui | ||