mediawiki-skins-MinervaNeue/resources/wikimedia.ui
Nicholas Ray 9676395529 Correct Wikidata icon color in overflow menu
This icon's stroke was explicitly set to `#000` before this commit, but
we need its color to be `#54595d` to match the other icons in the
overflow menu [1]. Unfortunately, although we set a variant in skin.json
for the icon to be colored this way [2], there are 2 problems that
prevent it from displaying this color:

1) The icon sets an explicit black color for its stroke attribute
2) ResourceLoader currently only sets the fill color on the `g` element
when applying the variant style [3]. It does not set the stroke color. Even
if problem 1) was removed, we would need RL to set the stroke color, but
I'm not sure how that would affect other variant icons that RL deals
with.

The simplest possible solution is to to change the stroke attribute on
the icon itself, although it unfortunately introduces technical debt as
this icon now differs slightly from the OOUI one :(

[1] https://phabricator.wikimedia.org/T222630#5266575
[2] https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/skin.json#L262-L267
[3] 4e59467427/includes/resourceloader/ResourceLoaderImage.php (L331)

Bug: T222630
Change-Id: I8c10a6012c7d32ab8555b874e766bc2f36437cf8
2019-06-18 17:05:26 -06:00
..
articleRedirect-ltr.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
articleRedirect-rtl.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
info.svg Updating icons for AMC mode 2019-06-07 00:25:21 +02:00
link.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
listBullet-ltr.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
listBullet-rtl.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
logo-Wikidata.svg Correct Wikidata icon color in overflow menu 2019-06-18 17:05:26 -06:00
logo-Wikimedia.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
quotes-ltr.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
quotes-rtl.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
upload.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00
userAvatar.svg Update: add secondary page actions submenu in AMC mode 2019-04-19 14:51:17 +00:00