mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-09-27 04:06:38 +00:00
ef5003f310
The MobileFrontend dependency in Minerva is problematic. Code that Minerva needs should live in core. MobileFrontend should load code on all skins when they operate on a mobile domain. This eslint check reminds developers of this in a hope it encourages more upstreaming to core when possible. Of course disabling is also an option, but this check will at least make us aware of when we are moving further away from the goal. Change-Id: I62183c9aefc81053e4ad81fb746decef2dd24b44
58 lines
1.4 KiB
JSON
58 lines
1.4 KiB
JSON
{
|
|
"root": true,
|
|
"extends": [
|
|
"wikimedia/client",
|
|
"wikimedia/jquery"
|
|
],
|
|
"env": {
|
|
"commonjs": true
|
|
},
|
|
"globals": {
|
|
"OO": "readonly",
|
|
"mw": "readonly",
|
|
"require": "readonly"
|
|
},
|
|
"rules": {
|
|
"no-restricted-properties": [
|
|
"error",
|
|
{
|
|
"property": "mobileFrontend",
|
|
"message": "Minerva should only make use of core code. Any code using mobileFrontend should be placed inside the MobileFrontend extension"
|
|
},
|
|
{
|
|
"property": "define",
|
|
"message": "The method `define` if used with mw.mobileFrontend is deprecated. Please use `module.exports`."
|
|
},
|
|
{
|
|
"property": "done",
|
|
"message": "The method `done` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
},
|
|
{
|
|
"property": "fail",
|
|
"message": "The method `fail` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
},
|
|
{
|
|
"property": "always",
|
|
"message": "The method `always` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`."
|
|
}
|
|
],
|
|
"valid-jsdoc": [
|
|
"error",
|
|
{
|
|
"requireParamDescription": false,
|
|
"requireReturnDescription": false,
|
|
"requireReturn": false,
|
|
"preferType": {
|
|
"Boolean": "boolean",
|
|
"Number": "number",
|
|
"object": "Object",
|
|
"String": "string"
|
|
}
|
|
}
|
|
],
|
|
"object-property-newline": "error",
|
|
"no-use-before-define": "off",
|
|
"no-underscore-dangle": "off"
|
|
}
|
|
}
|