mirror of
https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue
synced 2024-11-17 19:21:39 +00:00
111757970e
As Stephen pointed out somewhere, this is a bit of a micro-optimisation Let's simplify this code by always rendering it in the HTML. MainMenu.js as a result becomes a controller that just decides when to show it. The geolocation check for Nearby is removed given the fact that all grade A browsers for mediawiki have Geolocation support Additional changes * Browser support suggests "animations" class is redundant now * `open` event no longer filed - not being used anywhere * Transparent shield is now managed by the MainMenu controller not the skin (which was confusing) * Test geolocation using a simple feature tests rather than abstracting it away inside Browser * The main menu button is always hidden under either a translucent shield and/or the main menu itself when it has been opened so so it's not possible to ever click it while the menu is open - the click handler is thus simplified removing a check for the class of the button Depends-On: I7fd243366cceae780bd46e1aef2c08dae073f647 Change-Id: I3892afb5ed3df628e2845043cf3bbc22a9928921 |
||
|---|---|---|
| .. | ||
| article_page.rb | ||
| create_article_page.rb | ||
| diff_page.rb | ||
| language_page.rb | ||
| main_page.rb | ||
| notification_page.rb | ||
| page.rb | ||
| special_history_page.rb | ||
| special_mobilediff_page.rb | ||
| special_search_page.rb | ||
| special_userlogin_page.rb | ||
| user_page.rb | ||