Stephen Niedzielski 933dc0e370 [dev] Replace menu entry inheritance with functions ... Break up Menu/DefaultBuilder into functions that are reusable without inheritance. The functions do not need much state to produce their outputs and a weighty inheritance hierarchy makes the code difficult to reason about. The functions are used in a following patch for the user menu. They're now simple, independent, static functions in BuilderUtil that are easy to reason about and compose. Also, ban inheritance via `final` in a few places nearby. Inheritance has not worked well in MobileFrontend and enabling it should be a special deliberate case, not a default. E.g., in the user menu, the changes could have been to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe just override it in the subclass. In either case, it makes the whole hierarchy nuanced and harder to reason about for something that should be dead simple. Bug: T214540 Change-Id: I6e9a2b36a1bff387eb3b33ea65b0a6806962810a		2019-07-23 18:07:02 -06:00
..
menu	[dev] Replace menu entry inheritance with functions	2019-07-23 18:07:02 -06:00
permissions	Extract language/variants check to a service	2019-07-16 19:53:57 +00:00
skins	Merge "Embrace packageFiles"	2019-07-16 21:21:42 +00:00
LanguagesHelper.php	Extract language/variants check to a service	2019-07-16 19:53:57 +00:00
MinervaHooks.php	Disable the recent changes table-based layout on Minerva	2019-07-22 23:29:04 +00:00
MinervaUI.php	Add GPL file header to PHP classes	2018-04-15 16:23:10 -07:00
ResourceLoaderLessVarFileModule.php	Add GPL file header to PHP classes	2018-04-15 16:23:10 -07:00
ServiceWiring.php	Extract language/variants check to a service	2019-07-16 19:53:57 +00:00
SkinOptions.php	Define default OPTION_TABS_ON_SPECIALS option	2019-06-07 11:44:53 +00:00