0a4f5b6126
Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05 |
||
---|---|---|
.phan | ||
components | ||
dev-scripts | ||
i18n | ||
includes | ||
minerva.less | ||
resources | ||
screenshots | ||
skinStyles | ||
tests | ||
.eslintrc.json | ||
.gitignore | ||
.gitreview | ||
.phpcs.xml | ||
.rubocop.yml | ||
.rubocop_todo.yml | ||
.stylelintrc.json | ||
.svgo.yml | ||
CODE_OF_CONDUCT.md | ||
composer.json | ||
COPYING | ||
Doxyfile | ||
Gemfile | ||
Gemfile.lock | ||
Gruntfile.js | ||
jsdoc.json | ||
package-lock.json | ||
package.json | ||
Rakefile | ||
README.md | ||
skin.json |
MinervaNeue skin
The MinervaNeue skin is a responsive mobile-first skin for your mediawiki instance.
Installation
See https://www.mediawiki.org/wiki/Skin:MinervaNeue
Development
Coding conventions
Please follow the coding conventions of MobileFrontend: https://www.mediawiki.org/wiki/MobileFrontend/Coding_conventions
Config
The following configuration options will apply only to the default mobile skin - Minerva.
$wgMinervaAlwaysShowLanguageButton
- Type:
Boolean
- Default:
true
Whether to show the language switcher button even if no languages are available for the page.
$wgMinervaEnableSiteNotice
- Type:
Boolean
- Default:
false
Controls whether site notices should be shown. See https://www.mediawiki.org/wiki/Manual:$wgSiteNotice.
$wgMinervaCountErrors
- Type:
Boolean
- Default:
false
Whether to count client side errors in statsv.
$wgMinervaErrorLogSamplingRate
- Type:
Integer
- Default:
0
Whether to log client side errors to EventLogging. If 0, error logging is disabled. If 0.5, 50% of all client side errors will be logged to the EventLogging client. If 1, all errors will be logged to the EventLogging client, thus when enabling this care should be taken that your setup is bug free in order to not overwhelm the EventLogging server.
$wgMinervaShowCategoriesButton
- Type:
Array
- Default:
[
'base' => false,
'beta' => true,
]
Controls whether the category button should be displayed.
$wgMinervaApplyKnownTemplateHacks
- Type:
Boolean
- Default:
false
When enabled and hacks.less exists, hacks.less workarounds are included in stylesheet. These should only be needed for Wikimedia based wikis or wikis using common templates such as Template:Infobox on those wikis.
$wgMinervaPageActions
- Type:
Array
- Default:
['edit', 'talk', 'watch', 'switch-language']
Controls which page actions, if any, are displayed. Allowed: edit
, watch
, talk
, and
switch-language
.
$wgMinervaPageIssuesNewTreatment
- Type:
Array
- Default:
[
'base' => false,
'beta' => true,
]
Controls whether page issues should be replaced with a "Page issues" link (false) or displayed inline (true).
$wgMinervaTalkAtTop
- Type:
Array
- Default:
[
'beta' => false,
'base' => false,
'amc' => true,
]
Controls whether the talk option should be displayed at the top of the page. This will work for all pages except the main page.
$wgMinervaHistoryInPageActions
- Type:
Array
- Default:
[
'beta' => false,
'base' => false,
'amc' => true,
]
Controls whether the history link appears in the page actions menu.
$wgMinervaOverflowInPageActions
- Type:
Array
- Default:
[
'beta' => false,
'base' => false,
'amc' => false,
]
Controls whether the overflow link appears in the page actions menu.
$wgMinervaShowShareButton
- Type:
Array
- Default:
[
'beta' => false,
'base' => false,
]
Controls whether the share feature should be added to the page actions menu.
$wgMinervaEnableBackToTop
- Type:
Array
- Default:
[
'base' => false,
'beta' => true,
]
Controls whether the a back to top button should appear in the bottom right of the screen when scrolling.
$wgMinervaCustomLogos
- Type:
Array
- Default:
[]
Make the logos configurable.
Currently, copyright
, copyright-fallback
, copyright-width
, and copyright-height
elements are
supported.
copyright
is the URL of the logo displayed in the header and footercopyright-fallback
is the URL of the fallback logo displayed on non-supported browsers like IE8 or Opera Minicopyright-width
(optional) is the width in pixels of the copyright image you want to displaycopyright-height
(optional) is the height in pixels of the copyright image you want to display- If the actual
copyright
dimensions are 200x30, then you may want to set the width and height to 100 and 15 respectively (in order to support retina screens). - Note that if -width and -height are not used sysadmin should ensure the image used is appropriately sized (suggested dimensions < 120px width and 18px height).
Example:
[
'copyright' => '/images/mysite_copyright_logo.png',
'copyright-width' => 100,
'copyright-height' => 15,
]
Example with fallback URL:
[
'copyright' => '/images/mysite_copyright_logo.svg',
'copyright-fallback' => '/images/mysite_copyright_logo.svg.png',
'copyright-width' => 100,
'copyright-height' => 15,
]
$wgMinervaAlwaysShowLanguageButton
- Type:
Boolean
- Default:
true
Whether to show the language switcher button even if no languages are available for the page.
$wgMinervaABSamplingRate
- Type:
Number
- Default:
0
On a scale of 0 to 1, determines the chance a user has of entering an AB test. A test is divided into 3 buckets, "control" "A" and "B". Users that are selected for the test have an equal chance of entering bucket "A" or "B", the remaining users fall into the "control" bucket and are excluded from the test.
1 - would run test on 100% of users (50% in A and 50% in B, 0 in control). 0.5 - would run test on 50% of users (25% in A, 25% in B, 50% in control). 0.05 - would run test on 5% of users (2.5% in A, 2.5% in B, 95% in control). 0 would disable the test and place all users in "control".
Group assignment is universal no matter how many tests are running since both
wgMinervaABSamplingRate
and mw.user.sessionId()
are globals.
Group membership can be debugged from the console via:
const AB = mw.mobileFrontend.require('skins.minerva.scripts/AB')
new AB({
testName: 'WME.PageIssuesAB',
samplingRate: mw.config.get( 'wgMinervaABSamplingRate', 0 ),
sessionId: mw.user.sessionId()
}).getBucket()
And since session ID is an input in calculating the group, reassignment occurs
when clearing it: mw.storage.session.remove('mwuser-sessionId')
.
$wgMinervaSchemaMainMenuClickTrackingSampleRate
Defines the sampling rate for the MobileWebMainMenuClickTracking schema.
- Type:
Number
- Default:
0
Components
Components may be shared between server and client. Keeping all code for a single component only in one directory makes it easier to understand the complete domain of a component, all of its implicit dependencies, and also what it is independent of. The structure does not hint at ResourceLoader module bundling of resources and code. That is the domain of skin.json.
New components are stored under components/. Potential older components are stored under includes/ and resources/, and those directory structures imperfectly represent ResourceLoader module divisions.
Mustache
Mustache templates at the root components/ directory, like components/PageActionsMenu.mustache or components/ToggleList.mustache, are designed to be rendered as root templates not partials. E.g.:
// 🆗
$templatesDir = __DIR__ . '/../../components';
$invalidateTemplateCache = false;
$templateParser = new TemplateParser( $templatesDir, $invalidateTemplateCache );
// Render components/ToggleList.mustache not components/ToggleList/ToggleList.mustache.
$html = $templateParser->processTemplate( 'ToggleList', $data );
Attempting to render a partial as a template root will fail because of components/ root path assumptions:
// 🚫
$templatesDir = __DIR__ . '/../../components/ToggleList';
$invalidateTemplateCache = false;
$templateParser = new TemplateParser( $templatesDir, $invalidateTemplateCache );
// Error: components/ToggleList/ToggleList.mustache references
// components/ToggleList/ToggleList/ToggleListItem.mustache which does not exist.
$html = $templateParser->processTemplate( 'ToggleList', $data );
Partials in components/ subdirectories, like components/PageActionsMenu/PageActionsMenu.mustache or components/ToggleList/ToggleList.mustache, are for in-template partial composition only as their paths assume the render root is components/. E.g.:
{{! Include components/ToggleList/ToggleList.mustache, not components/ToggleList.mustache. }}
{{> ToggleList/ToggleList}}