Commit graph

13 commits

Author SHA1 Message Date
jdlrobson 7280d255c0 Dev: Prep for storybook
* Remove ambiguity in imports - say the file extension
'less' for all instances of variables and mixins.
* Separate toast styles from drawer styles so they can be
imported separately
* associate header-action selector with its parent
(.overlay-header) not parent's parent (.overlay) so it can be imported
and rendered without the Overlay.

Change-Id: Ib7e19a440ba095d6424d35305fb41d643ca9764c
2019-08-21 12:20:26 -07:00
Volker E a738f25c05 Use system font stack as sans-serif choice
Using system font stack provides better reading experience on wider
range of operating systems and languages combinations.

Adding `fontFamilyBase` variable to easier update and clarify usage.

Bug: T175877
Change-Id: Id00fbe7ca90a3b31524c618de4441c413fe4afbe
2019-03-27 10:01:01 -07:00
Jan Drewniak f92b117158 Remove margin from tagline and add .page-heading element
Even though on most pages the tagline is empty, it still
has a bottom margin associated with it. This patch moves
that bottom margin into a container element that wraps
both the h1 and tagline.

This approach allows us to remove the bottom-margin from the tagline
as well as the top-margin from the AMC tabs in favour of just
one bottom margin on the .page-heading element.

Bug: T214195

Change-Id: I67d3938ab4a75f994acc28a8eefdf19e531c1f3d
2019-02-19 12:37:27 +01:00
Jan Drewniak 7208cea59b Adjust heading padding for special pages
Moves the padding from the main heading h1 on special page
to the main heading '.heading-holder' container.

This adds 15px bottom padding to all special page headings,
but reduces the top padding from 34 to 26px.

Also reduces some complexity around the padding of the
.tagline element.

Bug: T214195
Change-Id: Idc8ce9d7799b0a54648e6d0a830d570a173a3691
2019-02-08 02:08:36 +00:00
jdlrobson 89fdcca241 [Bug] Special:MobileOptions heading padding should be consistent
This simplifies commit 17a3b5b6b0

The top or bottom margins of contained elements will always collapse together
(per http://seifi.org/css/understanding-taming-collapsing-margins-in-css.html)

What we actually want is a margin bottom in tablet mode for Special:MobileOptions
and a padding bottom for taglines that only exists if the tagline is not empty

Bug: T202557
Change-Id: I741f08d2dec04f94b7c233a04a3fca7a065520f8
2018-11-15 11:38:06 -08:00
takidelfin 17a3b5b6b0 Special:MobileOptions: Consistent padding of heading
Fixed it by adding a new media query for <720px and defining `default` for MobileOptions regardless of screen width.

Bug: T202557
Change-Id: I11deac1a36d9ab02ccfbce639490a95ca176f136
2018-11-13 15:42:03 +01:00
jdlrobson a3efca1582 Remove unnecessary skins.minerva.base.styles
* truncated-text is only used in MainMenu, last modified bar,
 a few special pages
Making this a mixin and limiting it to mobile.startup skinStyles
and mobile.special.styles thus makes sense
* cloaked-element is only ever added by Skin.js in mobile.startup
* position-fixed is only ever added by Skin.js

Change-Id: Iaf7061e9dda87eb25c963f8a281175af08f358e5
2018-07-26 01:18:00 +00:00
Timo Tijhof 64134bd8a6 Remove minerva.less from global import path
Use local imports instead given all relevant files are within the
same repository, and don't vary by configuraion.

Bug: T140807
Depends-On: If3edac9a35b346af0320c12f70c0d978a6346201
Change-Id: Ife3cc345a63aff452e93accbe0a593fbaa358732
2018-05-29 12:19:00 +00:00
jdlrobson d228b2cbd7 multi-line, two-line and mw-ui-button-group only loaded where needed
The only usage of mw-ui-button is inside the SpecialMobileWatchList
class in MobileFrontend. Thus we needlessly load as
a render blocking CSS on all page views

multi-line and two-line are likewise only used inside
MobileSpecialPageFeed.php

mobile.special.styles is loaded on all Special pages
so let's load this instead here. This also allows us to use
the element on other special pages in future.

Change-Id: I2b363543d0356a18194a9d08922428a6cb944797
2018-04-11 21:50:53 +00:00
jdlrobson c986db6c0e Always render taglines unconditionally and update styles
Adjust tagline margin per Nirzar:
https://phabricator.wikimedia.org/T180095#3801719

Note, this will  enable the tagline everywhere.

Change-Id: I3bce2a3472ab2e53261965c953572f35cc740eed
Bug: T180095
2017-12-05 00:27:11 +00:00
jdlrobson 6df96ca768 Do not center align h2s in footer
In Id9b0e955d6e2a113f91484c7ee6bbc9275e3a2ec the css selector
was weakened and started impacting the footer as well.

This restores the old behaviour.

Bug: T180375
Change-Id: Ibfff6e249a3249ae2ee97d31fd50d2f5272a25ae
2017-11-13 10:49:21 -08:00
jdlrobson 10431c4ed1 Hygiene: Move css rule to Minerva
In preparation for "Adopt new special page template for special pages"
(T169379) move the text alignment rule to Minerva.

Change-Id: I5118a58bcb948c93e511587b8a3f29246b33acd7
2017-11-01 17:06:03 -07:00
jdlrobson 61ba76efdb Remove special page resource module handling
This is handled by MobileFrontend now, just as it should do.
We rely on skinStyles where possible.

Depends-On: I665f6fe60939475249786fdc951149c38473fda6
Bug: T173597
Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 19:37:08 +00:00