Commit graph

4247 commits

Author SHA1 Message Date
jenkins-bot ca8dae0def Merge "LanguagesHelper: Move $out from contructor to doesTitleHasLanguagesOrVariants" 2024-03-28 02:31:06 +00:00
jenkins-bot 045da4ce5b Merge "Inject service 'Minerva.Permissions' into SkinMinerva" 2024-03-28 02:24:15 +00:00
jenkins-bot 4a0fac3227 Merge "Avoid setContext in ServiceWiring for Minerva.Permissions" 2024-03-28 02:24:13 +00:00
jenkins-bot 3bfc204f85 Merge "Inject service 'Minerva.SkinOptions' into SkinMinerva" 2024-03-28 02:20:24 +00:00
jenkins-bot 4713a127df Merge "Improve variables" 2024-03-28 02:20:19 +00:00
jenkins-bot 2a233b1542 Merge "Remove styles in hacks.less that no longer apply" 2024-03-27 21:09:16 +00:00
Fomafix dfa61af611 Use alphabetic order for eslintrc rules
Change-Id: Ic7afff052c004ba179a8814f79e7722fb66bdbbc
2024-03-27 19:54:21 +00:00
bwang b8a6a9c1bd Remove styles in hacks.less that no longer apply
Bug: T360387
Change-Id: I3eb7ec0c8a52a39cc97b60443cac0e6a5bba5482
2024-03-27 14:14:09 -05:00
jenkins-bot 8df385d08f Merge "Minerva should use content-tables ResourceLoaderSkinModule feature" 2024-03-26 18:29:57 +00:00
Translation updater bot 7ffe913a64 Localisation updates from https://translatewiki.net.
Change-Id: I470441299ff1c0806270d3c68be6cfcab9f709d2
2024-03-26 08:23:31 +01:00
Fomafix 220bf6ff89 Inject service 'Minerva.LanguagesHelper' into SkinMinerva
Change-Id: Ie81195f31194bab819491576681b02660ec057b4
2024-03-25 22:36:07 +00:00
Fomafix f68b218076 LanguagesHelper: Move $out from contructor to doesTitleHasLanguagesOrVariants
Services MUST NOT vary their behaviour on global state, especially not
WebRequest, RequestContext (T218555).

Change-Id: I4b73ef713166d8b254023c1eebbb45c963880a99
2024-03-25 22:34:37 +00:00
Fomafix 57d1f15d64 Inject service 'Minerva.Permissions' into SkinMinerva
Change-Id: Ie68691d7030ea622f2bc232fea2df49b70484e19
2024-03-25 21:44:13 +00:00
Fomafix 11c0e6966b Avoid setContext in ServiceWiring for Minerva.Permissions
This change avoids a duplicate setContext in SkinMinerva.

Change-Id: I4b716a645bb2b6a5c05aa6e9a463640a2d87ab41
2024-03-25 21:43:50 +00:00
jenkins-bot 4963900d70 Merge "Update padding on <p> elements" 2024-03-25 19:36:20 +00:00
Jan Drewniak cf723c00c3 Guard against undefined $container element in initMobile.js
In order to prevent spikes in JS errors, ensure that the $container
element exists before initializing the mobile media viewer.

Bug: T360781
Change-Id: I48a57e8008e7bd90e9fcfc783f3720f6f75520a7
2024-03-25 09:38:11 -04:00
Fomafix 999f04c366 Inject service 'Minerva.SkinOptions' into SkinMinerva
Change-Id: Ia7e7660c55e16731366bdf6332d5237188e9bbb1
2024-03-25 13:17:32 +00:00
Fomafix 1f3fc12bb4 Improve variables
* Remove unused private properties.
* Remove unused variable.
* Inline variable used only once.

Change-Id: I7fcab8328264384335371a152c3f3cd4548c4210
2024-03-25 13:09:17 +00:00
jenkins-bot 278b5189bd Merge "Use Html::element instead of Html::rawElement and htmlspecialchars" 2024-03-25 12:50:29 +00:00
Fomafix 5d27b4ff3e Use Html::element instead of Html::rawElement and htmlspecialchars
Remove the comment about the reason for output encoding. Output
encoding is standard and doesn't require an explanation.

Change-Id: Ia2df4c95dca8aedca70be2f3b3827498de1f2030
2024-03-25 09:32:30 +00:00
Translation updater bot ed34320ea4 Localisation updates from https://translatewiki.net.
Change-Id: Ieac8e8fefa303febbbf60ca33cb9417cbf86a5e9
2024-03-25 08:39:06 +01:00
Jon Robson 32bf846613 Apply history styles to watchlist
The changes here only apply to the AMC-disabled mode
and only apply when visiting the watchlist with the
following configuraton:
$wgMFUseDesktopSpecialWatchlistPage = [ 'amc' => true, 'base' => true, ];

This change will allow us eventually to remove the special page
in MobileFrontend.

Bug: T109277
Change-Id: I15e95cbae77edde36ca822345a461d791ea5f29d
2024-03-22 14:10:07 -07:00
Translation updater bot 18d194b957 Localisation updates from https://translatewiki.net.
Change-Id: Idce4450d0566d4ba22f12bcf5bd75ef521c14637
2024-03-22 08:47:59 +01:00
Jon Robson 8f8fd6a1e4 Minerva should use content-tables ResourceLoaderSkinModule feature
The styles in Minerva are identical to the preset in core with the
own exception being padding. Therefore use the upstream styles
and retain only the override.

Bug: T357998
Depends-On: I206e91dac7e14d80a5ffc6b533255b54dafca29a
Change-Id: I3eb07a03b3b4e2a7544e5b07de6af9f67a1c965f
2024-03-21 22:49:14 +00:00
Jon Robson c2623ed44f Add soft dependency on Minerva to Vector
Bug: T359607
Change-Id: If293689999a54f067792d172441c7c47d0992ed9
2024-03-21 21:05:47 +00:00
Translation updater bot 02d5f9970e Localisation updates from https://translatewiki.net.
Change-Id: I715446fc0a8051658a259ec8e63c063d89996ec7
2024-03-21 08:59:54 +01:00
jenkins-bot 978702f3be Merge "Revert "The new class should be present alongside the old class for all page views"" 2024-03-20 16:15:18 +00:00
Translation updater bot a337b23c4b Localisation updates from https://translatewiki.net.
Change-Id: Ie22a6d41c35290109454c4d02bbeef4331f627cf
2024-03-20 08:26:12 +01:00
Jdlrobson b6ffc85cd4 Revert "The new class should be present alongside the old class for all page views"
This reverts commit bca9223bb1.

Reason for revert: This is now longer needed following the work
in Ia253de68f94236e7fe2219b736dd6084c64ce838.

Bug: T359983
Change-Id: Ibd3013169f26531a0cd879c143692e7030709808
2024-03-19 23:23:54 +00:00
Moh'd Khier Abualruz 5d6b866890 Rename the skin night mode classes to more readable classes
The classes:
- skin-night-mode-clientpref-0
- skin-night-mode-clientpref-1
- skin-night-mode-clientpref-2
is being replaced with
- skin-theme-clientpref-day
- skin-theme-clientpref-night
- skin-theme-clientpref-os
- Moved $forceNightMode to be a text parameter (dat|night|os)
- Keep adding the old classes to the html element, to give the ability of gradual deployment

The preference is renamed from minerva-night-mode to minerva-theme (a follow up to consider
migrating existing values will follow).

The query string minervanightmode continues to behave the same but now
accepts other values such as day, night and os.

Bug: T359983
Change-Id: Ia253de68f94236e7fe2219b736dd6084c64ce838
2024-03-19 23:12:59 +00:00
Translation updater bot 47e6271479 Localisation updates from https://translatewiki.net.
Change-Id: I8db1bc728a1aba34a6242e895607d83150c20841
2024-03-19 08:27:06 +01:00
Jon Robson bca9223bb1 The new class should be present alongside the old class for all page views
Bug: T359983
Change-Id: Id0bcb3c9b0d37aef84886fe2efb907f8ebd1cfd9
2024-03-18 21:43:44 +00:00
bwang 9c52c298ad Update padding on <p> elements
Bug: T358808
Change-Id: I7f13bddaf79cd9b1061a1cac03e6ab1b767fc808
2024-03-18 19:10:20 +00:00
Translation updater bot ee774e5801 Localisation updates from https://translatewiki.net.
Change-Id: I05cdb2e2f8d3773f47408fffd18e2b9a2a27bfc5
2024-03-18 08:34:02 +01:00
Jan Drewniak 1d379b3baa [refactor] Re-organize CSSCustomProperties.less
Organizes the code in CSSCustomProperties.less into
3 separate groups:
- Forced night-mode,
- auto night-mode
- night-mode helpers.

Also applies `color: var(--color-base)` to both .skin-invert
and .notheme to address situations where color is
defined by inheritance.

Change-Id: I9edc6fd81416f0f40eca975381f61023ac047e47
2024-03-15 23:26:56 +00:00
Steph Toyofuku 4b3abcb1eb [VISUAL CHANGE] Update last modified bar to have an accessible color contrast
The current white text on a green background is not an accessible level
of color contrast.  We were instead recommended to use
@background-color-progressive, so let's do that

In addition, remove the previous definition of
@background-color-last-modified-bar-active as it's no longer being used

Visual change for pages on mobile that have been updated recently

Bug: T358736
Change-Id: If5b97b785e95df75645be62847cef396f6be68b6
2024-03-15 22:28:48 +00:00
Translation updater bot a70bc8fd1c Localisation updates from https://translatewiki.net.
Change-Id: Ie11aeb9ea0e309a7e44e290ce81e84fdea4f30a4
2024-03-15 08:36:13 +01:00
jenkins-bot 4f60bedd16 Merge "Edit Less color functions ADR." 2024-03-14 16:35:47 +00:00
Jan Drewniak b813c44202 Edit Less color functions ADR.
Editing ADR for clarity, fixing a few typos.

Change-Id: Ife38d66c0ddd333eff926744a1c22f54abb7400e
2024-03-14 11:56:48 -04:00
jenkins-bot 0d38488d8e Merge "Fix alignment of icons on Special:Preferences" 2024-03-14 15:48:02 +00:00
Ed Sanders 0b7252092e Fix alignment of icons on Special:Preferences
Bug: T360061
Change-Id: Ib13081472222a5e00674a79673223703d055d4ca
2024-03-13 12:13:50 -07:00
lwatson b91942025b styles: Update color in SVG from #d33 to #d73333
This patch promotes a consistent design decision across projects in
MediaWiki core, extensions, and skins. The darker red color meets the
W3C Web Content Accessibility Guidelines (WCAG) at Level AA that text
or images of text must have a contrast ratio of at least 4.5:1 (or 3:1
for large text).

Bug: T343239
Change-Id: I5c3f0731c76b689d0c985faa21036b8c2fddac20
2024-03-13 15:00:37 -04:00
jenkins-bot f2fc042b7e Merge "Fix Issue with localization of special page titles in exclusion logic" 2024-03-13 14:59:39 +00:00
Jon Robson 06463592b4 Fix Issue with localization of special page titles in exclusion logic
The fixSpecialName function does the opposite of what we want - it takes
a special page and converts it to the local name using getLocalNameFor
Instead of doing that map canonicalTitle to a Title created using the canonical
name.

This requires less computation than localizing every title in the pagetitles array.

Bug: T359958
Change-Id: Ied3ed927202dd9356ebeb7e404230f571a1d910d
2024-03-13 15:33:52 +01:00
Fomafix 3fc7f0d542 Inject service Minerva.SkinOptions into Hooks and MobileFrontendHooks
Change-Id: Id343ae4cb8d1a73cfb647bfe440f2909e3835037
2024-03-12 19:44:53 +00:00
Fomafix b9eca74ff0 Use "optional_services" in skin.json
Change-Id: Idab8a934e4c8f547d018907cb427effcab1d0f3f
2024-03-12 19:44:06 +00:00
jenkins-bot 6d50ae266b Merge "Set color on tables" 2024-03-11 23:33:49 +00:00
jenkins-bot 1f0edffe22 Merge "Fix color for inline styles with background color in night mode" 2024-03-11 23:31:55 +00:00
jenkins-bot 5b9fcf1260 Merge "Move Hooks::setMinervaSkinOptions to class SkinOptions" 2024-03-11 23:15:42 +00:00
Jon Robson d1c4eec649 Set color on tables
Bug: T357998
Change-Id: I602dd9616c5452f5151fdcea729ff7ccac4711aa
2024-03-11 15:59:34 -07:00