Commit graph

4137 commits

Author SHA1 Message Date
Stephen Niedzielski fde1c1084c Doc: move config type and defaults near identity
The readme describes all of Minerva's configs and includes a type and
what the default value is at the end of each section. Since the
descriptions for some configs is lengthy, moving the type and default
next to each config's name gives a consistent location for the
information and allows for quick look up without parsing.

Change-Id: I1583c11c80d9b775d93f59302eb2666b754fb412
2018-06-29 17:55:14 +00:00
Stephen Niedzielski 4bf2156a2e Doc: add debug tips for AB testing
Change-Id: I46eff8ebf5ea10a14b9a203fc5dbe7e37d0f25a1
2018-06-29 17:55:03 +00:00
jenkins-bot f1a1edcd27 Merge "Fix: add login icon as a server render dependency of main menu" 2018-06-29 01:58:08 +00:00
Stephen Niedzielski b60fab3331 Fix: add login icon as a server render dependency of main menu
The profile icon is necessary for logged in users. This is known when
parsing skin.json but was not added in MinervaHooks.php. This patch adds
the dependency unconditionally although it is only needed for the server
render of Special:MobileMenu for logged in users.

Bug: T196893
Change-Id: I2a8485299162c01d28ca1b07e7071ad0c0ef44fc
2018-06-29 00:24:36 +00:00
Jan Drewniak c10c3f011e Increasing specificity of '.center' class
Bug: T193595
Change-Id: Id365952881118bc3587fe8a0c897892e61f41df1
2018-06-28 22:21:05 +02:00
Translation updater bot 66d88028ad Localisation updates from https://translatewiki.net.
Change-Id: I1f9dca74d880e2f5211faf384cde96d6cfe1ffa6
2018-06-28 22:00:51 +02:00
jdlrobson 9164b9154f External link icons should use defaultColor
Depends-On: I0745e112d11026ed59d8daca990b313305cd094a
Bug: T197909
Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-27 21:21:19 +00:00
Translation updater bot ff3ecc6c78 Localisation updates from https://translatewiki.net.
Change-Id: I0b30fd34bd3e6ca8b7c2af221aca24afda789d33
2018-06-27 21:55:08 +02:00
jenkins-bot a64bc6b878 Merge "Allow non-js users to remember login on grade C browsers" 2018-06-26 14:21:38 +00:00
Translation updater bot cfac90453d Localisation updates from https://translatewiki.net.
Change-Id: I2fe032b99048260883616fa8aed1d279db7ca90d
2018-06-25 22:07:07 +02:00
Translation updater bot a6fb499d48 Localisation updates from https://translatewiki.net.
Change-Id: Ib76d5088788b6c54e4363d29ba3addbfa6953694
2018-06-24 22:09:43 +02:00
jenkins-bot 6037e61bc9 Merge "Revert "Suppress display of wikitext editor on action=edit"" 2018-06-22 19:23:37 +00:00
Bartosz Dziewoński 645ffa46f8 Revert "Suppress display of wikitext editor on action=edit"
This reverts commit b8c0e4ff30.

Bug: T196915
Bug: T197834
Change-Id: I875854ab65f8b76929285938d2dbaa996caf3546
2018-06-22 19:11:13 +00:00
jenkins-bot f75590a85b Merge "Update: link icons for standard density displays and CSS" 2018-06-21 22:42:47 +00:00
Stephen Niedzielski 5d938aa9e8 Update: link icons for standard density displays and CSS
The previous lot of link icons look great on high DPI displays but not
as nice as they could on standard resolution displays. According to
Volker, this is because the SVG paths must appear on integer coordinates
and scale up instead of down. The new assets have been designed with
this consideration in mind.

Also, workaround redundant CSS by adding commenting out the "unvaried"
black SVG background-image selector, selectorWithoutVariant.

Bug: T190549
Bug: T197909
Change-Id: Id341d383018a436401541e82cc75d826688eaaae
2018-06-21 17:11:46 -05:00
Translation updater bot bf8f9ab452 Localisation updates from https://translatewiki.net.
Change-Id: Ib871464ec539178f4cf2f392d304c15417a2b957
2018-06-21 22:27:13 +02:00
Translation updater bot 890c525878 Localisation updates from https://translatewiki.net.
Change-Id: Idc278b8ae7afea3768ead707718612908868964f
2018-06-20 22:56:18 +02:00
jdlrobson 903863b7f1 Allow non-js users to remember login on grade C browsers
* Grade C browsers on mobile will now check checkbox
* Grade A browsers will not see it and it will be ticked by default
* On tablet the checkbox will be visible to both grade A and C.

Change-Id: I2c77916097afef8eb6a1b3ea28eb0e50c1dff7f4
Depends-On: I5f646b5c939e498eda9bec249658a969f3f91c5d
Bug: T196947
2018-06-20 11:44:23 -07:00
jenkins-bot efa17f210d Merge "Localise "learn more" and warning icon to issues" 2018-06-20 15:52:42 +00:00
jdlrobson f943abd854 Localise "learn more" and warning icon to issues
This is currently showing up on sisterbox templates e.g.
the one on Category:Beekeeping

Bug: T197728
Change-Id: Idaf4aeb4a9efb668e5c06e19ce1eddace121e741
2018-06-20 08:37:00 -07:00
jenkins-bot d5cd6950b0 Merge "Suppress display of wikitext editor on action=edit" 2018-06-20 09:45:57 +00:00
jenkins-bot 041eaadcb5 Merge "Mobile page issues - visual styling changes" 2018-06-19 22:13:31 +00:00
jdlrobson a231525112 Mobile page issues - visual styling changes
Changes:
* Introduce Jan's beautifully documented $wgMinervaABSamplingRate
Set to 1 to A/B test 50% of the population
* Split out ambox template styles into a separate file referenced
by hacks.less
* Update cleanuptemplates setup script to consider two buckets

Test pages:
* Shqiponja_Partizane
* World_War_II_in_Albania
* Liberation_of_Tirana
* French_Consulate
* Abd_ar-Rahman_IV
* M109_howitzer
* Aimoin
* Transport_in_Brazil
* Transport_in_Cape_Verde

Bug: T191303
Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-06-19 14:11:19 -07:00
jdlrobson 2e7e7d3259 Only render table of contents on pages with a table of contents
Bug: T193517
Change-Id: I0ed0255280f525d7726d2e09ceab15a76e2d6026
2018-06-19 18:18:03 +00:00
Legoktm b56e82c8a8 Revert "Allow type Language for $lang of doEditSectionLink"
This reverts commit 648491015c.

Parent patch is being reverted since it didn't follow the
deprecation policy.

Change-Id: Id0e80bf23593d6fc7c986df7b42ff836cc24d867
2018-06-19 01:35:19 +02:00
jenkins-bot 53741ed02f Merge "Fixing alignment of infoboxes for RTL/LTR" 2018-06-18 20:27:44 +00:00
jenkins-bot 30d1b7fd47 Merge "Add missing return in doEditSectionLink" 2018-06-18 20:22:25 +00:00
Translation updater bot 42acc7a5c5 Localisation updates from https://translatewiki.net.
Change-Id: Ice1a6c3d4d9f6a7a21d0da31d92be3096c34e8a5
2018-06-18 21:55:37 +02:00
Fomafix 72a4f7cf4c Add missing return in doEditSectionLink
Change-Id: If2bfae229c2d12090276a5f8dea00a45746349a6
2018-06-18 21:33:03 +02:00
jenkins-bot 927b1bddd2 Merge "Force type Language for $lang of doEditSectionLink" 2018-06-18 01:14:35 +00:00
eranroz 8ca00225dd Fixing alignment of infoboxes for RTL/LTR
Explicitly set align to left on LTR wikis, and same for RTL wikis.
(tested in en wiki with ?uselang=he and he wiki with ?uselang=en)

Bug: T161399
Change-Id: Ic70acf2c56b52fe52eaac021581617342e3ae74f
2018-06-17 22:14:11 +03:00
Translation updater bot c9586aed40 Localisation updates from https://translatewiki.net.
Change-Id: Icb7aaa2327b616b5748b1b32267985ee644930cc
2018-06-16 22:06:50 +02:00
jenkins-bot 54497c954a Merge "Update: add internal and revise external link icons" 2018-06-15 19:20:27 +00:00
Stephen Niedzielski 3485269be1 Update: add internal and revise external link icons
Bug: T190549
Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-15 12:31:42 -05:00
Fomafix 152f48b846 Force type Language for $lang of doEditSectionLink
wfGetLangObj() is not necessary anymore.

This change increases the requirement to MediaWiki 1.32 or higher.

Depends-On: Id49201957e716ef8a2ea930b3616ca4fe6e35633
Change-Id: I18adeebe476b321546ceda43eb12b6cf7e8081b3
2018-06-14 23:36:39 +00:00
Translation updater bot e7f00c251f Localisation updates from https://translatewiki.net.
Change-Id: Iaf3dfc3d08b164a19e00de56d7040b3c3d9011d8
2018-06-14 22:18:19 +02:00
jenkins-bot df9551bf12 Merge "Allow editor access to the full page's wikitext" 2018-06-14 18:45:56 +00:00
David Lynch b8c0e4ff30 Suppress display of wikitext editor on action=edit
As I6c7e3443756fd72749964d1eda37e3d123b201b3 gives full-page editing on
action=edit, suppress the display of the original wikitext editor so there's
not a flash of a different editor before the overlay appears. Provide a
fallback so that in cases of no-JS the wikitext editor can still be reached.

Bug: T196915
Change-Id: I7dd3de984ead4d70e977e5607bb07606d341db54
2018-06-14 11:57:18 -05:00
jenkins-bot f93f9e7893 Merge "A/B test bucketing wrapper for page issues AB." 2018-06-14 14:59:53 +00:00
Jan Drewniak 7617174d40 A/B test bucketing wrapper for page issues AB.
Provides a class that initiates AB-test bucketing and registers
as a MF module. Activates the reading depth test for users who are bucketed
in either buckets "A" or "B".

Does not add event-logging or visual style changes for page issues AB test.

Bug: T193584
Change-Id: If8504a35059c6d1b056cef063a595b1c2ffd351a
2018-06-13 15:43:08 -07:00
Translation updater bot 7368c68abe Localisation updates from https://translatewiki.net.
Change-Id: I74078ff6929ccebba998feae0695a47cebc45bf7
2018-06-13 22:07:33 +02:00
jenkins-bot cacf03525f Merge "Fix: don't truncate the article title" 2018-06-13 19:04:09 +00:00
Stephen Niedzielski 0b043fbaa7 Fix: don't truncate the article title
Header overflow was truncated in MobileFrontend commit 1655d5233 which
added the language switcher button that appears below the title. This no
longer appears to be required even for articles with lengthy titles.
Perhaps because the language switcher button exceeds the page content
margin, it was thought to be necessary.

Bug: T194544
Change-Id: I4e25e7b03df65803cd553b412881eb565ded9b10
2018-06-13 13:51:44 -05:00
jenkins-bot 1e5d91e1d4 Merge "QA: Stabilise browser tests" 2018-06-13 14:10:30 +00:00
David Lynch 2d930cedbb Allow editor access to the full page's wikitext
Make a new route which uses `#/editor/all` to trigger loading the full page's
text in the editor, rather than defaulting to the first section. This isn't
exposed through the UI, but will be what's used when intercepting action=edit
links, which already loaded the full page's wikitext in the non- overlay
editor.

Bug: T196915
Change-Id: I6c7e3443756fd72749964d1eda37e3d123b201b3
2018-06-12 11:55:37 -05:00
Translation updater bot 4a84008a84 Localisation updates from https://translatewiki.net.
Change-Id: I13491690bf3443b772148a68f1967035abad88bd
2018-06-10 22:04:18 +02:00
Translation updater bot 0972415404 Localisation updates from https://translatewiki.net.
Change-Id: Iafc8ace216d82029c6f056a4751fd0e4852fe10a
2018-06-09 10:00:42 +02:00
jdlrobson 8ad57f9b0e QA: Stabilise browser tests
Changes:
* Default skin is not configured so noticed on test runs it's using
Default skin for desktop mode. Given this has no footer and way to
switch to mobile this could be problematic in future.
* Remove empty README
* Drop suggested language integration test - setting up interwiki links currently
happens via InterwikiLoadPrefix hook however this seems to be unreliable. The beta
cluster is a much more reliable place to test language links so let's rely on that
instead.
* Drop unnecessary heading check from "Successful edit" scenario. It's unnecessary
and flakey (presumably given the title doesn't change)
* Rename test scenario and remove a duplicate scenario

Depends-On: I888b3c546f77fa350853a7bf9bfbfbeb8ed6de67
Change-Id: I45792a95df7fd4c3299accbffadfa447baefe0ce
2018-06-08 19:59:05 +00:00
Translation updater bot f44487d966 Localisation updates from https://translatewiki.net.
Change-Id: Iaf0ca081057af1c691a4edc6d3da674b2d8ea140
2018-06-07 23:22:44 +02:00
jenkins-bot a0dfcf4e75 Merge "Add "center" layout rules based on mediawiki.skinning in core." 2018-06-06 12:33:55 +00:00