Commit graph

231 commits

Author SHA1 Message Date
jdlrobson cf1629aa0d Improve use of whitespace on tablets
1) Remove collapsible heading rule
Introduced for T43401 this no longer seems to be needed
now that we do not support Blackberry's and infoboxes can
be floated within articles and is now creating a reflow

This addresses issues with floating on the United States
and Taiwan page.

2) Allow table's to float in tablet.
Only disable floats on mobile resolutions.

Bug: T193418
Change-Id: I64748e08516e1be4b53af22b6897560b7fc87632
2018-04-30 13:39:03 -07:00
Jan Drewniak 0374ef64a0 Display content beside infobox instead of below.
Removing CSS rules that that push content below infoboxes.

Bug: T189688
Change-Id: I59736720b36f251c49a27a2dd7f5343d58629992
2018-04-30 17:33:08 +00:00
jdlrobson 1f7de003ef Restrict gallery styles to only pages which need it
The mediawiki.page.gallery.styles module is only loaded
when needed, yet inside hacks.less we load gallery
styles unconditionally.

The hacks.less file is also only meant for css that overrides
template styles, so it didn't belong there anyway.

Change-Id: I4afc91ad7f67ae66544708d25541b3e8dd247873
2018-04-13 17:26:46 -07:00
jdlrobson d228b2cbd7 multi-line, two-line and mw-ui-button-group only loaded where needed
The only usage of mw-ui-button is inside the SpecialMobileWatchList
class in MobileFrontend. Thus we needlessly load as
a render blocking CSS on all page views

multi-line and two-line are likewise only used inside
MobileSpecialPageFeed.php

mobile.special.styles is loaded on all Special pages
so let's load this instead here. This also allows us to use
the element on other special pages in future.

Change-Id: I2b363543d0356a18194a9d08922428a6cb944797
2018-04-11 21:50:53 +00:00
Ed Sanders f4658a4d0e Fixes for action=edit page styling
* Use box-sizing:border-box when adding textarea padding - before
the right side of the textarea did not align with the right side of
the bell icon. Now it does.
* Fix specificity of rule hiding cancel link and "editing help" which
appear at the bottom of the form.
* Fix height of noJS textarea (70vh)
* Remove some unnecessary extra margins and padding (the minor edit
and watch this page checkboxes will now show on the same line)
* Update specificity for oo-ui-fieldLayout-body so that it does not
apply to the summary form.

Change-Id: I8d3d61fdc51934a6ef0885cde94dac1e8c5e33ca
2018-04-05 23:13:49 +00:00
jdlrobson 4389b67989 Explicitly use LESS variable for breakpoint defined in mediawiki ui
$wgResourceLoaderLESSVars is deprecated. Let's not use it anymore.

Change-Id: If28ab6884668700bc46533c8e2c377f17e6be696
Depends-On: Ib9f843147db4473ce5590741e0fb490384b0007e
Bug: T171365
2018-02-06 22:23:32 +00:00
jdlrobson 3047f3e0fa Merge remote-tracking branch 'gerrit/master' into specialpages
Change-Id: I1bc48ac546865f515df65e9d7f0c75e7f5c6d684
2018-02-01 11:35:11 -08:00
jdlrobson 4f6e9e69e1 Preferences tabs should be horizontally scrollable
Change-Id: I6766b4ef5a99c66ebb54079b07739315294c86a7
2018-01-31 18:37:16 +00:00
jdlrobson fe3ac29fe7 Merge branch 'master' into 'specialpages'
Change-Id: I167f03477fd79e5ea0c7fa5cdf5df71bb8da31c2
2018-01-19 11:00:55 -08:00
James D. Forrester c7c09daa66 Remove reference to mw-editButtons-pipe-separator, now removed from MW
Change-Id: I59d34dfdd13122db0229ce40909d66d88bdd8d65
2018-01-10 14:30:20 -08:00
jdlrobson 1146cef6b1 Optimise Special:MobileOptions for tablet display
Bug: T180095
Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-05 14:20:11 -08:00
jdlrobson c986db6c0e Always render taglines unconditionally and update styles
Adjust tagline margin per Nirzar:
https://phabricator.wikimedia.org/T180095#3801719

Note, this will  enable the tagline everywhere.

Change-Id: I3bce2a3472ab2e53261965c953572f35cc740eed
Bug: T180095
2017-12-05 00:27:11 +00:00
Volker E 8497d6d259 Unify SVG markup
Align SVG markup across Foundation products by:
- unifying XML declaration,
- adding `width` and `height` attributes where missing,
- removing all unnecessary `g` group elements where applicable,
- putting attributes in order,
- removing unnecessary ids and
- unifying whitespace.

Bug: T178867
Change-Id: I6860c9259553e0e41f7656f9e98534db8e02bbc2
2017-11-14 21:44:40 +00:00
jdlrobson 6df96ca768 Do not center align h2s in footer
In Id9b0e955d6e2a113f91484c7ee6bbc9275e3a2ec the css selector
was weakened and started impacting the footer as well.

This restores the old behaviour.

Bug: T180375
Change-Id: Ibfff6e249a3249ae2ee97d31fd50d2f5272a25ae
2017-11-13 10:49:21 -08:00
jdlrobson 10431c4ed1 Hygiene: Move css rule to Minerva
In preparation for "Adopt new special page template for special pages"
(T169379) move the text alignment rule to Minerva.

Change-Id: I5118a58bcb948c93e511587b8a3f29246b33acd7
2017-11-01 17:06:03 -07:00
James D. Forrester c87cbc7474 build: Organise Gruntfile.js more consistently
This also adds linting for skinStyles, with a few fixes to make these pass.

Change-Id: Id26b0bad21850d985eaaceda24fa50ad6f886458
2017-10-31 14:41:25 -07:00
jdlrobson 5cb46fe9d2 Hygiene: Minerva owns PointerOverlay
The only usage is inside Minerva so we will move this module here.

Change-Id: If6859f0c8f855c6b116b254c58a6814f54b7c36d
2017-10-30 18:00:02 +00:00
jdlrobson 88a0baeb6d Hlist tweaks (size and color)
* Font size should be relative to context
* Only apply linkColor to links in footer

Bug: T169315
Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
2017-10-09 16:40:01 +00:00
jdlrobson 8de58c546e Avoid clashes with MediaWiki:Common.css for hlist rules
Impacts footer and main menu

Bug: T173507
Change-Id: Ie519550c0657c2314ecccaca1d65ecf99d0a3f5f
2017-10-06 15:58:50 -07:00
jdlrobson 734ac36f1e Correct feature phone threshold detection
max-width should actually be one smaller than the threshold

Additional changes:
* Also rename to  @width-breakpoint-mobile and
rename @width-breakpoint-desktop for desktop variable in
anticipation of T171365

Bug: T176286
Change-Id: Ia37bceb46a6b780f473828ff38749543bdfcc9f6
2017-10-04 13:51:19 -07:00
jenkins-bot ef5fddf496 Merge "Show border of editor in Minerva edit mode" 2017-09-05 21:57:06 +00:00
jdlrobson 02d76e9c62 Show border of editor in Minerva edit mode
Bug: T174158
Change-Id: I77f46955cfedc81683481541578c704535a6b034
2017-09-05 21:38:18 +00:00
jdlrobson 91795fa257 Port over minimum required LESS variables from MobileFrontend
From now on Minerva will maintain its own variables outside
MobileFrontend.

Bug: T171016
Change-Id: I05430963cc2fb66b50c063bc8e95621abcbbbea1
2017-09-05 21:20:56 +00:00
jdlrobson 79fd8bd799 Hygiene: Remove FIXMEs now enough time has passed
Routine maintenance - all FIXME statements suggest these can
be removed. W00t!

Depends-On: Iee059a6605cf12a073954378f49ddc721a7e016a
Change-Id: I645dca1fa4d9e80d506e907b0be78a5aef0e2f12
2017-08-29 19:26:13 +00:00
jenkins-bot 7c1be417b0 Merge "Remove special page resource module handling" 2017-08-28 16:21:52 +00:00
Volker E a75c7fd257 Align SVGs to color palette and optimize
Aligning remaining SVGs to WikimediaUI color palette.
Also:
 - Aligning markup to each other, among others adding XML declaration
   throughout or removing unnecessary `standalone=no` attribute.
 - Optimizing with SVGO without prettified markup. Savings of up to
   17% of file size.

Bug: T146799
Bug: T172850
Change-Id: I54a21932fd5df64b7716ac66a90de5af73776c23
2017-08-25 12:55:37 -07:00
jdlrobson c17f387260 Make sure referenced file exists
Change-Id: I9fd767646f1b02cf9ca0865a0d7ed9823929f839
2017-08-21 17:05:09 -05:00
jdlrobson 61ba76efdb Remove special page resource module handling
This is handled by MobileFrontend now, just as it should do.
We rely on skinStyles where possible.

Depends-On: I665f6fe60939475249786fdc951149c38473fda6
Bug: T173597
Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 19:37:08 +00:00
jdlrobson 8b823b080a Give the Special:preferences page on desktop some love
The preferences page is accessible if a user opts into the Minerva
desktop experience. It's not a great first experience.

These changes make the page usable.

* Provide styling for tabs
* Provide padding/borders for unstyled button elements

Change-Id: I107ed3c685910a5e9502b25d22ef7cc489ce3c34
2017-08-18 17:48:04 +00:00
jdlrobson 747b712509 Minerva should use mediawiki.hlist
Override provided styles

Bug: T42062
Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028
Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-07-19 13:52:09 -07:00
jdlrobson 2cc9516cde Minerva is its own skin
This is programmatic output from python3 scripts/migrate.py

This will result in a Minerva skin dependent on MobileFrontend.

Post merge we will rename message keys to have minerva- prefix

Bug: T166748
Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 08:12:40 -07:00