Commit graph

3261 commits

Author SHA1 Message Date
Thiemo Kreuz 29b682fc09 Prefer UserIdentity interface methods over User where possible
isRegistered() is a method in the much more narrow UserIdentity
interface. This change makes it easier to move code away from the
problematic User "god" class in core.

Change-Id: I99cb72591f073568f84bd1fd436381f3f11f3140
2021-12-17 16:57:44 +00:00
Thiemo Kreuz 73c79aeb68 Remove unused class property initialization
It's guaranteed to be initialized in the constructor.

Change-Id: I7c39e5ca3a80b8f9279bdecc3a724f39d1f987e3
2021-12-17 11:31:44 +01:00
Thiemo Kreuz bb31754073 Use PHPUnit shortcuts where possible
This makes the tests a little easier to read, I would argue.
any() is the default anyway. It doesn't add new information to the
test.

Change-Id: If4655ddea494f1054538a760802b583e17c0108e
2021-12-17 11:29:48 +01:00
Thiemo Kreuz e565347cd4 Remove some comments that literally repeat the code
Change-Id: I3960735fa59f7d607659acd31167802ee769a519
2021-12-17 11:29:11 +01:00
Translation updater bot 1cf3de024f Localisation updates from https://translatewiki.net.
Change-Id: I37ef6573c75af9a6a9d17a47381bbc3c3dca6e84
2021-12-17 08:19:02 +01:00
Translation updater bot 5e7557ec80 Localisation updates from https://translatewiki.net.
Change-Id: Ia014953f6857b2f310453d171b02af22589982ef
2021-12-16 08:32:26 +01:00
jenkins-bot 1b9d92e17d Merge "Wrap the sitenotice with div element as other skins do" 2021-12-15 21:35:58 +00:00
jenkins-bot 5e7d835627 Merge "Add composer test:size as shortcut bundle size test" 2021-12-15 09:34:17 +00:00
jdlrobson 3e0d20e34f Donate link is disabled by default for 3rd parties
Bug: T191743
Change-Id: I2b57cd3fa270fab1385319f2cbd33e886ae33843
2021-12-14 22:23:43 +00:00
Translation updater bot acce7d63e7 Localisation updates from https://translatewiki.net.
Change-Id: I36d9b399fadf9176fbcf24c8cbb8a598ace059a7
2021-12-14 08:44:19 +01:00
Kosta Harlan c245636767 Add composer test:size as shortcut bundle size test
Change-Id: I3a1f246c57f3021659c23299e151389c0ae77f87
2021-12-13 11:46:47 -08:00
Translation updater bot 04757f0753 Localisation updates from https://translatewiki.net.
Change-Id: Ie54f5c1b31aadcefe871a5f53cf04a45e7d7b3a1
2021-12-13 08:24:26 +01:00
jenkins-bot 18380d21df Merge "Move bundlesize test to MediaWikiIntegration test" 2021-12-10 19:52:00 +00:00
Func b4b2f4ded3 Wrap the sitenotice with div element as other skins do
Change-Id: Ifea461636f9000527556dc2881f83f00be5bff76
2021-12-10 11:20:35 +00:00
Kosta Harlan d8c505c73a Move bundlesize test to MediaWikiIntegration test
Depends-On: Ieb7591f3c0ac843677a2a61b4ad47f920fc2ca2d
Bug: T255149
Change-Id: I311793952e995715010dc70069e1056165a1cd90
2021-12-10 08:43:51 +01:00
Translation updater bot 4f7a3c22ad Localisation updates from https://translatewiki.net.
Change-Id: Ieb3bf79a9e9aa5dbd123081f5bcffeeabc1e033a
2021-12-10 08:27:43 +01:00
Translation updater bot f864ac4918 Localisation updates from https://translatewiki.net.
Change-Id: I8129628cbdf8d4f6c4c175c1309963c8c31f219e
2021-12-09 08:24:43 +01:00
Translation updater bot 949c817bf2 Localisation updates from https://translatewiki.net.
Change-Id: I3c862934e31f7d57ab27f7d5faaf993ecc47e817
2021-12-07 08:13:46 +01:00
jenkins-bot 35eb71cbde Merge "Fix viewport overflow in RC/Watchlist editsummaries" 2021-12-06 22:42:33 +00:00
Derk-Jan Hartman a0bb9e41ee Fix viewport overflow in RC/Watchlist editsummaries
Set a max-width on this floated element

Bug: T297045
Change-Id: Ie33d7052eb1138cb98543c53410c1f376f3e0e64
2021-12-06 22:22:22 +00:00
jenkins-bot b85d073178 Merge "ServiceWiring: Add fallback for when title is null" 2021-12-06 20:01:54 +00:00
Kosta Harlan ed22536b44 ServiceWiring: Add fallback for when title is null
Services shouldn't rely on global state. The service should have a
method for setting the title manually, and callers to the service should
be updated to pass in the title (or other context items) as needed. As
is, this code causes the test for MediaWikiServicesTest.php to fail; it
appears to only pass in CI accidentally due to pollution of global state
from other tests that run before it.

Bug: T297068
Change-Id: I39c780d36583deb8b2edd7b12b425e949bd09cd1
2021-12-06 09:38:36 +01:00
Translation updater bot c206d213d9 Localisation updates from https://translatewiki.net.
Change-Id: I5853f54dea6a4350821d32ac87627500dcd27fb5
2021-12-06 08:22:16 +01:00
Volker E 9c38f7ec82 drawers: Remove outdated supported browser property
IE9 on Windows Phone workarounds are of no use any more.
The `right: 0` and `left: 0` properties below are sufficient in
currently supported browsers.

Change-Id: Ibfb29d1b009cb0ea33bc3cb9be39ee579e981b1a
2021-12-02 13:47:08 -08:00
Translation updater bot 987cd03cbb Localisation updates from https://translatewiki.net.
Change-Id: Ie2cc0ddfe7e592115715fb9923a6c126c8e41ea2
2021-12-02 08:44:28 +01:00
Translation updater bot 66d0de9bd4 Localisation updates from https://translatewiki.net.
Change-Id: I2d72db2cb2e4955d33bc6b478cda3957a0bf3150
2021-12-01 08:16:54 +01:00
vladshapik 023c5046d3 Avoid using User::getOption
Remove using of User:getOption since this method
will be hard-deprecated. Now it is soft-deprecated.

Bug: T296083
Change-Id: I9f762cf27d7c778c8c391cde1409b510bd3e4e67
2021-11-30 12:54:03 +01:00
Translation updater bot 484ced3bb6 Localisation updates from https://translatewiki.net.
Change-Id: Ida3ae9136ab4dbe0b4efa17fb0a6cf98d81eb120
2021-11-30 08:24:02 +01:00
jenkins-bot f4b3b11053 Merge "Fix history link" 2021-11-29 23:36:42 +00:00
Clare Ming 11b703f616 Fix history link
- Show history link for view pages only.

Bug: T295772
Change-Id: I01b4aa6975543fbfe015ff9cd439f82b5baf3e5b
2021-11-29 13:34:09 -07:00
jdlrobson 76a12a2ad4 Restore logo to footer
In 894364a3eb we moved the section tag for data-logos outside Logo
but did not add it to the footer

Bug: T295773
Change-Id: I52c07e95ac8166e9e9d11aba7cb3130cc6a2f8d7
2021-11-29 10:59:23 -08:00
Translation updater bot 985248d973 Localisation updates from https://translatewiki.net.
Change-Id: I7b1a1ad835eabf9469471ee6a3c3819c62d71267
2021-11-29 08:14:29 +01:00
Translation updater bot 98f2b02514 Localisation updates from https://translatewiki.net.
Change-Id: I787b44c9ea4a4ba374605fab2491f15b3623ec77
2021-11-26 08:25:36 +01:00
Translation updater bot 298cae9b7f Localisation updates from https://translatewiki.net.
Change-Id: I0ab6a021550341c139f17d5f3aed61f0f1aa166f
2021-11-25 09:04:23 +01:00
jenkins-bot 05244d905b Merge "Remove markup icon code" 2021-11-24 20:21:51 +00:00
jenkins-bot 7122261c30 Merge "Update sandbox icon in personal menu" 2021-11-24 19:31:19 +00:00
Translation updater bot 61ba1386ed Localisation updates from https://translatewiki.net.
Change-Id: Ie5e3d74229b565975017d4604c587d6e4e1b9fb2
2021-11-24 08:24:34 +01:00
bwang 083ab9c6c3 Remove markup icon code
Bug: T288928
Depends-on: I553bbcc9f1a98d75e160ede7a66ffcf6510fa28a
Change-Id: Ida0c41d2dab229e882c5e78e5702cc921bbdb928
2021-11-23 17:26:37 +00:00
bwang ceb7961c75 Update sandbox icon in personal menu
Bug: T288928
Change-Id: Ia4ddeefb43ad089832532d68c7c48cd021ecb14e
2021-11-23 11:18:56 -06:00
jenkins-bot a174538d21 Merge "Replace usage of the methods IContextSource::getWikiPage & canUseWikiPage that will be deprecated to WikiPageFactory usage" 2021-11-23 14:04:55 +00:00
Roman Stolar a0e560ffe6 Replace usage of the methods IContextSource::getWikiPage & canUseWikiPage that will be deprecated to WikiPageFactory usage
Bug: T275710
Change-Id: Ia5cff18a6d9417d8e6960f2d20f7b41174f97341
2021-11-22 12:50:11 +02:00
Translation updater bot a47ea65e07 Localisation updates from https://translatewiki.net.
Change-Id: Ie58a602b89d51c413cfcc7850b5b77c017195f7e
2021-11-22 09:05:45 +01:00
tacsipacsi aaf0159174 Don’t add any <h1> to main pages for anons
Main pages usually feature a welcome message on their own, and adding
the standard <h1> is redundant at best. (Or, if there’s no welcome
message, the lack of a page title also indicates that it’s the main
page.) Also, it has ever been the case since dd00aa5a601e that no page
title is visible on the main page (before 9a39d1e492, an empty <h1>
was present, now nothing will be added).

Bug: T296109
Change-Id: I1e79dc385c4dbe8413bcb32a52b8675aabf8eea0
2021-11-20 12:57:57 +01:00
jenkins-bot 88ff252e77 Merge "Fix banners to show CentralNotice" 2021-11-19 18:02:52 +00:00
Clare Ming dddde1c208 Fix banners to show CentralNotice
- Restore init of banner array to include needed selector.

Bug: T296077
Change-Id: Id1cec46eadcd057062c791a30db8ca40b35224b9
2021-11-19 10:17:12 -07:00
jenkins-bot daef42b91e Merge "Remove primary/secondary menu items, instead add a separate log out menu item" 2021-11-19 17:13:10 +00:00
Translation updater bot 79fc729e8c Localisation updates from https://translatewiki.net.
Change-Id: I9eab98c69e8a1b2e29f6bf46cd87874ff9b61773
2021-11-19 08:31:16 +01:00
bwang ef4aa95ae2 Remove primary/secondary menu items, instead add a separate log out menu item
Bug: T293041
Change-Id: I9f73fdba1856dd9e0ea7120df0fb18061337961a
2021-11-18 19:51:33 +00:00
Translation updater bot 7af2df060f Localisation updates from https://translatewiki.net.
Change-Id: I6b66bcc6dcc1d27b820e3d8360a66fe419218c9a
2021-11-18 08:44:01 +01:00
Translation updater bot d6753edfe8 Localisation updates from https://translatewiki.net.
Change-Id: I7e088ff14dc7a299a81390b8a89eaef7f5b88213
2021-11-17 08:32:22 +01:00