Commit graph

3041 commits

Author SHA1 Message Date
Jdlrobson e8b964a341 Partial revert "Fix spacing between icon + text in main menu"
This reverts commit b308c91b50.

Reason for revert: Partial revert. CSS is no longer needed
with I2dbc88331c1a43441f4944cba9b0a51ad41d0025

Bug: T292452
Change-Id: Ida335774231eb66d56cde6baa5da0745fbb982d3
2021-11-08 23:39:42 +00:00
jenkins-bot 5f42f3f76a Merge "Instrument mobile talk page clicks" 2021-11-08 19:20:56 +00:00
jenkins-bot 07de60509a Merge "Add move, delete, and protect options on mobile AMC user page" 2021-11-08 17:59:22 +00:00
jdlrobson 1acb3542a5 Instrument mobile talk page clicks
This results in log events for clicking the following on a talk page:
* Read as wiki page
* Section headings
* the "add section" button

To test install WikimediaEvents and set
$wgWMEMobileWebUIActionsTracking = 1;

Bug: T294738
Change-Id: I8dbad7f4e72cfd081896480ba142b4e1e3029bcd
2021-11-08 09:17:29 -08:00
jenkins-bot 862335c764 Merge "Refactor Minerva header and overlay headers to use flexbox" 2021-11-08 17:07:34 +00:00
Translation updater bot 68f0bd65dc Localisation updates from https://translatewiki.net.
Change-Id: I9dcbf74b6a45ab164bd6dca0813541577f2906f3
2021-11-08 08:19:00 +01:00
xiplus ef22a69a28 Use the message "portal" as the label for the "portal-url" link
At this time, the label is the same as "portal-url". It's not allow
to localize. Use "portal" as the label.
The code is copied from insertDisclaimersItem() in the same file.

Bug: T239022
Change-Id: I1d3bc04333aabcf8c704241ca882d6b863b98968
2021-11-08 14:53:50 +08:00
xiplus 9a39d1e492 Fix empty title for logged-out users using Minerva skin
Do not set page title to empty string if user is logged out

Bug: T265892
Change-Id: I38172860a6e4b58f772cc6713a0fd07f5d8524ea
2021-11-08 12:17:24 +08:00
Gagah Pangeran Rosfatiputra 00b06825c8
Add move, delete, and protect options on mobile AMC user page
Turns out user page is using UserNamespaceOverflowBuilder instead of
DefaultOverflowBuilder.

This change is added move, delete, and protect entries to
UserNamespaceOverflowBuilder::getGroup, so those options would appear in
overflow menu on user page.

Bug: T283549
Change-Id: I8a22b57aaa195773ae9e82bd1e01f323a2c0e6e1
2021-11-06 09:59:42 +07:00
bwang 03387718cf Clean up MobileFrontend overlay skin styles
Bug: T294033
Depends-on: Ibd4ef00615a1119601c729f2481ff87adaf8c86c
Change-Id: Id1c07205aec59481cc14ddb39c441fafa256e46b
2021-11-04 20:50:49 +00:00
bwang f1c828e19d Refactor Minerva header and overlay headers to use flexbox
- Move new header styles to header.less
- Remove unnecessary styles
- Update search overlay to be aligned with the heading searchbox on all screen sizes
- Add temporary skin style to ensure no regressions in mobile VE

Bug: T294033
Change-Id: Ib9867d1b76b602f3355e9f2689f137bc84b0c929
2021-11-04 15:50:00 -05:00
Gagah Pangeran Rosfatiputra 215364be3a
Change disclaimer link container to flex box
With this change, long disclaimer links can be wrapped into new line
instead of clipped in single line.

Bug: T282314
Change-Id: I6a4fc4f62a9e593aa990de5d578059facb9b87d9
2021-11-04 20:07:58 +07:00
jdlrobson 1f2b7dff15 Minerva uses desktop footer for license
After this change, in desktop Minerva the copyright
text in the footer should match desktop Minerva.

In mobile Minerva the copyright text in the footer
is shortened and doesn't contain terms of use.
It should match Vector mobile
?useskin=vector&useformat=mobile

Depends-On: I3473908e08f643b4c60aafc470dd124516955323
Change-Id: I2895975aaa1d09d228f80aff74381e88034a0137
Bug: T289401
2021-11-03 18:38:44 +00:00
jenkins-bot de81ac6c03 Merge "Removed calls to MinervaPreRender hook." 2021-11-03 17:17:49 +00:00
Sai Suman Cherukuwada 3a9f60cbeb Removed calls to MinervaPreRender hook.
Bug: T289281
Change-Id: Ied0d2069dd8bb6bad67233272365674840743062
2021-11-03 16:45:23 +00:00
Translation updater bot 12c452e444 Localisation updates from https://translatewiki.net.
Change-Id: Ie14f5eba012ac013cff825fdc123085105e5c824
2021-11-03 08:22:59 +01:00
Translation updater bot c40f3e1922 Localisation updates from https://translatewiki.net.
Change-Id: I8ead237a605bf83197ad686e13008e33a5651b30
2021-11-02 08:08:55 +01:00
jenkins-bot 742be56e60 Merge "Fix spacing between icon + text in main menu" 2021-11-02 01:19:41 +00:00
jenkins-bot ccf468ee1b Merge "Fix last modified bar icon change and search unStar-progressive" 2021-11-01 23:10:31 +00:00
Clare Ming b308c91b50 Fix spacing between icon + text in main menu
Bug: T292452
Change-Id: Idc603ccaeeb42f60899059ebb51226e8a20a969d
2021-11-01 16:33:07 -06:00
jdlrobson d4039f9240 Fix last modified bar icon change and search unStar-progressive
In b4fd1498bc we set a variant, which dropped the default global
progressive and invert variants. This is turn, made the mobile
watchstar on search disappear when selected.

Here we restore those icon variants, and take the time to refactor
the code so its more resilient against future icon changes.

Change-Id: I1423fbf69dce87715c159877b5f536b4e8e13390
2021-11-01 22:27:43 +00:00
jenkins-bot 53bab77280 Merge "Move history link data into SkinMinerva::getTemplateData and relevant template" 2021-11-01 21:45:19 +00:00
Clare Ming 55189058be Move history link data into SkinMinerva::getTemplateData and relevant template
- Remove usage/references to MinervaTemplate::getHistoryLinkHtml, html-minerva-lastmodified
- Add data key for history.mustache template.
- Update footer template to use new data key.

Bug: T292554
Change-Id: Id5fbf61ba181a0088a25e77175b808362963c63b
2021-11-01 21:04:12 +00:00
Translation updater bot b69da4c681 Localisation updates from https://translatewiki.net.
Change-Id: I43678e58d53888e595960141be589b2785ee2be7
2021-11-01 09:36:45 +01:00
jenkins-bot 8927d37375 Merge "Remove custom styling from 'Add discussion' button" 2021-10-29 18:06:20 +00:00
Translation updater bot 08abf854f9 Localisation updates from https://translatewiki.net.
Change-Id: I03448cef0fbe80f273463cbd4fd0a6bc41378c1e
2021-10-29 08:24:01 +02:00
bwang 50a5253684 Remove whitespace from anon talk message warning
Bug: T284642
Change-Id: I65d03ffa5b3e8a7a855ba5adb3cc90e74c83ad96
2021-10-28 18:11:26 +00:00
Translation updater bot b3e110ff04 Localisation updates from https://translatewiki.net.
Change-Id: Iae79f60da348773f72fb54ecdc4d4a9faa30d245
2021-10-28 08:31:45 +02:00
jenkins-bot b4f947a625 Merge "Update anon talk messages to show on non-main namespaces" 2021-10-27 23:52:19 +00:00
bwang a2d065c062 Update anon talk messages to show on non-main namespaces
- Loads messageBox styles on non-main namespaces
- Add messageBox styles to 'skins.minerva.scripts' module for MobileFrontend's edit overlay page
- Prevent warning box from showing with empty message

Bug: T284642
Change-Id: I70d0d86671384210cc3ab43cb1d350ff2a862fd9
2021-10-27 21:29:42 +00:00
jenkins-bot 2ee31b0096 Merge "Refactor SkinMinerva::getSecondaryActions to match getPageActions()" 2021-10-26 22:49:16 +00:00
Ed Sanders bddfd1d232 Remove custom styling from 'Add discussion' button
These styles conflict with the new max-width on mw-ui-button so
don't behave as they were originally intended.

Bug: T294286
Change-Id: I9a55fb28d422ebf45ec84d399ae05be54a117df5
2021-10-26 23:33:01 +01:00
bwang 2be42b314f Refactor SkinMinerva::getSecondaryActions to match getPageActions()
Change-Id: Ia87fb08204be56e665cd97c57e6ac7df4cb1a02d
2021-10-26 22:24:04 +00:00
jenkins-bot ce6802b4b6 Merge "Restrict overlay button styles to non icon buttons" 2021-10-26 17:06:21 +00:00
jenkins-bot 36729aafd8 Merge "Add yellow talk page message warning to non-main namespace pages" 2021-10-26 16:39:38 +00:00
jenkins-bot 0ca31231fe Merge "Inline PageActionsMenu template" 2021-10-26 16:34:25 +00:00
bwang b4fd1498bc Add yellow talk page message warning to non-main namespace pages
Bug: T284642
Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-26 10:44:28 -05:00
Translation updater bot d2ad7f133a Localisation updates from https://translatewiki.net.
Change-Id: I6f2ff429530abdea0e3e2dd29f17466d1e6b274d
2021-10-26 08:20:16 +02:00
jdlrobson b41c7ca7be Inline PageActionsMenu template
Avoid usage of an additional TemplateParser

Bug: T293813
Change-Id: I1cef873d8a3226c9180a0731834f0ecf961f7ece
2021-10-25 16:02:08 -07:00
jenkins-bot 2a60efef79 Merge "Remove MinervaTemplate::getSecondaryActions" 2021-10-25 19:32:53 +00:00
Translation updater bot 6b3ec0458e Localisation updates from https://translatewiki.net.
Change-Id: I99eb2f1a43c98a1a6839e9a6a95706da1e7d73d0
2021-10-25 08:55:44 +02:00
bwang 95abf6b9af Remove MinervaTemplate::getSecondaryActions
Bug: T291875
Change-Id: Iefff2007c561adfd5886f9c0521341b3922e7653
2021-10-22 14:11:54 -05:00
bwang d1049e5407 Restrict overlay button styles to non icon buttons
Bug: T294146
Change-Id: I5f5568407dda5f3a021d64de9efc2bc7aeb5b458
2021-10-22 18:48:26 +00:00
jdlrobson 17968826fa Move components files up one level into Skins directory
Follow up to I4c2e115451c0a76c742734730712814c1f1d838d.
This will allow us to load the templates directly into skin.mustache
via {{>PartialName}}

Templates partials can only be resolved relative to the folder given
to the TemplateParser.

Change-Id: I5783d49c25d2efcf4781dd912500bf8b413b8cb6
2021-10-22 18:45:38 +00:00
jenkins-bot 9b5e07d647 Merge "Remove getPageActionsHtml and related methods" 2021-10-22 18:20:21 +00:00
jdlrobson c407d92d5d Remove getPageActionsHtml and related methods
Bug: T293813
Change-Id: I90e45cac13a13c2ce18af16274e327d951868433
2021-10-22 07:42:56 -07:00
Translation updater bot f33f413e57 Localisation updates from https://translatewiki.net.
Change-Id: Ia0450299f43c2f208e0fa896d69ea424efac34c1
2021-10-22 08:16:42 +02:00
jdlrobson 5a7a9c9c31 Drop wgMinervaPageActions
Remove code per spike outcome (T226490#7438685)

- This configuration option is never used in Wikimedia production
- isTalkAllowed content body is merged into isAllowed. Resulting code
is more readable.
- isAllowed('talk') still returns false on main page for anonymous users
which is the current behavior. Even on sv.m.wikipedia.org where talk pages
are shown to anonymous users, we do not show the talk page on the main page.
Add a comment pointing to the associated phabricator ticket

Bug: T226490
Change-Id: I9f34817c5ad654a6a66fe6156850a3e3fee881a7
2021-10-21 17:25:37 +00:00
Jdlrobson d138fa5cdb Merge "Restore title to mobile skin without logo" 2021-10-21 16:22:40 +00:00
jenkins-bot 818ded15a0 Merge "Move skins.minerva.content.styles into skins.minerva.base.styles" 2021-10-21 16:00:13 +00:00