Retain the existing font,
margin and padding values as without
these we would trigger a visual regression.
Visual change: Four minor visual regression with this change
relating to the button in the AMC CTA Drawer and suggested
edits overlay heading. All are acceptable.
Bug: T205341
Change-Id: I6331d88e5b7301fd13249414350a539738cfae53
All colors used in Minerva are converted from Less variables
into CSS custom properties. A new file called CSSCustomProperties.less
is created in the skins.minerva.base.styles module to store
these custom properties and an ADR is provided on the rationale for
dropping support for browsers that don't support custom properties.
The new CSS custom properties follow Codex design token conventions
where possible (and noted when not).
Link colors are unique because their styles are defined in core,
so in that case the Less variables values are set to custom properties.
Those values are then fed back into MediaWiki core for core link
styling.
Also adds a temporary night-mode color palette under the
.skin-nightmode-1 class on the <html> element.
Bug: T356074
Change-Id: Ida1f14138f12bd3c600c264bde7b5100f9dbf4ff
Converts all Less variable names from CamelCase to snake-case
per the MediaWiki coding conventions.
Removes the following unused Less variables, mostly
related to icons, since those were converted to Codex:
- @icon-touch-area-sm
- @icon-touch-area-md
- @min-size-icon (replaced with @size-icon-medium)
- @icon-glyph-size-sm
- @icon-size-sm
- @icon-padding-sm
- @icon-glyph-size-md
- @icon-size-md
- @margin-icon-md-labelled
Bug: T350581
Change-Id: I1b16e77942d9bea20dcc5636a63d64aa2325a173
To test you must be using desktop Minerva
This addresses only the problem described in
T353062#9438627.
Bug: T353062
Change-Id: Ia7053b94aae1b6ab48307769de063d825a47c1db
This omitted the important overflow and text-overflow
rules that we use in MobileFrontend. The line height also
needs a slight adjustment.
Bug: T354218
Change-Id: I4b8dee3395603933aba2818725b1f8fbbde0a2a6
The visual diff is sometimes cluttered at narrow widths, but as
we show the switcher on tablet and desktop, and it stores a preference,
users may see the visual diff on phones anyway.
The layout is sometimes cluttered but not completely useless, and
users can always switch back.
As a follow-up we should improve the layout of the visual diff sidebar
on narrow screens.
Bug: T351946
Change-Id: I5533126195331b46040e708b7b35627e74a3001d
Mobile page doesn't traditionally show the full revision under
the diff. If we want to continue to do this it would be better
to find a solution on the server then resort to this CSS hack.
Bug: T350454
Bug: T350650
Change-Id: Ic26c577ca4bcf8793f8678e30d91b0315da4df99
The mediawiki.diff.styles can be loaded on pages other than the diff
page itself, so it is better to move this logic into SkinMinerva and
avoid outputting it for diff pages full stop.
Note this module is loaded on Special:MobileDiff and desktop
Minerva history page (without redirect) so we need to cater
for both cases.
Bug: T350515
Change-Id: If2d908b7cbe257184e0c899f78a04d4d5935ea8c
All other occurrences in this stylesheet already use the new token.
Seems like this one was missed.
Bug: T331403
Change-Id: I1d385275bd2b679d130eb3180ef2fc63a0f37a6b
Please see T338261#9291438 for a longer explanation. The .mw-editTools
section is a multi-purpose field that can hold a lot of different
things, most notably a special characters toolbar. It's confusing if
the toolbar looks like it's disabled.
Bug: T338261
Change-Id: I6ad58dbdcc754c832e03184c2e69a7803c333c07
At least for wikis that have AdvancedSearch installed it does not
seem to make sense to hide the interface. It should be usefull in
any case. Also there's a huge gap that should be avoided I guess.
I'm not to sure for cases where AdvancedSearch is not installed.
There this patch will lead to a situation where there are two
search fields visible. The one at the top and the one in the main
content. - Although the latter has the advantage to show the
current search term.
IMO this is overall still an improvement and further streamlining
could be done in a follow up ( like hiding the header search field
generally on the Special:Search page ).
Bug: T308845
Change-Id: I477825e9d738e9934f6c6845a1ff8962f12987a9
Additional change:
* Remove unused import on mediawiki.special.changeslist module
* Increase touch area of undo link for mobile devices
Bug: T345768
Change-Id: I8ded245cf15ca58f91ca1b71beffd91da02cfd92
- Removes 'mw-ui-icon-with-label-desktop' as that is now the default behavior for icon only buttons in Minerva
- Removes icon flushing classes, use codex mixins instead
80 Visual changes relating to minor icon/button subpixel changes in the heading, edit section links, and page actions
Bug: T319260
Change-Id: I503b643d33e43196483af4b5f9dd312237322ac8
Use the Button.mustache partial in the
PageActionsMenu.mustache template.
This converts the page actions menu to use the Button
template in a way that doesn't change the existing HTML.
The mw-ui-icon-element and mw-ui-icon-with-label-desktop
classes are placed onto the Button.mustache markup.
Bug: T342908
Change-Id: Ib5dadd929eea2e72a24e061c4174348615890617
Changes
* Update FIXME in userMenu.less to merge selectors
* We replace minerva-user-notifications class with minerva-notifications
to short-circuit Echo's code so that it no longer replaces the Minerva
notification badge with its own.
* We update resources/skins.minerva.scripts/initMobile.js to introduce
our own wire up code - this is responsible for opening Echo overlay
and reseting the counter. The code in Echo will be removed in a follow
up (see <I2f923e509d24524a2375ffbe6b3ef336487574bb>)
* We update skinStyles/ext.echo.styles.badge.less with styles from Vector 2022
so that Minerva desktop remains consistent with desktop Vector 2022 experience.
* We clearly mark technical debt relating to the special mobile version.
Testing:
* Pixel.js has a group echo that covers all the different variants.
Make sure to update to latest main branch before running these.
* Desktop should behave the same for Minerva as Echo.
* On mobile only when a user has unseen notifications a red circle
is shown. Otherwise a bell icon is shown, never with number.
* On mobile a single button is visible that combines alert and count
numbers.
* With Echo disabled a bell shows that links to the user talk page
Visual changes:
* Previously the red circle became a transparent/gray circle on click. Now
it will always be red.
* Minor aligment changes to red circle and bell icon are expected as
the change prevents MobileFrontend/Echo updating the icon to use
Codex.
Bug: T342907
Change-Id: I55c18cf723a32f80b93a01dd0687e005162c4e93
Previously the rule .mw-ui-icon + span:not(:empty)
provided the margin (see mediawiki ui skinStyle) - with the refactor
of the spinner this no longer works
Follow up to I186e3d22aa9c2b331a80d35514d578949a4b9e86
Bug: T340262
Change-Id: I92446d361da9a84e27f81d9ff8d5053d96ead61c
Some of the other styles in this file should probably also be revisited, but that is out of scope for the task.
Bug: T285398
Bug: T341360
Change-Id: I80d915d2aedc57bcb634816d761d09853cd3b715
This reverts commit 52273510fe.
Reason for revert: Web team is trying to limit the amount of differences between Minerva and Vector codebases, using shared styles
in core where-ever possible. Since this rule is already defined in core, we should load it from there. This requires a slight change to
the loading mechanism, which I've marked as a dependency.
Change-Id: Id31a6b24bdd4f745e194d77cf7b97faf6ae7e6de
Depends-On: I11c54b58873523f7b72cca67b82efdd681562508
