Commit graph

256 commits

Author SHA1 Message Date
Jon Robson 7187ce5594 Move skinStyle from Echo to Minerva
Bug: T257143
Change-Id: I1999185d19e171900f2da5acbd39125013d3582c
2022-11-19 00:24:08 +00:00
jenkins-bot 27965530c3 Merge "Media border option applies to the media element, not the wrapper" 2022-11-02 23:02:22 +00:00
Jon Robson 5be882421d Disable new flushing rules on mobile
Don't have capacity to deal with this yet.

Follow up to  I9aba71ac4fff0d285676946acef8309b741ed1ad

Bug: T321504
Change-Id: I85ece1fa28d2c1c5967995ef7622684d73d3c23f
2022-11-02 12:28:49 -07:00
Arlo Breault b1d39a5425 Media border option applies to the media element, not the wrapper
Reported in,
https://it.wikipedia.org/w/index.php?title=Wikipedia%3ABar%2FDiscussioni%2FAggiornamento_del_parser_per_le_immagini%3A_vogliamo_testarlo%3F&type=revision&diff=130240855&oldid=130214646

The default styling in core looks like,

.mw-image-border {
	> a:first-child,
	> span:first-child {
		> *:first-child:not( .mw-broken-media ) {
			border: @border-thumbborder-screen;
		}
	}
}

The simplification here recognizes that the border option doesn't apply
to thumbs, so descendent selectors can be dispensed with, there's no
nesting in figcaptions to worry about.  That's important because
lazy-loading adds a noscript before the img tag, which would make the
selectors with first-child not apply anyways.

An img tag is used instead of the universal selector.  That seems like a
safe assumption for now and can be revisited with T314097 / T318433

Bug: T318300
Change-Id: I25f45ee794300d2ba2a38a0ab6e3741a6b1a18f2
2022-11-02 12:34:00 -04:00
jenkins-bot 2545c6b2d0 Merge "Add styling for Special:Preferences icons" 2022-10-28 16:59:28 +00:00
suecarmol 822bf0f0c3 Add styling for Special:Preferences icons
Added styles for Special:Preferences' mobile layout icons.

Bug: T317419
Depends-On: I6d5730d47e7595b1705787995fe5db2fe734d7f5
Change-Id: I40a1783a24a2d643026132038a71a027d69f178f
2022-10-28 11:39:20 -05:00
Matthias Mullie a0555ee377 Break up words to prevent thumbnails from being squished
Bug: T321362
Change-Id: I9d649873145738808fa5a8456df4272c14e42d6a
2022-10-27 12:02:16 +02:00
Matthias Mullie 4c19038074 Override padding-left for Special:Search results
Bug: T321563
Change-Id: I5fe7c85e459fbab058cb54a3aec8503c8e7ce203
2022-10-25 16:14:46 +02:00
Arlo Breault 8c87990f0b max-width only applies to thumbs
Not frameless or plain floated media.

Bug: T318300
Change-Id: Iced12531dc8fe416c493daa82c0aa8252f9226bd
2022-10-20 17:48:58 -04:00
jenkins-bot e8f369ca6e Merge "Improve Special:Preferences mobile styles" 2022-10-05 18:47:12 +00:00
suecarmol 68d763e62a Improve Special:Preferences mobile styles
Improved the Special:Preferences CSS styles for a mobile interface

Bug: T311717
Change-Id: I50f74cf45288bd261b5e9075260445df73b03333
2022-10-05 18:28:22 +00:00
Jon Robson 400126fa91 Revert back Minerva icon features not ready for production
In Ifccaadabd72a12814d3d4d01200931f7254c6cd5 we made some modifications
to the icon specification. I haven't run these by Alex yet (as focus
is on Vector 2022) and don't
want to rush them, so for now temporarily undoing those changes here.

Changes:
- Reverts icon touch areas from new 44x44 to old 46x46
- Undoes decrease in margins between labels and icons

Bug: T319071
Change-Id: I9a02191c57b7e2d24a8bc909f820ba8db942c028
2022-10-04 00:32:23 +00:00
jenkins-bot c0b79ad3c3 Merge "Don't show thumbnails for non-NS_FILE results on Special:Search" 2022-10-03 07:25:26 +00:00
jenkins-bot 5e945307b6 Merge "Remove redundant styling rules and fix center/none halign for figures" 2022-09-27 20:22:55 +00:00
Arlo Breault 1d123e02d1 Remove redundant styling rules and fix center/none halign for figures
The rules in mediawiki.skinning.content.parsoid were made redundant by
25890e3ece.  There are some more rules
there that should be audited to see if they're still necessary or can be
moved to a more general location now that wgParserEnableLegacyMediaDOM
is being disabled and they apply more broadly than just when Parsoid
styles are requested.

Missing rules for mw-halign-center and mw-halign-none are added.

Bug: T318300
Change-Id: I34fb1ce76de24eec3b136dc6dc9ab4e07e36b809
2022-09-27 17:17:48 +00:00
jenkins-bot 716e184be1 Merge "adjusted button css layou" 2022-09-26 18:52:27 +00:00
ELLENR 8b9f1b0757 adjusted button css layou
buttons are not displayed in AMC page history

Bug: T312311
Change-Id: I390551a98d671d46e4e4d5f9f601124d1ac3f176
2022-09-26 09:43:42 -06:00
suecarmol 3d61c0ed5d Mobile Preferences: Add styles for Special:Preferences mobile
Added a stylesheet for when a user views Special:Preferences in mobile

Bug: T311717
Depends-On: Ia7a730cd7f009dbb921a810f27fae4a9ee66f793
Change-Id: I83558ca5de50fa7d8c7d75572ffa1c600f660d66
2022-09-06 19:38:26 -05:00
Matthias Mullie 3a7d506381 Don't show thumbnails for non-NS_FILE results on Special:Search
Related: I2a679b51758020d3e822da01a1bde1ae632b0b0a
Bug: T306883
Change-Id: I562dea721e7dc587ced739ef5d974a82e16a1e70
2022-09-02 16:01:04 +02:00
Ed Sanders f3ba1af953 Cleanup: Use .position-sticky() mixin from core
Change-Id: I2972eb33dc5ce54fa3ad23e1b52893b52ee13526
2022-08-16 07:51:03 +00:00
Ed Sanders ac317d1146 Fix CSS selectors for Parsoid images
A Parsoid-like DOM is used in VE.

Bug: T313172
Change-Id: I29bd59ff21c920fff3dddf9d1a58a823b460a97c
2022-07-26 01:47:45 +00:00
Ed Sanders d926771bd8 Remove deprecated vendor prefixes and their mixins
Additional change:
* The animation stylesheet pulled down for the storybook instance
in dev-scripts/setup-storybook.sh is no longer referenced anywhere
in assets so can be removed.

Bug: T306486
Bug: T308351
Bug: T308360
Change-Id: Ia9f2a05cde2724486f7e449261c5d4875388f5ab
2022-05-23 23:18:43 +00:00
Ed Sanders 86caa17713 build: Update linters and linter config
* Update stylelint-config-wikimedia to 0.13.0
* Ensure eslintrc.js and root files are linted
  with server config

Change-Id: I59c49fedd5b0c4c5620f960b78e4f781a6bc5abb
2022-05-18 14:33:23 +01:00
Jon Robson 9ffc476b1d Contributions headings should be border box
On mobile devices this is adding horizontal scrolling

Bug: T301798
Change-Id: Ibee771dce4924b138d3dd3df502659b2ea17c66d
2022-03-31 10:30:11 -07:00
Jon Robson 5586526d18 Show the mw-index-pager-list-header
Note this will not go into effect until Iae32ce9eab163bcb5b5b95dfd19c03276bc0f1a9
has been merged which enables skin styling.

The order is intentional to avoid leaving master in a state where
the heading is unstyled but shown.

Bug: T301798
Change-Id: Ia7836a42bfd90379fab981cbd6c64a1c00b29399
2022-03-23 19:22:12 +00:00
Jon Robson 3f9e007745 Remove message box h2 style
Depends-On: Ia57d98d4be39028aa2dfe4ed737755fca79c0db3
Bug: T300306
Change-Id: I1a5ba80ffb219cd7c1e26ea6b18e12237bd78482
2022-02-09 17:49:51 +00:00
jdlrobson f9a8703a64 Minerva uses core page title handling
Bug: T265892
Change-Id: I2ffdedd64414ffb3c6e441391a75fd6e744847a4
2021-12-20 19:39:42 +00:00
Derk-Jan Hartman a0bb9e41ee Fix viewport overflow in RC/Watchlist editsummaries
Set a max-width on this floated element

Bug: T297045
Change-Id: Ie33d7052eb1138cb98543c53410c1f376f3e0e64
2021-12-06 22:22:22 +00:00
Volker E 9c38f7ec82 drawers: Remove outdated supported browser property
IE9 on Windows Phone workarounds are of no use any more.
The `right: 0` and `left: 0` properties below are sufficient in
currently supported browsers.

Change-Id: Ibfb29d1b009cb0ea33bc3cb9be39ee579e981b1a
2021-12-02 13:47:08 -08:00
bwang 03387718cf Clean up MobileFrontend overlay skin styles
Bug: T294033
Depends-on: Ibd4ef00615a1119601c729f2481ff87adaf8c86c
Change-Id: Id1c07205aec59481cc14ddb39c441fafa256e46b
2021-11-04 20:50:49 +00:00
bwang f1c828e19d Refactor Minerva header and overlay headers to use flexbox
- Move new header styles to header.less
- Remove unnecessary styles
- Update search overlay to be aligned with the heading searchbox on all screen sizes
- Add temporary skin style to ensure no regressions in mobile VE

Bug: T294033
Change-Id: Ib9867d1b76b602f3355e9f2689f137bc84b0c929
2021-11-04 15:50:00 -05:00
bwang d1049e5407 Restrict overlay button styles to non icon buttons
Bug: T294146
Change-Id: I5f5568407dda5f3a021d64de9efc2bc7aeb5b458
2021-10-22 18:48:26 +00:00
jdlrobson a7b66f6f63 Remove MinervaTemplate::getContentHtml
* Move method to SkinMinerva
* Turn preparePageContent into a getter that returns the subject
page
* Use getSubjectPage in template

For mobile special pages this now means the page has two .content elements
On those pages I've disabled the initial content element. It also means
various .content <heading> and .content ul  rules now apply that need to be
disabled.

While testing several other issues were taken care of - for example
the h2 in errors

Depends-On: I7761396d6a33830f279742be01240796573556a7
Bug: T291871
Change-Id: I13bc4b5dae7aed86eca31ef306212365e1759481
2021-10-15 20:49:23 +00:00
jdlrobson 3a88911209 Remove whitespace to right of search input in overlay
Bug: T292107
Change-Id: I1143747600a1ffb25dcfe8600c5cd352afb25159
2021-10-12 16:26:53 +00:00
Kosta Harlan 9fac869b8e Revert "Search header should be vertically centered, not top aligned."
This reverts commit d6d26e45bb.

Reason for revert: T292030

Bug: T292030
Change-Id: Ie564139ae0ae5e79389fd9b2beca4e69f36e3e5e
2021-09-29 08:30:03 +00:00
jdlrobson d6d26e45bb Search header should be vertically centered, not top aligned.
Change-Id: I6aa643266a85ec61f2220b12907822d2d03f33c9
2021-09-27 21:35:27 +00:00
jenkins-bot 7791635c0f Merge "minerva-header class is now in cached HTML, remove old header class" 2021-07-21 23:54:23 +00:00
jdlrobson 9fa0f3a64d Use MediaWiki UI version 2 from core in Minerva
Depends-on: Ibc136a17662ae839f90babb21e0f7e8f27b7a7d5
Bug: T191021
Change-Id: Ifdc3a3273aa93129177a11814651ec811c20f49c
2021-07-20 11:59:23 -07:00
jdlrobson ca18ad75d3 minerva-header class is now in cached HTML, remove old header class
This completes the migration from header to minerva-header

Bug: T172626
Change-Id: Ibb86359e683e08d86091f855e3813a99e0ad2cee
2021-07-20 18:36:39 +00:00
ExE Boss 27525d0bff Fix style conflict with content using class="header"
Content using `header` as a CSS class was affected by skin styles
in Minerva being insufficiently specific to the skin‑specific elements.

This changes Minerva to use `class="minerva‑header"`, thus avoiding
the conflict and matching what Vector does.

Bug: T172626
Change-Id: Id8fbe61b2d1d4a89ec11ddfdf7837be797b3bd20
2021-07-16 20:39:24 +00:00
Alexander Vorwerk 9494e1dc80 Drop unused class and style
Droping the unused .navigation-full-screen class and the unused MobileMenu Skin style. This is a follow-up work on: I30b1af8b88dd146d62f0de7a6352c4117a7cdd90

Bug: T252005
Change-Id: Ia1698b5477a159f17a16a6591ee774920f403b79
2021-05-02 17:42:43 +02:00
jdlrobson 685387220f Message box styles for Minerva come from core
Just as before styles for message boxes will be
kept off the critical path of most page views and
loaded on special pages, old revisions and action= URIs,
however unlike before the CSS will come from the definition
in core.

It must also be loaded in JavaScript for compatibility
with the use of warnings in JavaScript, for example 
MobileFrontend overlays.

This change will allow us to remove the
mobile.messageBox.styles module in MobileFrontend
I8b6bdfceaf33b9527dbe6790d2a39e335fb692b2

Bug: T233160
Change-Id: I7d8d1d34621c36c26ec03a3773d4d1e67bd14f2e
2021-04-12 21:45:53 +00:00
yash9265 b14d4e04af Add max-width limit to empty watchlist page
On the Watchlist, when there are no results, the page uses .info and
.empty-page classes. This results in text running without max-length.

Add max-width rule to contain it.

Bug: T222872
Change-Id: I768f800a49e756da1ad2c123c842c37d18fa3310
2021-01-21 19:49:32 +00:00
Sam Wilson df14b078c0 Fix style of clock icon in changes lists
Override core styles for the watchlist expiry clock icon in
Recent Changes and Watchlists.

Bug: T261415
Depends-On: I621b1571b57686beb9fb5802533b1e70d293bc2a
Change-Id: Iefdd271aeb6135771aae832e930fe02c73248110
2020-09-23 10:47:45 +08:00
Sam Wilson e9ad028a5b Center and align the expiry dropdown in watchstar widget
Move the watchlist expiry dropdown list to be aligned in the
centre, and its contents to be left-aligned.

Bug: T261990
Change-Id: I3073618606636c78e6afb5bf19726c7b3973292b
2020-09-21 13:24:03 +08:00
Peter Ovchyn 402aaad6ff Move css styles related to lazy-image-placeholder to skinStyles
`lazy-image-placeholder` is needed only when MobileFrontend is enabled.
So it makes sense to move those styles to mobile.init css. See more details here: T199351#6380240

Bug: T260406
Change-Id: I16ca734af33fb0f3c4c67f20bbca8631279d7778
2020-08-18 16:51:02 +00:00
Ed Sanders 13449aed52 Remove styles moved over to Echo
Bug: T258936
Depends-On: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
Change-Id: Ic9b03bab0db39ccbed5b05c89577be18bb17c8de
2020-07-28 09:49:33 +00:00
Ed Sanders 58b9721e9c Remove -affixed selector
'affixed' no longer appears anywhere else in Minerva or Echo.

Change-Id: I540beddd7bfee12d699e3596130c65bcf041d036
2020-07-28 09:49:26 +00:00
Ed Sanders 84e1ddd5a8 Fix layout of NotificationsInboxWidget on narrow screen
Bug: T258939
Change-Id: Idfb9b3b5613932c92493df5aa93b5353cc07d7c2
2020-07-28 09:49:09 +00:00
AronDemian e0193eba9b Rename @fontFamily* variables to WikimediaUI Base naming convention
Renaming:
- @fontFamilySans -> @font-family-system-sans
- @fontFamilyBase -> @font-family-base
As defined in: https://phabricator.wikimedia.org/source/wikimedia-ui-base/browse/master/wikimedia-ui-base.less$201

Bug: T245136
Change-Id: Idec2c516efe2a6ee82efdf3cc6be173bedbb5b56
2020-06-25 19:51:11 +00:00