In 2049c81e776f these were marked as being targeted
on mobile, meaning they would start to load on mobile site.
Minerva doesn't blank skin styles by default so gets the "default"
set of styles.
Since these have a negative effect this is not likely desired
so we should blank the styles to restore how it used to be for
now.
Bug: T327661
Change-Id: Ifc6cdb4a1d756edf23396b462ba4447f676ab737
The `webdriverio` package does not need to be an explicit dependency.
It is a dependency of `@wdio/cli`.
Bug: T325059
Change-Id: Ida611141c76efc3f945d5e0f7b99fc603d5cdb2f
This reverts commit 1ac1cdfd7e.
No longer needed with change in core
Depends-On: I6d916ffb1301bd2f4a258ec50990c4347f9c63e7
Bug: T326270
Change-Id: I73559c23943a25bbcaea5ba1576155a887d4ba70
These styles have drifted away from the HTML structure since they were
written in 2017.
General:
* Add some comments
* Replace complicated selectors with simple class selectors
styles.less:
* Hide section edit links (previously we relied on MobileFrontend
styles, which one handled some cases - removing them in I9a88b80c2a)
* Show print footer, hide Minerva footer
header.less:
* Remove FIXME (resolved in c323c6858a).
* Fix hiding the search box. In 0bee6a1eb6 a <form> for the search box
was added to the header, and these styles (using tag selectors) were
not updated. Use class selectors instead.
* Remove styles for <h1>. The element was changed to <a> in
a905b1c161, styles to override font-size etc. are no longer needed.
* Consolidate 'padding' rules and remove unneeded !important.
article.less:
* Replace the `[ class|='mw-content' ]` selector, which was not
matching anything. It would match elements with `class="mw-content"`
or `class="mw-content-…"`, but the node we're trying to style has
`class="mw-body-content mw-content-ltr"` (since 7cda5b0bf8 in
MediaWiki core). Use a class selector instead.
* Replace the `.mw-body > .content` selector too. While this one
works, it is also needlessly complicated.
footer.less:
* Fix and simplify how last-modified info and license text is unhidden
(while other parts of the footer remain hidden).
* Remove styles for .license. Unused since 1f2b7dff15, use the desktop
footer added in that commit instead.
* Use the desktop footer for last-modified info, since it's more
suitable for "archiving" (it has a date rather than time ago).
Bug: T323636
Change-Id: I21ef26355e3e6dd8b0c34ae933b7f5b0b222655c
Use a UserFactory instead of getting an id and the user objects on
second request
Also replace another deprecated User class and use the injected factory
Bug: T325687
Change-Id: Id610ee39e0ef865b97f7ae8506188eea04a86ac5
Now the confirmation step code works, we can show this button.
Update styling to generalize the thanks/rollback styling.
Depends-On: Ia03038e86c6a607c8b75eefedbf0285ca1a2f8c8
Depends-On: I5286e80f9dd683ba55b03664dc31de77c19722b7
Bug: T230657
Change-Id: Iab32d8b30d4f2d946ffdaefea72ca9b43448998d
Ieebc40073eb3d0c8a56ebc8aec3f060199943ddc lowers the breakpoint
at which search will break into 2 columns (search + interwiki),
in large part because the 2nd column will also be occupied by
Extension:SearchVue's side panel.
On mobile, Extension:SearchVue presents differently (directly
below a search result), so there's not as much need for a 2nd
column this early - wider search results are prefered.
Bug: T321377
Change-Id: I22c46cfad2e054be679d79cce9b8d1ae04e3c6f1
On desktop, the "Alert" icon had more white space around it than the
"Notice" icon, and its popup displayed with a different offset.
On mobile, the combined icon jumped around while the page was loading.
Change-Id: Icdd5bc6e8478f3453b6461a35b7fb53e8ab014e9
For consistency with desktop Vector, Minerva should show two
icons. This also removes the duplicate #pt-notifications-alert
element in the skin.
Bug: T313609
Change-Id: I6449f0c29b52fd2092d63fbef23205ed8f57d50f
