Commit graph

8 commits

Author SHA1 Message Date
Volker E bb6827122c Naming convention using 'skin' as entrance point
Similar to Ief1c469724d4ffe238d307407c3ddb46f2e1abfa

Change-Id: Ibca2473b14ef258f92e71524489298e2f53ed873
2020-05-29 14:32:12 -07:00
jdlrobson 1200cb5279 Storybook added to MinervaNeue
For now just adding story entries for footer element and last modified.

Bug: T244106
Change-Id: Ib36f22f9b9d805f87fc074d12473497cfaf91b79
2020-03-03 15:22:34 +00:00
jdlrobson 7340485014 Monitor render blocking css bundle sizes
Add a script that builds CSS for Minerva using lessc than measures
their bundlesize.

This will give us added protection to large increases in bundlesize
that can lead to performance regressions.

Change-Id: I2e5e55ad10fac7ecb5a8c19ccdf3cc54de59b75d
2020-01-29 11:03:59 +00:00
Stephen Niedzielski 8ac5b9c663 Hygiene: remove unused pre-commit script
dev-scripts/pre-commit is unused since 5037568 which added the
pre-commit NPM package. Remove the script.

Change-Id: I7b7e11415dc6ada17a5fe6bc1a390cc5de80851a
2018-09-18 17:01:31 +00:00
Antoine Musso 8a220e372c Make svg_check.sh verbose
So we know what is going on while the CPU is being busy.

Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
2017-12-11 16:50:56 +01:00
Antoine Musso a38b4f8038 Pass svg_checks.sh via ShellCheck
while read svgfile; do
    SC2162: read without -r will mangle backslashes.

if [ $(wc -c < "$svgfile") -gt $(wc -c < "$outfile") ];
    SC2046: quote to prevent word splitting

found increment was done in a subshell and hence would not be properly
incremented. Instead of:

  find | while

Switch to:

  while < <( find )

Based on https://github.com/koalaman/shellcheck/wiki/SC2031 , this way
$found is kept in the same context.

Change-Id: Id8eb1027eed373161c8e7932b7745d4f53f2fc6c
2017-12-11 16:48:49 +01:00
Fomafix db97b4e202 Make shell script robust against spaces in file names
Also
* Simplify wc.
* Add period at end of sentences.
* Use tabs instead of spaces for indenting.
* Add newline at end of file.

Change-Id: I50a9d31acecc32bcf693cba5022152aa9abcbaab
2017-08-30 12:27:19 +02:00
jdlrobson 59a17fd0af Add tooling for svg size checking
also add pre-commit hook to ensure svgs are
compressed on commit

since extensions are accessible via http an .htaccess
is added to the dev-scripts folder for safety.

Bug: T170639
Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
2017-07-14 11:07:08 -07:00