Commit graph

4405 commits

Author SHA1 Message Date
Esanders 35dfdfceb9 Revert "Any header overflow should be hidden"
This reverts commit e78d6a5216.

Reason for revert: Completely truncates the user popup menu.

Bug: T343908
Change-Id: I320103bb7563c9265afb9956b9375d2a96b37172
2023-08-10 12:54:36 +00:00
Translation updater bot 8725cb214c Localisation updates from https://translatewiki.net.
Change-Id: I97c2b6591f2087044e4de9cf0440e314274248df
2023-08-10 09:45:02 +02:00
Jon Robson 963fcb23a9 Prepare icon module selectors for Codex markup change
Bug: T342908
Change-Id: Ic41c4602ce1ae584210d3d105e823a74c9d49e65
2023-08-09 23:44:36 +00:00
jenkins-bot f9c20d8238 Merge "Any header overflow should be hidden" 2023-08-09 19:17:18 +00:00
jenkins-bot 46d2fb49a9 Merge "Fixes: Echo circle notification appears as large red square" 2023-08-09 19:06:29 +00:00
Jon Robson 7a7e8e94bb Fixes: Echo circle notification appears as large red square
Fixes https://phabricator.wikimedia.org/F37380573

Bug: T342907
Change-Id: If6701f277e88bbfa3a1d0ee9cab4678d2f30b3a9
2023-08-09 18:49:31 +00:00
Ed Sanders 9121846bbc Remove left padding from header-cancel
The padding is outside the highlighted area of the button in codex.

Change-Id: I032ba224a49d891de582fe8c069c9bff28583806
2023-08-09 17:34:54 +00:00
Jon Robson e78d6a5216 Any header overflow should be hidden
One of the child elements are flushed right.

Bug: T343908
Change-Id: I227264ad50e7ce8dbaac260d607824ec47a81739
2023-08-09 10:10:59 -07:00
Translation updater bot 2d59a77307 Localisation updates from https://translatewiki.net.
Change-Id: I2dc5f42bbe1ca7bdcd05894dc762bf1a202c3714
2023-08-09 09:17:38 +02:00
bwang 1918698e72 Fix page issue icon
Bug: T343053
Change-Id: I80595e3b851cdb4b9d4bdafe6ce7526a2e33afbe
2023-08-08 20:37:15 +00:00
jenkins-bot 0c69779b73 Merge "Echo uses Button template" 2023-08-08 17:44:22 +00:00
Jon Robson ded6430b47 Echo uses Button template
Changes
* Update FIXME in userMenu.less to merge selectors
* We replace minerva-user-notifications class with minerva-notifications
to short-circuit Echo's code so that it no longer replaces the Minerva
notification badge with its own.
* We update resources/skins.minerva.scripts/initMobile.js to introduce
our own wire up code - this is responsible for opening Echo overlay
and reseting the counter. The code in Echo will be removed in a follow
up (see <I2f923e509d24524a2375ffbe6b3ef336487574bb>)
* We update skinStyles/ext.echo.styles.badge.less with styles from Vector 2022
so that Minerva desktop remains consistent with desktop Vector 2022 experience.
* We clearly mark technical debt relating to the special mobile version.

Testing:
* Pixel.js has a group echo that covers all the different variants.
Make sure to update to latest main branch before running these.
* Desktop should behave the same for Minerva as Echo.
* On mobile only when a user has unseen notifications a red circle
is shown. Otherwise a bell icon is shown, never with number.
* On mobile a single button is visible that combines alert and count
numbers.
* With Echo disabled a bell shows that links to the user talk page

Visual changes:
* Previously the red circle became a transparent/gray circle on click. Now
it will always be red.
* Minor aligment changes to red circle and bell icon are expected as
the change prevents MobileFrontend/Echo updating the icon to use
Codex.

Bug: T342907
Change-Id: I55c18cf723a32f80b93a01dd0687e005162c4e93
2023-08-08 15:44:38 +00:00
Translation updater bot 39b64ef07f Localisation updates from https://translatewiki.net.
Change-Id: Ie3d3147d64aa2472ec1e2e4938ac2f16cff899f4
2023-08-08 09:03:27 +02:00
Phuedx b0fa66d537 Revert "Add metric platfrom event tracking on mobile desktop toggle"
This reverts commit 7856f79d11.

Reason for revert: This version of the instrument isn't in use. It was
enabled on the Beta Cluster but then superseded in I39adbce1f2c8.

Change-Id: I273a6f21a881f69298d6219e435639ced0fe8afe
2023-08-07 16:41:49 +00:00
Translation updater bot f6f6666da2 Localisation updates from https://translatewiki.net.
Change-Id: I18b99fcbe19b1d87e52b3885bbf733be4dfa65d6
2023-08-07 08:42:52 +02:00
bwang 659e5c03c8 Update remaining page issue icon selectors
Change-Id: If440e1273cc075888b907b0fd475c3c7a0bebd3d
2023-08-04 14:07:19 -05:00
bwang 465e66aad5 Update page issues to use new MF icon class
Bug: T343053
Change-Id: I917a4ac4d0a8af5162959f4514bc184670582b50
2023-08-04 16:50:26 +00:00
Translation updater bot 4f50757460 Localisation updates from https://translatewiki.net.
Change-Id: Ia08c99e1c2138e4e90b8a48840e95917cc218344
2023-08-04 09:24:17 +02:00
bwang 79f214a196 Fix toc arrow icon being too big
Change-Id: Iad9fa2f8f76a4ea596e6b2f88df9a6290f2c50ff
2023-08-03 18:43:41 +00:00
Jan Drewniak 3020e58eaa [Icons] Use IconLegacy template in menuGroup and ToggleListItem
Updates the menuGroup.mustache and ToggleListItem.mustache
templates to include the IconLegacy.mustache template partial.

These templates are used by the main menu and dropdown menus
(logged-in user menu and advanced mobile contributions 'more' menu).

This should result in no visual or HTML changes.

Bug: T342908
Change-Id: Idfad10b48c9ee9e833509e3c4063c6a4b014a31b
2023-08-03 13:11:16 +02:00
Translation updater bot 8055cfb646 Localisation updates from https://translatewiki.net.
Change-Id: I4655abaccf8694c60b42c86d92b9fd410aa19af3
2023-08-03 08:50:35 +02:00
jenkins-bot 1ca92a52d0 Merge "Avoid DB access in non-database tests" 2023-08-02 18:41:46 +00:00
jenkins-bot 601722df90 Merge "[Icons] Main menu, secondary actions and search icon are built via templates" 2023-08-02 11:09:51 +00:00
Translation updater bot 49dedb48f2 Localisation updates from https://translatewiki.net.
Change-Id: Ib79fd9d630700c47c1e3fbada6bf699a817de125
2023-08-02 09:06:32 +02:00
Jon Robson 3da423f219 [Icons] Main menu, secondary actions and search icon are built via templates
Bug: T342908
Change-Id: I30195583b35d3966d5f221241e21a0ef165a450e
2023-08-01 14:21:11 -07:00
Daimona Eaytoy b84487b6f4 Avoid DB access in non-database tests
Bug: T155147
Change-Id: I812e9695f3db0db7e8b0d1001478adc90d35652b
2023-08-01 20:04:24 +02:00
bwang e6511ebe8f Add option for different icon sizes, reduce size of arrow icon in last modified bar
Change-Id: I494a02e5ba08cc7849cf1973f8f9163c672fccff
2023-07-31 14:18:49 -05:00
Jon Robson a8362a9237 Hide image overlay slider buttons
There is one instance of icon only buttons in the overlay content.

Bug: T342936
Change-Id: I8aef02c87b63d2248c30371c98e390322f5c706c
2023-07-31 08:51:15 -07:00
jenkins-bot 7e1e418d1f Merge "Fixes: Close label showing in reference drawer" 2023-07-31 15:05:19 +00:00
Translation updater bot fcec549d01 Localisation updates from https://translatewiki.net.
Change-Id: I518a10538d4d6ae665f4d674bcffaa6cd4a3e318
2023-07-31 09:07:29 +02:00
Jan Drewniak 11e09ea7b3 [Icons] Convert history/next status bar icons to Codex
Creates a new Icon.mustache file in favour of using
MinervaUI::iconClass.

Add a new icons.less file and the following icons:
- history
- expand (next) arrow.

These icons are used exclusively in the history
status bar at the bottom of most pages.

Bug: T319260
Change-Id: If81186418fe758d7be9c3e57cf5d2aa889517f2d
2023-07-28 16:56:24 -07:00
Jon Robson ad000ae002 Fixes: Close label showing in reference drawer
Bug: T340262
Change-Id: Ib03a468aa156e4deb0ac21e7c9f40838657a55d9
2023-07-28 14:31:00 -07:00
Jon Robson 484cd5912a Fixes page issue icon
The page issue icon show on enwiki:Spain is absent.
Opportunistic bug fix while here.

Bug: T340910
Bug: T340262
Change-Id: I1eb62e462c1e83adc8daea5667c8f9052dddc54f
2023-07-28 19:52:12 +00:00
Translation updater bot 6b7a061cc3 Localisation updates from https://translatewiki.net.
Change-Id: I38cda648c1b1fbe4dab20a972c15ef48fc032c82
2023-07-28 09:26:07 +02:00
Jon Robson 6dad2802f3 Handle icon only labels with Codex in Minerva
In Minerva icon only buttons reveal themselves at desktop
resolution, except for any buttons in the header.

Bug: T340262
Change-Id: Iba6c633164a615b96bf19d5fe8f202b925bcace9
2023-07-27 23:23:44 +00:00
jenkins-bot 31d959ea73 Merge "Ensure space between download icon and text" 2023-07-27 20:15:08 +00:00
Jon Robson 0e60da8e1f Ensure space between download icon and text
Previously the rule .mw-ui-icon + span:not(:empty)
provided the margin (see mediawiki ui skinStyle) - with the refactor
of the spinner this no longer works

Follow up to I186e3d22aa9c2b331a80d35514d578949a4b9e86

Bug: T340262
Change-Id: I92446d361da9a84e27f81d9ff8d5053d96ead61c
2023-07-27 14:43:14 -05:00
Thalia 53b524fbd3 DefaultMainMenuBuilder: Use UserIdentityUtils for temporary user check
Use instead of UserNameUtils, which has more dependencies.

Change-Id: I32ca33acf2511048a8c307c20a1f1a73c9fc3cf4
2023-07-27 18:02:36 +00:00
jenkins-bot e2eaf89826 Merge "Disable flakey test" 2023-07-27 18:02:14 +00:00
Jon Robson be398f8a29 Disable flakey test
Noticed this today.

Apparently was reported a long time ago so let's disable this for
now.

Bug: T334634
Change-Id: Id46a8a7d4b9a22ed5d1bd5df5d5f9b03df1f72b0
2023-07-27 09:45:57 -07:00
Translation updater bot b6c3675604 Localisation updates from https://translatewiki.net.
Change-Id: Ie5dfa6f96b53a366da011eb60108be5e6f3babee
2023-07-27 10:51:41 +02:00
Translation updater bot 6f0ffcbe7a Localisation updates from https://translatewiki.net.
Change-Id: Iebe6b2e949378634aa053ee5138f96db366c3579
2023-07-26 10:29:23 +02:00
jenkins-bot ceda052444 Merge "Add "edit full page" to the minerva overflow menu" 2023-07-25 19:24:59 +00:00
jenkins-bot 8a2aff6fd7 Merge "[Icons] Update usage of MobileFrontend Icon code" 2023-07-25 18:11:13 +00:00
bwang 6635693826 [Icons] Update usage of MobileFrontend Icon code
Visual change:
* Improves vertical alignment of TOC

Technical change:
* Remove dependency on MobileFrontend

Bug: T319260
Change-Id: I0526293c6a99dfe078b9e32aa247522a63b6d0fd
2023-07-25 17:55:02 +00:00
Volker E e3f0eda1a3 build: Update SVGO to v3.0.2
svgo         2.8.0  →   3.0.2

Amending to new `cleanupIds` plugin name.

Bug: T339162
Change-Id: I6889eb9898c664a42c398ba810f5402f11b03fcf
2023-07-25 00:31:36 +00:00
Translation updater bot c50d87484d Localisation updates from https://translatewiki.net.
Change-Id: I19cf5c7f9ef85a1241e47aa896ed2e57bb235151
2023-07-24 09:43:34 +02:00
David Lynch 956baf5b55 Add "edit full page" to the minerva overflow menu
Bug: T203151
Change-Id: I2777a8346ab672ce2b4fcf37b19fd12ab5541224
2023-07-21 20:00:15 -05:00
Jon Robson d7fe495de6 Add temporary user icon
Bug: T340789
Change-Id: I304e8e419095a0acd7175e6eb79ecedda9b57e87
2023-07-21 18:23:55 +00:00
Translation updater bot 2b74fd0afc Localisation updates from https://translatewiki.net.
Change-Id: Ib2b3d0b0f94d271ec2fbf35bb095b1c616eb3040
2023-07-19 09:04:09 +02:00