Commit graph

3635 commits

Author SHA1 Message Date
James D. Forrester c87cbc7474 build: Organise Gruntfile.js more consistently
This also adds linting for skinStyles, with a few fixes to make these pass.

Change-Id: Id26b0bad21850d985eaaceda24fa50ad6f886458
2017-10-31 14:41:25 -07:00
Translation updater bot dec165bf37 Localisation updates from https://translatewiki.net.
Change-Id: I709cc4f913507d679dc3bcdb45db368d3a8fc860
2017-10-31 21:58:41 +01:00
jenkins-bot 326ff8ec78 Merge "Hide table of contents temporarily on Minerva desktop" 2017-10-31 01:59:40 +00:00
jdlrobson 006dfaaa12 Hide table of contents temporarily on Minerva desktop
Currently appears unstyled, so in lieu of some styles it would be
better to hide that for the time being and revisit later.

Change-Id: If0f4f02868b1344746affcec5116c325c612d145
2017-10-30 18:11:32 -07:00
jdlrobson 58729578ae BetaOptin now managed by MobileFrontend
Depends-On: I83dc2165081332453cd6fc586ae7a3ba04bd3416
Change-Id: I11200f0ff90b359e363ea7a95bf4f3b9e92a67b4
2017-10-30 17:23:41 -07:00
James D. Forrester 227cd1d071 build: Bump run-time dependencies to latest, pin
jsdoc    3.4.2  →  3.5.5
 svgo   >=0.4.4  →  0.7.2

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695c
2017-10-30 23:55:26 +00:00
Translation updater bot af20b6670e Localisation updates from https://translatewiki.net.
Change-Id: I7f5675ef6aa0a851580d809b2666eb01168f768e
2017-10-30 22:07:06 +01:00
jdlrobson d3318a9f85 Remove MobileFrontend's font changing code from Minerva
Fontchanger code now runs on all skins under the `mobile` target.
All the code will now live in MobileFrontend meaning developers
can operate inside one code base.

Depends-On: I857cfe2d9be9fe49c04c860bc234384c787239b2
Change-Id: I2759455cb6d7ddf13798e94452cb74baf502bafe
2017-10-30 19:11:16 +00:00
jdlrobson 5cb46fe9d2 Hygiene: Minerva owns PointerOverlay
The only usage is inside Minerva so we will move this module here.

Change-Id: If6859f0c8f855c6b116b254c58a6814f54b7c36d
2017-10-30 18:00:02 +00:00
Translation updater bot 8e718f258b Localisation updates from https://translatewiki.net.
Change-Id: Ibbe3195b1ae2bcfeffbf42395d286f49b2a4f31a
2017-10-29 21:58:26 +01:00
Translation updater bot 44708b0d26 Localisation updates from https://translatewiki.net.
Change-Id: I849219295a8fd69e5e4306b65abb6e4d3f0f9058
2017-10-28 21:59:06 +02:00
Translation updater bot 045044b408 Localisation updates from https://translatewiki.net.
Change-Id: I1a267c5ad4fac7bd339a7e87a88e6003cf29a8b8
2017-10-27 21:56:39 +02:00
James D. Forrester d5b4294386 build: Bump various devDependencies to latest, pin consistently
grunt                      ^1.0.1  →  1.0.1
 grunt-banana-checker       ^0.5.0  →  0.6.0
 grunt-contrib-watch        ^1.0.0  →  1.0.0
 grunt-eslint               20.0.0  → 20.1.0
 grunt-jsonlint             ^1.1.0  →  1.1.0
 grunt-notify               ^0.4.5  →  0.4.5

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695a
2017-10-26 15:48:59 -07:00
jenkins-bot accb0c6609 Merge "Minerva owns BacktoTopOverlay" 2017-10-26 20:40:18 +00:00
jdlrobson 038103299a Minerva owns BacktoTopOverlay
Not used in MobileFrontend so it is moved here from that repo.
t r
Change-Id: I97e6010026daf4c6610bcfbedf140fb2a45b1130
2017-10-26 16:34:16 -04:00
jdlrobson 12b49a70ad Notification icon should not show NaN for persian Wikipedia
Bug: T172755
Change-Id: I2884c8daed3fe0e0d05c746ec6319956b7426957
2017-10-26 20:27:12 +00:00
Translation updater bot 8a82f30dab Localisation updates from https://translatewiki.net.
Change-Id: Ic02a1cbb91ccdfdc10baa51a2b7491ab0c7c86ba
2017-10-26 21:57:18 +02:00
Translation updater bot 67724d988d Localisation updates from https://translatewiki.net.
Change-Id: I914bb8ba5edff15a82b76ee932136927daf2d007
2017-10-25 22:09:10 +02:00
Translation updater bot 9376aab9d2 Localisation updates from https://translatewiki.net.
Change-Id: I6b7670abb71bae893a63b5d45e65607bbb5694bd
2017-10-24 22:24:26 +02:00
jenkins-bot c1bfaf55c6 Merge "Disable print button on iOS" 2017-10-23 20:35:14 +00:00
Translation updater bot c86b87b3db Localisation updates from https://translatewiki.net.
Change-Id: I061466bdf2640d23bc9c2f41f5c36aec6c61da7b
2017-10-23 22:26:42 +02:00
jdlrobson 571895b754 Disable print button on iOS
As documented on the ticket, iOS does not provide PDF functionality
via print.

iOS 11 provides PDF generation but the resulting PDF is unreadable for
our content and missing styles (see T177215#3700576) and we do not know
of any way to invoke that just yet.

Bug: T177215
Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
2017-10-23 16:06:25 -04:00
jdlrobson 45a1b3b423 Add feature flagged DownloadIcon
Shortcut for print. Disabled by default and controlled by
wgMinervaDownloadIcon

Note that with lazy images enabled, images will not appear
in the printed article. This can be easily addressed inside
the onClick function in a later patchset with a few modifications
to the Skin class.

Currently the flag when enabled will show on all browsers. There
are some open questions on the ticket about how we want to limit
the feature. This shouldn't block review or merging.

Bug: T177215
Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-23 18:12:20 +00:00
Translation updater bot f3a89e7fa1 Localisation updates from https://translatewiki.net.
Change-Id: Ic542860c43da616f124f6016da4d316a4d9feaed
2017-10-22 21:59:11 +02:00
Translation updater bot 0f1c69c1b1 Localisation updates from https://translatewiki.net.
Change-Id: I0c4be59266f0f5584cffd6a87a8b03c7fb348216
2017-10-22 00:16:17 +02:00
libraryupgrader eb7323e0eb build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I4e80293c27dbc09470449acc8f6994dd846f6c70
2017-10-21 04:35:00 +00:00
Translation updater bot 100e32997c Localisation updates from https://translatewiki.net.
Change-Id: Iad580ae28e1b6a68df0aed6bd3acc0adc077d100
2017-10-20 22:01:08 +02:00
Translation updater bot 938af28d1e Localisation updates from https://translatewiki.net.
Change-Id: Icf725bc553fee7f06c662bab1ed48afa3856d64d
2017-10-19 22:05:21 +02:00
Translation updater bot 5241f3c4a1 Localisation updates from https://translatewiki.net.
Change-Id: I2bdbdceb835f96b300e0d98e283ebe5326b2db8c
2017-10-18 21:58:11 +02:00
Translation updater bot 7542d06278 Localisation updates from https://translatewiki.net.
Change-Id: Ic804a6132d9824889a4ab7b94a36fe4a28a4feba
2017-10-17 22:13:39 +02:00
jdlrobson b93b7eda7c Render add discussion button in PHP not JS
The talk page JavaScript progressively enhances an
existing button in the page.

Remove the frontend logic and rely entirely on whether
the button is in the page or not.

Additional change:
* The browser tests incorrectly suggest a user needs
5 edits to be able to use the talk feature. This is not
true. They just need to be logged in. Update that logic.

Bug: T167728
Change-Id: Iacedea30bdd0775b3d785db5b143abafd7a18b39
2017-10-16 22:35:11 +00:00
Translation updater bot 55f1192323 Localisation updates from https://translatewiki.net.
Change-Id: Iba1cc261083d21a84345d47b11afe5b019b39305
2017-10-15 22:05:27 +02:00
Translation updater bot 5d5702fdc4 Localisation updates from https://translatewiki.net.
Change-Id: I992a5b95ffb10d51263fae02288c21b63f99f1c3
2017-10-13 22:00:21 +02:00
jdlrobson 7b8530a2b2 Standardise on MinervaNeue's skin name (minerva)
We will standardise on the key "minerva" and the styles
in MediaWiki:Minerva.css for desktop since this is what is
used for mobile. The name will however appear as MinervaNeue
to be consistent with the skin repo name (not the code).

Please merge I5fdb21243e0b599b07aa228107fd4b8c306c696c
shortly after merging this to remove the remaining logic
relating to this from MobileFrontend as otherwise two skins
will appear in user preferences.

Any existing users of MinervaNeue (key minervaneue on desktop)
will be thrown back into the Vector skin and will need to opt
into the MinervaNeue skin again. This is a minor disruption
given the low amount of users and instability of the skin.

Bug: T171644
Change-Id: Ieffb6334168047dcf05dcb60281865ab47056dc0
2017-10-12 15:04:13 -07:00
jdlrobson 8729f0b654 Hygiene: Minerva uses skin instance defined by MobileFrontend
The global events for resize and throttled will also be defined
inside MobileFrontend.

Depends-On: I8503c26bd064ae0d203f95a35031468c7c678ac1
Bug: T173454
Change-Id: I00d361ad504ab90f2bf80a53a7c76269f1116207
2017-10-11 23:43:57 +00:00
jenkins-bot 1c0d0d5f3c Merge "Minerva is responsible for loading tablet modules in tablet mode" 2017-10-11 22:57:43 +00:00
jdlrobson c04c58a4d7 Minerva is responsible for loading tablet modules in tablet mode
Since Minerva is the only skin which does this kind of thing, it
was premature to add this logic to the Skin module.

By forcing Minerva to do this itself, we allow MobileFrontend to
be responsible for creating a Skin without having to know about
what that skin may want to load in tablet mode.
(see I8503c26bd064ae0d203f95a35031468c7c678ac1)

Bug: T173454
Change-Id: I32e2b4a10799a06138bfee08abc6769a6b96004d
2017-10-11 15:41:46 -07:00
Translation updater bot 4cf54c99a5 Localisation updates from https://translatewiki.net.
Change-Id: I6d70c50889ea639988d36ca49e302f2561b3fbbb
2017-10-11 22:23:40 +02:00
Translation updater bot 433f0641de Localisation updates from https://translatewiki.net.
Change-Id: Ie108d6459e61b8e4057a2d0aa70d839f947b2baf
2017-10-10 22:16:42 +02:00
Translation updater bot 1cf3c42666 Localisation updates from https://translatewiki.net.
Change-Id: Ic953facf5a8822382d2d3ceb7a19db2480fc4da4
2017-10-09 22:11:47 +02:00
jdlrobson 88a0baeb6d Hlist tweaks (size and color)
* Font size should be relative to context
* Only apply linkColor to links in footer

Bug: T169315
Change-Id: Ibb25d8b63e4efaf8b2bc4c28e3bac95a6a16db86
2017-10-09 16:40:01 +00:00
jenkins-bot 7458b6dd16 Merge "Revert "Don't run diff test on beta cluster"" 2017-10-09 16:14:44 +00:00
Jdlrobson edc817cd03 Revert "Don't run diff test on beta cluster"
This reverts commit 23e9d66780.

Change-Id: I25b7a843178d0be42956847cc2f8c897ae521b5d
2017-10-09 16:08:08 +00:00
Translation updater bot f187e734d3 Localisation updates from https://translatewiki.net.
Change-Id: Ic954331d34340c35c3c119a28c91dbfe67b74d41
2017-10-07 21:56:33 +02:00
jdlrobson 8de58c546e Avoid clashes with MediaWiki:Common.css for hlist rules
Impacts footer and main menu

Bug: T173507
Change-Id: Ie519550c0657c2314ecccaca1d65ecf99d0a3f5f
2017-10-06 15:58:50 -07:00
Translation updater bot 42e23ff4bc Localisation updates from https://translatewiki.net.
Change-Id: Ib171b45a8d65bdba722c391562be22dcc81c0f7a
2017-10-06 22:08:24 +02:00
jenkins-bot b5908fde76 Merge "Improve some parameter docs" 2017-10-05 22:06:09 +00:00
Translation updater bot a3a0e221f1 Localisation updates from https://translatewiki.net.
Change-Id: I6d7899216c2fa8dffb3c6b17911f5e78eca03e87
2017-10-05 22:08:22 +02:00
Umherirrender 8e8c9d0654 Improve some parameter docs
Change-Id: I239d4aa0023978b27bc04a7ff7d55892f3bb7feb
2017-10-05 19:17:38 +02:00
jenkins-bot 8db065c142 Merge "Correct feature phone threshold detection" 2017-10-04 21:48:49 +00:00