Commit graph

2675 commits

Author SHA1 Message Date
Peter Ovchyn 8581b2c16b Make lazy-image-placeholder vertically aligned middle by default
All images in MinervaNeue skin are vertically aligned `middle`,
so placeholder for them should be consistent.

Bug: T199351
Change-Id: I5fa00bd0c02e67059543389e4bbd07b073a2c5e0
2020-08-17 18:30:21 +00:00
Translation updater bot 0aa9561b7e Localisation updates from https://translatewiki.net.
Change-Id: I8aad4a28449505d026dcdb23360d97c3ca78e810
2020-08-17 08:47:46 +02:00
Translation updater bot c8b9876992 Localisation updates from https://translatewiki.net.
Change-Id: Ibcc9c4bcf24b440184b4d7134ccd64bbffe3874a
2020-08-14 08:43:02 +02:00
Translation updater bot 17bdca3f55 Localisation updates from https://translatewiki.net.
Change-Id: I1952da638fda90b709664e5afe82e1b9d01b3d38
2020-08-12 08:21:29 +02:00
libraryupgrader 6b397da601 build: Updating npm dependencies
* webpack: 4.43.0 → 4.44.1
  * https://npmjs.com/advisories/1548
* terser-webpack-plugin: 1.4.3 → 1.4.4
  * https://npmjs.com/advisories/1548
* mocha: 8.0.1 → 8.1.1
  * https://npmjs.com/advisories/1548

Change-Id: If82fa2aae8f0353f85dc520fb0ed8692a0bd7820
2020-08-11 23:32:31 +00:00
jenkins-bot 5e43bf1ef2 Merge "Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"" 2020-08-11 16:14:36 +00:00
Jdlrobson 74838b2fa2 Revert "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()"
This reverts commit ae8e3ad58b.

Reason for revert: This led to T260155 as the internal class uses
isSubPage which is not available on LinkTarget

Bug: T260155
Change-Id: I783f41e70cf1cf3b91737bce9cbf9ac729a778df
2020-08-11 15:50:44 +00:00
jenkins-bot e9b23132c3 Merge "ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()" 2020-08-10 21:41:21 +00:00
Translation updater bot 1a1ce71987 Localisation updates from https://translatewiki.net.
Change-Id: I196c9ab5f82b3c58401dec08b9a55ff2900dcee0
2020-08-10 09:04:17 +02:00
Derick A ae8e3ad58b ServiceWiring: Avoid usage of deprecated Title::getSubjectPage()
SkinUserPageHelper::__construct() should be able to consume a LinkTarget
too as NamespaceInfo::getSubjectPage() method returns a LinkTarget and
the Title::getSubjectPage() is deprecated.

Change-Id: I08bfc9bb21772b450798b6354bee2ab09d5dba4d
2020-08-08 14:07:48 +01:00
Translation updater bot 146cb2bb3b Localisation updates from https://translatewiki.net.
Change-Id: I1578e2c913f32ef29e9bb8d0f51ffcea9c73e668
2020-08-07 08:24:43 +02:00
Translation updater bot 178735396f Localisation updates from https://translatewiki.net.
Change-Id: I4f2a43c7365a9abe6b053739e089b5b9a7653f67
2020-08-06 08:29:51 +02:00
jenkins-bot 9d4a717615 Merge "Specify the responsive option rather than manually specifying viewport" 2020-08-04 20:46:54 +00:00
jenkins-bot a477102e7e Merge "Don't add the "minerva--history-page-action-enabled" class to <body> for non-Minerva skins like MonoBook etc." 2020-08-03 21:09:17 +00:00
Jack Phoenix 2060ead391 Don't add the "minerva--history-page-action-enabled" class to <body> for non-Minerva skins like MonoBook etc.
Hooks are global, hence any and all skin-specific OutputPageBodyAttributes hooks need to check first that the correct skin (or skins) is used, otherwise the class or classes get applied for *all* skins when only one skin is supposed to be targeted.

Also fixed a tiny code style issue in the same hook subscriber while at it.

Change-Id: I626b0e050c614687b31f1ffbaea92e371dee4574
2020-08-03 20:30:28 +00:00
mainframe98 5857a9f909 Specify the responsive option rather than manually specifying viewport
I6e69b482cdbc adds a viewport with the same value as defined by Minerva.

Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: Ie8ed80f734b20a16bc1c70a94d40290909180c3b
2020-08-03 21:14:29 +02:00
Translation updater bot eab9cb47f6 Localisation updates from https://translatewiki.net.
Change-Id: I771f57444d4e6fea694a3597ddb00c397a211952
2020-08-03 08:37:09 +02:00
jenkins-bot 7b5ea29654 Merge "Run bundlesize tests on every commit" 2020-07-30 10:24:26 +00:00
libraryupgrader de68896908 build: Updating elliptic to 6.5.3
* https://npmjs.com/advisories/1547
* CVE-2020-13822

Change-Id: Ie755f6d0c3ba1f131822d2f2dbad971e8e74fe15
2020-07-29 23:13:33 +00:00
Peter Ovchyn 271fb28d99 Load mediawiki.page.ready on Minerva
Disable sortable and collapsible during mediawiki.page.ready initialisation

Add onSkinPageReadyConfig hook that overrides sortable and collapsible values.

Adds 1.74kb of JS to all page loads.

Bug: T257265
Bug: T250851
Depends-On: I0dc38e74052027f26a70d58b5f520e5830e0d55d
Change-Id: I81ff55d080c8c4a40f425ca7d0fc4fda322055dd
2020-07-29 20:57:52 +00:00
Ammar Abdulhamid 1a45b1409c Remove usage of deprecated Skin::getRevisionId()
OutputPage has similar method and they are being used
interchangeably here. Let's stick with one.

Bug: T257992
Change-Id: Ia5a0fbf114f6a1fec6fb85e01a408edae8a5badb
2020-07-29 16:09:47 +01:00
Translation updater bot b5a3fa1452 Localisation updates from https://translatewiki.net.
Change-Id: I3d7167ea017aa030978270a059e884a44a5b0887
2020-07-29 08:37:50 +02:00
jdlrobson 7408d87465 Run bundlesize tests on every commit
It was added in 7340485014
but for some reason never enabled.

This was supposed to be protecting us from performance regressions
by monitoring the size of modules in the repo. It appears to be
broken both locally and on Jenkins when run on the due to some changes
in Phabricator.

Since then we've added bundle size tests to Vector using a different
more foolproof method. I think that method is more preferable as it
also provides coverage for JS and icons so the
associated script is copied over and used in Minerva
and activated on all commits.

Bug: T259080
Change-Id: I9ba2dcc060ec09d91814c947d5be3f71b055a66e
2020-07-28 23:43:38 +00:00
jdlrobson 065b6e52b2 QA: Restore nested reference test
References clicks should now apply to the `sup` element not `a`
as the `a` element can contain spans.

Depends-On: I0d5bb398e99465ade357743dd3ff34ae551243c5
Bug: T258096
Change-Id: I5d8cae5f465a86282796b3fdc6bc658f6c836432
2020-07-28 21:53:19 +00:00
Edward Tadros 6f1fb87414 Selenium: Skip nested reference test.
BUG: T258096
Change-Id: Ie16eb622384a48ad2b060a720ea3e8e6abfb1fa2
2020-07-28 13:55:36 -07:00
Ed Sanders 13449aed52 Remove styles moved over to Echo
Bug: T258936
Depends-On: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
Change-Id: Ic9b03bab0db39ccbed5b05c89577be18bb17c8de
2020-07-28 09:49:33 +00:00
Ed Sanders 58b9721e9c Remove -affixed selector
'affixed' no longer appears anywhere else in Minerva or Echo.

Change-Id: I540beddd7bfee12d699e3596130c65bcf041d036
2020-07-28 09:49:26 +00:00
Ed Sanders 84e1ddd5a8 Fix layout of NotificationsInboxWidget on narrow screen
Bug: T258939
Change-Id: Idfb9b3b5613932c92493df5aa93b5353cc07d7c2
2020-07-28 09:49:09 +00:00
Translation updater bot 26dd206510 Localisation updates from https://translatewiki.net.
Change-Id: Iad703000b5d8935de4e566e87a7beff45552bf9b
2020-07-28 08:26:33 +02:00
jenkins-bot 4cfe275cdc Merge "Add languages/all route for LanguageInfo overlay" 2020-07-28 01:44:48 +00:00
Kosta Harlan f915d69872 Add languages/all route for LanguageInfo overlay
Depends-On: Ic0f1613e8fd27788f67ed6235386491f0fe077c3
Bug: T232410
Change-Id: Ib558dc7c46cc56ff667957f9126bbe0471d25b8e
2020-07-27 12:39:50 +02:00
Translation updater bot b5c20d2d64 Localisation updates from https://translatewiki.net.
Change-Id: I5f3a45bb7ec3c36a2189971168aa6b1fb83b0318
2020-07-27 08:41:11 +02:00
jenkins-bot 9a4abda6e8 Merge "Nested references should not trigger console warning" 2020-07-24 22:50:43 +00:00
jdlrobson 346bfba3f4 Nested references should not trigger console warning
I don't think it will fix the failing browser tests
but it will rule out Minerva / MobileFrontend as the cause in the
analysis.

This mirrors the codepath in Minerva that's triggering the warning.

Bug: T258096
Change-Id: Idd1c224c02e3d300889b6735fa1b9800212690ff
2020-07-24 22:09:07 +00:00
jenkins-bot c912396b67 Merge "MinervaHooks: Remove unreachable code related to Special:MobileMenu" 2020-07-24 16:11:18 +00:00
Derick A 568367a8c0 MinervaHooks: Remove unreachable code related to Special:MobileMenu
This is a follow-up work on: I30b1af8b88dd146d62f0de7a6352c4117a7cdd90.

Bug: T252005
Change-Id: Iefb56ad9b9c68196d06b96209a73e94aa69a1e2e
2020-07-24 15:43:21 +00:00
Ed Sanders bc945fa15c Apply mobile width fixes to infoboxes explicitly
Previously they were just inheriting from `table`, but
now we don't require .infobox to use a specific element
they should be applied separately.

Fix table max-width override to use !important as this
too could be specified inline.

Bug: T258011
Change-Id: I4f28414fd965ae9f608b5e52047b9d474427853a
2020-07-24 15:42:59 +00:00
Translation updater bot 5294147136 Localisation updates from https://translatewiki.net.
Change-Id: I05781a420489068dda56b07b0b181314637d2025
2020-07-24 08:29:25 +02:00
jenkins-bot 55a34beafd Merge "Apply infobox styles to any element with the class" 2020-07-24 00:40:48 +00:00
Translation updater bot e85e8f64db Localisation updates from https://translatewiki.net.
Change-Id: Ia7131e1821597dd7f640ea9ac738986658b33d2c
2020-07-23 08:31:00 +02:00
Translation updater bot d0c30b4b24 Localisation updates from https://translatewiki.net.
Change-Id: I62d09a8fcc1b95f2bda03b9661d81b8c3ea6a6bd
2020-07-22 08:29:01 +02:00
libraryupgrader bfd7129ced build: Updating grunt to 1.2.1
Change-Id: Ic7c65bd8f950dfbe9651294fd83a25e2b9b89f25
2020-07-21 22:23:47 +00:00
Translation updater bot 2f2f40a4bd Localisation updates from https://translatewiki.net.
Change-Id: I91c9798bae17363a4c3c36383aefe9692734e64f
2020-07-21 09:18:35 +02:00
Translation updater bot d885ccea30 Localisation updates from https://translatewiki.net.
Change-Id: I0c4f2f67be930ad16418a41b8950baf4b773bae4
2020-07-20 09:04:18 +02:00
Ed Sanders e8d5462bb3 Apply infobox styles to any element with the class
MoveLeadParagraphTransform treats div.infobox the same as table.infobox,
and should be fixed to match any element too.

Fix specificity of tablet overrides.

Bug: T258011
Change-Id: I9ada6d1b8b19b46dba6527f1f66edd2547fa0c88
2020-07-17 22:09:30 +01:00
jdlrobson 6b8f8568a1 Restrict the number of errors we log in a given session
One IP address, logged 3,029 errors across 2 pages
This is not helpful as it makes the error seem more widespread
than it really is so let's not logged errors after the first 5.

Change-Id: I8abfc3c3852827ab84a06740356e9b9f659a2d03
2020-07-17 19:05:25 +00:00
Translation updater bot ba5918bd74 Localisation updates from https://translatewiki.net.
Change-Id: I7f5e75c6e16368d624d3db71be13478d5b9ec0d3
2020-07-17 08:31:12 +02:00
libraryupgrader 101730e31d build: Updating eslint-config-wikimedia to 0.16.2
Change-Id: I4d39554093ea299f5e86c26ebec89ff0b135bf81
2020-07-16 04:24:20 +00:00
Translation updater bot 306f99cdd3 Localisation updates from https://translatewiki.net.
Change-Id: Ie627233229277f6f2de6368c53a8f23b48aa9792
2020-07-15 09:07:32 +02:00
jenkins-bot 18c0eb4964 Merge "Selenium: Update WebdriverIO to version 6" 2020-07-14 13:55:34 +00:00