The Minerva storybook only has 2 stories which look broken.
Given we never actively began using it, I suggest we remove it
from the repo.
Bug: T310004
Change-Id: I42ce4248f376c683ddbbf3f1ec0e275906f6ab45
(cherry picked from commit 0dbe68f974)
Simplify readability and reduce output to errors only on terminal.
Also includes suppression for consecutive errors as added in Popups
in I5ef7843c9de122c8dce61fbb98737c8acdd0c22c.
Change-Id: Ib4705667815cf690e327fdc5f9048c6d6ce779a6
Upgrading to SVGO v2.3.0 and changing over to new JS config.
Also amending svg check shell script and re-crushing
all SVGs.
Bug: T278656
Change-Id: Ic52d7eb595073e5bde166e5cf5767772c5eb60ce
For now, only define:
- @font-family-sans (unused in MinervaNeue, but for possible future use)
- @border-radius-base
With current implementation before this patch, MinervaNeue is relying on core's default
`@border-radius` which is set to `0` to be close to HTML default.
MinervaNeue is currently not applying correct skin's `border-radius`.
Bug: T263270
Change-Id: I9a149eefd15efede27416ada4db07072e53628ec
* Correctly pull down mediawiki.skin.variables.less
* Update source of clock icon in last modified bar
* Update query selectors
* Push to docs.wikimedia.org so things do not break so easily
again
Bug: T263270
Change-Id: I93cb7e53fb78d3a03019583b3b0c69a057088044
It was added in 7340485014
but for some reason never enabled.
This was supposed to be protecting us from performance regressions
by monitoring the size of modules in the repo. It appears to be
broken both locally and on Jenkins when run on the due to some changes
in Phabricator.
Since then we've added bundle size tests to Vector using a different
more foolproof method. I think that method is more preferable as it
also provides coverage for JS and icons so the
associated script is copied over and used in Minerva
and activated on all commits.
Bug: T259080
Change-Id: I9ba2dcc060ec09d91814c947d5be3f71b055a66e
Add a script that builds CSS for Minerva using lessc than measures
their bundlesize.
This will give us added protection to large increases in bundlesize
that can lead to performance regressions.
Change-Id: I2e5e55ad10fac7ecb5a8c19ccdf3cc54de59b75d
dev-scripts/pre-commit is unused since 5037568 which added the
pre-commit NPM package. Remove the script.
Change-Id: I7b7e11415dc6ada17a5fe6bc1a390cc5de80851a
while read svgfile; do
SC2162: read without -r will mangle backslashes.
if [ $(wc -c < "$svgfile") -gt $(wc -c < "$outfile") ];
SC2046: quote to prevent word splitting
found increment was done in a subshell and hence would not be properly
incremented. Instead of:
find | while
Switch to:
while < <( find )
Based on https://github.com/koalaman/shellcheck/wiki/SC2031 , this way
$found is kept in the same context.
Change-Id: Id8eb1027eed373161c8e7932b7745d4f53f2fc6c
Also
* Simplify wc.
* Add period at end of sentences.
* Use tabs instead of spaces for indenting.
* Add newline at end of file.
Change-Id: I50a9d31acecc32bcf693cba5022152aa9abcbaab
also add pre-commit hook to ensure svgs are
compressed on commit
since extensions are accessible via http an .htaccess
is added to the dev-scripts folder for safety.
Bug: T170639
Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
