Commit graph

3875 commits

Author SHA1 Message Date
Umherirrender 7701ce2641 Use HookHandlers for MobileFrontend hooks
The use of "HookHandlers" attribute in extension.json makes it possible
to inject services into hook handler classes in a future patch.

Bug: T315823
Change-Id: I9422f0cf7d5c14db544ea67c564d34e9eca3813b
2023-08-15 17:02:31 +02:00
Translation updater bot ce29be7f36 Localisation updates from https://translatewiki.net.
Change-Id: If6daa9b86acdc7bd3516cfa76a818373279cb666
2023-08-14 09:20:57 +02:00
Jon Robson b7b4e4b01f Remove icons from about and disclaimer link and minerva-icon class
Legacy icons shouldn't have the minerva-icon class as this is meant
to be reserved for Icon template (Codex icons)

Bug: T342908
Change-Id: I63556fe42c8650bc5f0d6e5a0c5328b3f29d75f3
2023-08-11 11:56:08 -07:00
Jon Robson f3c1b06ce6 Move button styles out of icons.less
Follow up to
I84407fb562c288bafe02e97ba7f3366de7f61611

Change-Id: I80c2b63077d38203fcef09d473c82f5566a92467
2023-08-11 17:54:59 +00:00
Jon Robson 12f3e033a7 Redo icon sizing
The current implementation enforces the size to be part of the
icon name. It would be preferable to have a specific class for
controlling size given we don't want to have to update all the
names of our icons.

Bug: T342908
Change-Id: I84407fb562c288bafe02e97ba7f3366de7f61611
2023-08-11 17:08:28 +00:00
jenkins-bot de9a9012b9 Merge "Revert "Use !important for removing after"" 2023-08-10 23:45:29 +00:00
Jdlrobson 9aa0e4139c Revert "Use !important for removing after"
This reverts commit 3474a0b90f.

Reason for revert: The after pseudo element appears to be needed
for the notification circle unfortunately. This is not a requirement
for this train so I suggest we tackle this later.

Change-Id: Id6d073435155bb1b0f9a2306c88de7fcf1f7ece5
2023-08-10 23:29:49 +00:00
Jon Robson 0c6ac2926d Edit icon uses template parser
Bug: T344007
Change-Id: I772f2c8be7e4f48e9d67a5d1d7d3ef9e6af17851
2023-08-10 22:04:11 +00:00
jenkins-bot 94b339d905 Merge "Remove user page from menu for temp users" 2023-08-10 21:45:47 +00:00
jenkins-bot e7e8e5f3c9 Merge "Prepare icon module selectors for Codex markup change" 2023-08-10 21:39:26 +00:00
jenkins-bot b665f5c8b1 Merge "Use !important for removing after" 2023-08-10 21:10:45 +00:00
jenkins-bot cc82b845dc Merge "Fix the height of cdx-button in header-overlay" 2023-08-10 20:40:47 +00:00
Jon Robson 3474a0b90f Use !important for removing after
Follow up to e86f197cfa
This apparently will become a problem when we switch to Codex

Bug: T343920
Change-Id: I796856a8c2c5e9d0677552d63a730834021bbeee
2023-08-10 20:38:13 +00:00
jenkins-bot 8a8bc0a404 Merge "Fix header overflow style causing header buttons from being cut off" 2023-08-10 20:21:00 +00:00
jenkins-bot f96bd6f311 Merge "[Icons] Use Button template in PageActionsMenu." 2023-08-10 19:57:14 +00:00
Jon Robson d342cb32ef [Icons] Use Button template in PageActionsMenu.
Use the Button.mustache partial in the
PageActionsMenu.mustache template.

This converts the page actions menu to use the Button
template in a way that doesn't change the existing HTML.
The mw-ui-icon-element and mw-ui-icon-with-label-desktop
classes are placed onto the Button.mustache markup.

Bug: T342908
Change-Id: Ib5dadd929eea2e72a24e061c4174348615890617
2023-08-10 19:27:44 +00:00
bwang 0648dbf29c Fix header overflow style causing header buttons from being cut off
Reverts the change to flushing for notification icons in
I55c18cf723a32f80b93a01dd0687e005162c4e93

Bug: T343908
Change-Id: I1c9b9969c822f90f8edeb90ce8b27d79d378cf64
2023-08-10 18:14:05 +00:00
bwang 97bec652bd Remove user page from menu for temp users
Bug: T340152
Depends-on: Ic99c9cf2c8e7ea9a6520b4c9b6e5b69d358cbd58
Change-Id: I01405d534672b0dc265610d3b35f55f96507ba8a
2023-08-10 17:01:06 +00:00
Ed Sanders 94d5779d21 Fix the height of cdx-button in header-overlay
Set to 3em high, like mw-ui-button.

Bug: T343995
Change-Id: Id3b75150a429585d30745ee606a782e926cbe9a7
2023-08-10 15:33:43 +00:00
jenkins-bot 5b87b66e46 Merge "Revert "Any header overflow should be hidden"" 2023-08-10 13:09:30 +00:00
Esanders 35dfdfceb9 Revert "Any header overflow should be hidden"
This reverts commit e78d6a5216.

Reason for revert: Completely truncates the user popup menu.

Bug: T343908
Change-Id: I320103bb7563c9265afb9956b9375d2a96b37172
2023-08-10 12:54:36 +00:00
Translation updater bot 8725cb214c Localisation updates from https://translatewiki.net.
Change-Id: I97c2b6591f2087044e4de9cf0440e314274248df
2023-08-10 09:45:02 +02:00
Jon Robson 963fcb23a9 Prepare icon module selectors for Codex markup change
Bug: T342908
Change-Id: Ic41c4602ce1ae584210d3d105e823a74c9d49e65
2023-08-09 23:44:36 +00:00
jenkins-bot f9c20d8238 Merge "Any header overflow should be hidden" 2023-08-09 19:17:18 +00:00
jenkins-bot 46d2fb49a9 Merge "Fixes: Echo circle notification appears as large red square" 2023-08-09 19:06:29 +00:00
Jon Robson 7a7e8e94bb Fixes: Echo circle notification appears as large red square
Fixes https://phabricator.wikimedia.org/F37380573

Bug: T342907
Change-Id: If6701f277e88bbfa3a1d0ee9cab4678d2f30b3a9
2023-08-09 18:49:31 +00:00
Ed Sanders 9121846bbc Remove left padding from header-cancel
The padding is outside the highlighted area of the button in codex.

Change-Id: I032ba224a49d891de582fe8c069c9bff28583806
2023-08-09 17:34:54 +00:00
Jon Robson e78d6a5216 Any header overflow should be hidden
One of the child elements are flushed right.

Bug: T343908
Change-Id: I227264ad50e7ce8dbaac260d607824ec47a81739
2023-08-09 10:10:59 -07:00
Translation updater bot 2d59a77307 Localisation updates from https://translatewiki.net.
Change-Id: I2dc5f42bbe1ca7bdcd05894dc762bf1a202c3714
2023-08-09 09:17:38 +02:00
bwang 1918698e72 Fix page issue icon
Bug: T343053
Change-Id: I80595e3b851cdb4b9d4bdafe6ce7526a2e33afbe
2023-08-08 20:37:15 +00:00
jenkins-bot 0c69779b73 Merge "Echo uses Button template" 2023-08-08 17:44:22 +00:00
Jon Robson ded6430b47 Echo uses Button template
Changes
* Update FIXME in userMenu.less to merge selectors
* We replace minerva-user-notifications class with minerva-notifications
to short-circuit Echo's code so that it no longer replaces the Minerva
notification badge with its own.
* We update resources/skins.minerva.scripts/initMobile.js to introduce
our own wire up code - this is responsible for opening Echo overlay
and reseting the counter. The code in Echo will be removed in a follow
up (see <I2f923e509d24524a2375ffbe6b3ef336487574bb>)
* We update skinStyles/ext.echo.styles.badge.less with styles from Vector 2022
so that Minerva desktop remains consistent with desktop Vector 2022 experience.
* We clearly mark technical debt relating to the special mobile version.

Testing:
* Pixel.js has a group echo that covers all the different variants.
Make sure to update to latest main branch before running these.
* Desktop should behave the same for Minerva as Echo.
* On mobile only when a user has unseen notifications a red circle
is shown. Otherwise a bell icon is shown, never with number.
* On mobile a single button is visible that combines alert and count
numbers.
* With Echo disabled a bell shows that links to the user talk page

Visual changes:
* Previously the red circle became a transparent/gray circle on click. Now
it will always be red.
* Minor aligment changes to red circle and bell icon are expected as
the change prevents MobileFrontend/Echo updating the icon to use
Codex.

Bug: T342907
Change-Id: I55c18cf723a32f80b93a01dd0687e005162c4e93
2023-08-08 15:44:38 +00:00
Translation updater bot 39b64ef07f Localisation updates from https://translatewiki.net.
Change-Id: Ie3d3147d64aa2472ec1e2e4938ac2f16cff899f4
2023-08-08 09:03:27 +02:00
Phuedx b0fa66d537 Revert "Add metric platfrom event tracking on mobile desktop toggle"
This reverts commit 7856f79d11.

Reason for revert: This version of the instrument isn't in use. It was
enabled on the Beta Cluster but then superseded in I39adbce1f2c8.

Change-Id: I273a6f21a881f69298d6219e435639ced0fe8afe
2023-08-07 16:41:49 +00:00
Translation updater bot f6f6666da2 Localisation updates from https://translatewiki.net.
Change-Id: I18b99fcbe19b1d87e52b3885bbf733be4dfa65d6
2023-08-07 08:42:52 +02:00
bwang 659e5c03c8 Update remaining page issue icon selectors
Change-Id: If440e1273cc075888b907b0fd475c3c7a0bebd3d
2023-08-04 14:07:19 -05:00
bwang 465e66aad5 Update page issues to use new MF icon class
Bug: T343053
Change-Id: I917a4ac4d0a8af5162959f4514bc184670582b50
2023-08-04 16:50:26 +00:00
Translation updater bot 4f50757460 Localisation updates from https://translatewiki.net.
Change-Id: Ia08c99e1c2138e4e90b8a48840e95917cc218344
2023-08-04 09:24:17 +02:00
bwang 79f214a196 Fix toc arrow icon being too big
Change-Id: Iad9fa2f8f76a4ea596e6b2f88df9a6290f2c50ff
2023-08-03 18:43:41 +00:00
Jan Drewniak 3020e58eaa [Icons] Use IconLegacy template in menuGroup and ToggleListItem
Updates the menuGroup.mustache and ToggleListItem.mustache
templates to include the IconLegacy.mustache template partial.

These templates are used by the main menu and dropdown menus
(logged-in user menu and advanced mobile contributions 'more' menu).

This should result in no visual or HTML changes.

Bug: T342908
Change-Id: Idfad10b48c9ee9e833509e3c4063c6a4b014a31b
2023-08-03 13:11:16 +02:00
Translation updater bot 8055cfb646 Localisation updates from https://translatewiki.net.
Change-Id: I4655abaccf8694c60b42c86d92b9fd410aa19af3
2023-08-03 08:50:35 +02:00
jenkins-bot 1ca92a52d0 Merge "Avoid DB access in non-database tests" 2023-08-02 18:41:46 +00:00
jenkins-bot 601722df90 Merge "[Icons] Main menu, secondary actions and search icon are built via templates" 2023-08-02 11:09:51 +00:00
Translation updater bot 49dedb48f2 Localisation updates from https://translatewiki.net.
Change-Id: Ib79fd9d630700c47c1e3fbada6bf699a817de125
2023-08-02 09:06:32 +02:00
Jon Robson 3da423f219 [Icons] Main menu, secondary actions and search icon are built via templates
Bug: T342908
Change-Id: I30195583b35d3966d5f221241e21a0ef165a450e
2023-08-01 14:21:11 -07:00
Daimona Eaytoy b84487b6f4 Avoid DB access in non-database tests
Bug: T155147
Change-Id: I812e9695f3db0db7e8b0d1001478adc90d35652b
2023-08-01 20:04:24 +02:00
bwang e6511ebe8f Add option for different icon sizes, reduce size of arrow icon in last modified bar
Change-Id: I494a02e5ba08cc7849cf1973f8f9163c672fccff
2023-07-31 14:18:49 -05:00
Jon Robson a8362a9237 Hide image overlay slider buttons
There is one instance of icon only buttons in the overlay content.

Bug: T342936
Change-Id: I8aef02c87b63d2248c30371c98e390322f5c706c
2023-07-31 08:51:15 -07:00
jenkins-bot 7e1e418d1f Merge "Fixes: Close label showing in reference drawer" 2023-07-31 15:05:19 +00:00
Translation updater bot fcec549d01 Localisation updates from https://translatewiki.net.
Change-Id: I518a10538d4d6ae665f4d674bcffaa6cd4a3e318
2023-07-31 09:07:29 +02:00